These are chat archives for chocolatey/ChocolateyGUI

18th
Oct 2017
Rob Reynolds
@ferventcoder
Oct 18 2017 00:00
you know that "cleaning of the build artifacts erroring" should be a retry instead of a hard failure? This is a solved problem.
yeah, it's not generating the file
Richard Simpson
@RichiCoder1
Oct 18 2017 00:02
I don't have a good answer for you there. It was generating just fine here :/
Rob Reynolds
@ferventcoder
Oct 18 2017 00:04
doesn't build locally
Richard Simpson
@RichiCoder1
Oct 18 2017 00:21
?
What do you mean?
Rob Reynolds
@ferventcoder
Oct 18 2017 00:21
gitversion.cake link 28
Richard Simpson
@RichiCoder1
Oct 18 2017 00:25
Hmm. I just ran build locally and generated the correct exe and msi
Rob Reynolds
@ferventcoder
Oct 18 2017 00:25
delete your tools folder (or wherever the cake stuff is)
and then run again
Richard Simpson
@RichiCoder1
Oct 18 2017 00:25
I had to switch the MSBuildToolVersion to 2017 as I don't have 2015 istalled, but other wise it worked
Rob Reynolds
@ferventcoder
Oct 18 2017 00:26
when it is finished, you will have hte latest cake bits in
and it will not work ;)
Richard Simpson
@RichiCoder1
Oct 18 2017 00:27
Doing so now
Where in the build did it fail?
Rob Reynolds
@ferventcoder
Oct 18 2017 00:31
immediately since I deleted the solutioninfo.cs file
Richard Simpson
@RichiCoder1
Oct 18 2017 00:34
Undelete it. I do believe it has to at least be present
Cake only updates it, not generates it (I think)
Rob Reynolds
@ferventcoder
Oct 18 2017 00:35
but it doesn't update it for me
maybe there is a variable I'm missing here
Richard Simpson
@RichiCoder1
Oct 18 2017 00:35
What target are you running?
Rob Reynolds
@ferventcoder
Oct 18 2017 00:35
the default one
Richard Simpson
@RichiCoder1
Oct 18 2017 00:36
Nope. Use the one I posted above
It'll pull the verison, but it won't update the solutioninfo.cs unless it's an appveyor build, or it's a publish/release-docs build
Rob Reynolds
@ferventcoder
Oct 18 2017 00:37
that makes sense, that makes it "IsReleaseBuild = true"
but it doesn't attempt to publish the package?
Richard Simpson
@RichiCoder1
Oct 18 2017 00:37
Nope. Ironically.
Rob Reynolds
@ferventcoder
Oct 18 2017 00:38
ugh me and my logic
Richard Simpson
@RichiCoder1
Oct 18 2017 00:39

        ShouldPublishChocolatey = (!IsLocalBuild &&
                                    !IsPullRequest &&
                                    IsMainRepository &&
                                    (IsMasterBranch || IsReleaseBranch || IsHotFixBranch) &&
                                    IsTagged &&
                                    shouldPublishChocolatey);
Rob Reynolds
@ferventcoder
Oct 18 2017 00:39
oh beautiful
what should assembly informational version look like on a true release?
Richard Simpson
@RichiCoder1
Oct 18 2017 00:41
0.15.0
Rob Reynolds
@ferventcoder
Oct 18 2017 00:41
should it have 0.15.0+Branch.upstream/master.sha.220e55b ?
Richard Simpson
@RichiCoder1
Oct 18 2017 00:41
And ifnormational should be something something master
yup
Rob Reynolds
@ferventcoder
Oct 18 2017 00:41
okay
good, that means this is in business
Richard Simpson
@RichiCoder1
Oct 18 2017 00:42
Whoop
Sorry that ended up being such a process haha
Rob Reynolds
@ferventcoder
Oct 18 2017 00:43
still not done
just another hoop man
we separated the wix build to a different build definition
and it still wants to rebuild the ChocolateyGUI project
Richard Simpson
@RichiCoder1
Oct 18 2017 00:44
What do you mean?
Rob Reynolds
@ferventcoder
Oct 18 2017 00:44
I haven't found anything that will shut that off, so it's likely we will move to the heat/candle bits in Cake instead of the project itself
ChocolateyGui.exe itself needs authenticode signed, right?
Richard Simpson
@RichiCoder1
Oct 18 2017 00:45
Hmm. Honestly I don't know. I think so
Rob Reynolds
@ferventcoder
Oct 18 2017 00:45
that is done after building the project
however the MSI builds it all and all you can sign is the MSI
so great, split up the build of the chocolatey gui project from the MSI generation
sign the executable, run the wix bits and sign the installer as well
except running the wix msbuild project rebuilds chocolatey gui and removes the signed executable
to quote a friend, "Never closer!"
Richard Simpson
@RichiCoder1
Oct 18 2017 00:53
Hmmm
I can't think of a simple solution, but a not really simple solution would be to add msbuild targets that call sign on in the output exe in ChocolateyGui.csproj, and then on the MSI after build: http://wixtoolset.org/documentation/manual/v3/overview/insignia.html
Rob Reynolds
@ferventcoder
Oct 18 2017 00:56
that's :/
:-1:
Richard Simpson
@RichiCoder1
Oct 18 2017 00:59
I don't have a better answer. Sorry
Richard Simpson
@RichiCoder1
Oct 18 2017 02:35
@ferventcoder If that's the biggest blocker, another option is to temporarily disable the project reference and hardcode the automatically pulled files
You'd need to ensure you have an updated SolutionInfo.cs, and manually build each step and pack the result, but it should work
@ferventcoder ^ That will allow building the MSI seperate from the Gui
Rob Reynolds
@ferventcoder
Oct 18 2017 06:29
@RichiCoder1 thank you. I will take a look at that in the morning
Rob Reynolds
@ferventcoder
Oct 18 2017 06:49
looks like it worked
installed on a test system and it appears all is good to go
@gep13 if you are good getting that blog post finished with those notes and getting a smaller blurb prepared for the release announcements
Rob Reynolds
@ferventcoder
Oct 18 2017 06:55
Pascal Berger
@pascalberger
Oct 18 2017 06:56
:clap: Thanks everyone for their effort on this
Rob Reynolds
@ferventcoder
Oct 18 2017 06:57
Is it weird that I'm already looking forward to 0.16.0?
since it will use markdig and has reduced the footprint by 32MB!
That's all @RichiCoder1++
@RichiCoder1++
I think choco bot is asleep
Gary Ewan Park
@gep13
Oct 18 2017 08:07
SWEET!
Yip, I will get the blog post sorted out at lunch time
Rob Reynolds
@ferventcoder
Oct 18 2017 14:24
what is the AppVeyor error about path with Cake?
Gary Ewan Park
@gep13
Oct 18 2017 14:28
I am not sure, need to figure that one out
Richard Simpson
@RichiCoder1
Oct 18 2017 14:29
What's the error?
Richard Simpson
@RichiCoder1
Oct 18 2017 14:31
Hmm. No idea
Rob Reynolds
@ferventcoder
Oct 18 2017 14:32
it moves to teardown a bit too quickly
so I'm guessing I may have introduced it
fileexists with an empty string
I am going to guess that check is not robust enough to return false when the value is null or empty
Rob Reynolds
@ferventcoder
Oct 18 2017 15:02
now the new GUI package is approved
Richard Simpson
@RichiCoder1
Oct 18 2017 15:02
🎉
Rob Reynolds
@ferventcoder
Oct 18 2017 17:30
chocolatey/ChocolateyGUI#498