Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 29 2015 13:57
    ferventcoder commented on 4af5e76
  • Jun 29 2015 13:48
    ferventcoder commented on 4af5e76
  • Jun 29 2015 13:34
    ferventcoder commented on f9ecefa
  • Apr 08 2015 05:36

    Jaykul on ListCommand

    (compare)

  • Apr 08 2015 05:36

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (maint) Line wrapping. (compare)

  • Apr 08 2015 05:10
    Jaykul commented on 5742f16
  • Apr 08 2015 05:09
    Jaykul commented on 5742f16
  • Apr 08 2015 05:07

    Jaykul on InstallCommand

    (maint) Line wrapping. (compare)

  • Apr 08 2015 04:36
    ferventcoder commented on 5742f16
  • Apr 08 2015 04:28
    Jaykul commented on 5742f16
  • Apr 08 2015 03:13
    ferventcoder commented on 5742f16
  • Apr 08 2015 03:13
    ferventcoder commented on 5742f16
  • Apr 07 2015 16:15
    ferventcoder commented on 83ef921
  • Apr 07 2015 15:06
    Jaykul commented on 83ef921
  • Apr 07 2015 14:46
    ferventcoder commented on 83ef921
  • Apr 07 2015 14:45
    ferventcoder commented on 83ef921
  • Apr 06 2015 16:32

    Jaykul on master

    Add Install and Uninstall Refac… (compare)

  • Apr 05 2015 06:33

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (compare)

  • Apr 05 2015 06:27

    Jaykul on 0.9.9.3

    (compare)

  • Apr 05 2015 06:27

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (compare)

Rob Reynolds
@ferventcoder
:)
but I don’t have a windows 10 box with the updated preview yet
Joel Bennett
@Jaykul
@ferventcoder you around?
Rob Reynolds
@ferventcoder
Nope - but I can catch up later.
Alternatively we can schedule some pairing for design/changes if that's what you are looking for @Jaykul
Joel Bennett
@Jaykul
Yeah, maybe ...
I want to get this done
But I don't feel like we have an agreement on the new interface/api
And there's no point doing it if you aren't going to take the pull request ;-)
Rob Reynolds
@ferventcoder
I wouldn't say that we don't have an agreement. If you are referring to the comments - that's pretty standard.
The commit messages will def need fixed up. They don't meet the guidelines. Alos standard expectation considering the contributing doc spells its out
s/Alos/Also
We def need something that returns values from choco.
And the current api is much more fire and forget which is not going to work for all cases (most cases?)
It was literally put together quickly as an early early preview
Joel Bennett
@Jaykul
I was always planning on squashing the commits down, so changing the commit messages is no big deal, I wanted to keep them separate because I felt it was easier to follow what was changed and why
Rob Reynolds
@ferventcoder
I agree in keeping them separate when meaningful.
Joel Bennett
@Jaykul
But I still like the idea of having ICommand and IListCommand separately, so I can alter one command at a time to implement the list method
(bearing in mind that IListCommand derives from ICommand, so it's still a command, with just list as extra
Rob Reynolds
@ferventcoder
Yeah and maybe thats best for now. Thats what I meant by starting to understand.
Joel Bennett
@Jaykul
The hardest part is the last outermost layer
Rob Reynolds
@ferventcoder
I got that. For me it was trying to understand what would call ChocoSourceCommand.list
Joel Bennett
@Jaykul
Right
Rob Reynolds
@ferventcoder
The listrunner I guess is making that call?
Joel Bennett
@Jaykul
Right
And that's (only) being called by the Sources() function
Rob Reynolds
@ferventcoder
Turtles all the way down
:)
Joel Bennett
@Jaykul
I think it could also be called by a Packages() function ... at which point, we could probably call the function List<T>()
instead of Sources and Packages
Rob Reynolds
@ferventcoder
Yes
Joel Bennett
@Jaykul
I was looking at that just now to see if that would work
I would rather if there was only one runner
because it's so copy/paste
but perhaps it would be easier to refactor common parts
Rob Reynolds
@ferventcoder
Ya
Joel Bennett
@Jaykul
So instead of GenericRunner and ListRunner, we just have run and list on GenericRunner
if that all makes sense to you
Then I'll start refactoring and slicing and dicing and fix or make a new pull request ;)
I guess I can push --force to totally change the existing pull request, but that's just ... weird
Rob Reynolds
@ferventcoder
Thats normal :)
Joel Bennett
@Jaykul
Heh, ok
Rob Reynolds
@ferventcoder
When your full time job centers around github
Joel Bennett
@Jaykul
Yeah, everything yells at me when I push --force, but it makes sense for pull request branches.
Rob Reynolds
@ferventcoder
And only then :) - keeps the conversation and history right there
Joel Bennett
@Jaykul
yeah
I made you one new one though ;-) chocolatey/choco#140
Joel Bennett
@Jaykul
Right now, the runner throws an exception if it can't find a command and the CommandName is set, but does NOT throw an exception if the CommandName is not set. Is that for a reason?
Rob Reynolds
@ferventcoder
Pass through
Joel Bennett
@Jaykul
Hey, what's the deal with stable and master -- you want this pull request on top of stable or master?