Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 29 2015 13:57
    ferventcoder commented on 4af5e76
  • Jun 29 2015 13:48
    ferventcoder commented on 4af5e76
  • Jun 29 2015 13:34
    ferventcoder commented on f9ecefa
  • Apr 08 2015 05:36

    Jaykul on ListCommand

    (compare)

  • Apr 08 2015 05:36

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (maint) Line wrapping. (compare)

  • Apr 08 2015 05:10
    Jaykul commented on 5742f16
  • Apr 08 2015 05:09
    Jaykul commented on 5742f16
  • Apr 08 2015 05:07

    Jaykul on InstallCommand

    (maint) Line wrapping. (compare)

  • Apr 08 2015 04:36
    ferventcoder commented on 5742f16
  • Apr 08 2015 04:28
    Jaykul commented on 5742f16
  • Apr 08 2015 03:13
    ferventcoder commented on 5742f16
  • Apr 08 2015 03:13
    ferventcoder commented on 5742f16
  • Apr 07 2015 16:15
    ferventcoder commented on 83ef921
  • Apr 07 2015 15:06
    Jaykul commented on 83ef921
  • Apr 07 2015 14:46
    ferventcoder commented on 83ef921
  • Apr 07 2015 14:45
    ferventcoder commented on 83ef921
  • Apr 06 2015 16:32

    Jaykul on master

    Add Install and Uninstall Refac… (compare)

  • Apr 05 2015 06:33

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (compare)

  • Apr 05 2015 06:27

    Jaykul on 0.9.9.3

    (compare)

  • Apr 05 2015 06:27

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (compare)

Joel Bennett
@Jaykul
I made you one new one though ;-) chocolatey/choco#140
Joel Bennett
@Jaykul
Right now, the runner throws an exception if it can't find a command and the CommandName is set, but does NOT throw an exception if the CommandName is not set. Is that for a reason?
Rob Reynolds
@ferventcoder
Pass through
Joel Bennett
@Jaykul
Hey, what's the deal with stable and master -- you want this pull request on top of stable or master?
Gary Ewan Park
@gep13
Joel Bennett
@Jaykul
Yeah, or makes me more confused
The changes from @mwrock didn't go on master
Gary Ewan Park
@gep13
right, the changes that Matt is making is going into the next vNext release, i.e. 0.9.9, so he needed to target stable, as they will go out immediately, once the RC round is completed
as he originally targetted master with his PR
Joel Bennett
@Jaykul
can you merge those to master?
Gary Ewan Park
@gep13
yes, I believe so. That is some git fu that I don't know how to do yet, still very much learning, but i think @ferventcoder has the power to do this
Joel Bennett
@Jaykul
hehe
Well, I'm going to just blame @ferventcoder
He asked me to pick up the change from @mwrock, so I'm working on stable because it's ahead of master :-p
Joel Bennett
@Jaykul
Well, that's 2 out of three CI builds finished and green, I'm going to bed instead of waiting for the last one :sparkles:
Gary Ewan Park
@gep13
coolio! We know where you live if that last one fails :-P
Joel Bennett
@Jaykul
Ugh. The command "nuget restore src/chocolatey.sln" failed and exited with 1 during ....
travis might hate you
or me
I'm not sure which
g'night
Gary Ewan Park
@gep13
ha ha :-) yeah, let's not worry about that one just now
have a good one!
Rob Reynolds
@ferventcoder
@Jaykul travis ci has been hating on nuget restore lately
Joel Bennett
@Jaykul
So, I gotta reverse your question on you -- you asked why I wrote that one function as a yield result -- but why is your NugetService.list_run NOT written as yield result? Your NugetList.GetPackages is taking an IQueryable which returns results as they come over the wire, and then calling .ToList() to force you to wait until you get all the answers....
why are you calling .ToList instead of just outputting the data as it comes over the wire.
Rob Reynolds
@ferventcoder
probably because I wasn’t thinking ;)
actually there may have been a specific reason there
Joel Bennett
@Jaykul
It means I don't get any output until the full list is retrieved
Rob Reynolds
@ferventcoder
I’m not sure that is true
sorry
I’m not sure I see that as true when running choco list commands
Joel Bennett
@Jaykul
?
Of course it's true
NugetCommon.GetRemoteRepository(configuration, nugetLogger).ToList()
Nothing can come back until they have all come back
try: choco list sub
Rob Reynolds
@ferventcoder
yeah, will need to fix
I made that change somewhere along the way
chocolatey/choco@226e998
Joel Bennett
@Jaykul
By the way, I meant to ask yesterday -- are there tests which test the actual output of the commands like source list?
Rob Reynolds
@ferventcoder
Found it
Maybe? The test coverage isn’t where I want it to be.
The integration tests however cover a ton of closer to black box scenarios
Joel Bennett
@Jaykul
yeah, I just wanted to see a couple, because ... well, I added a list to ensure that source_list is called
But obviously I need one with a mock list of sources to ensure the list is returned
Just, you know, to make sure nobody breaks my change in the future ;-)
Rob Reynolds
@ferventcoder
chocolatey/choco#143
Joel Bennett
@Jaykul
heh