Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 29 2015 13:57
    ferventcoder commented on 4af5e76
  • Jun 29 2015 13:48
    ferventcoder commented on 4af5e76
  • Jun 29 2015 13:34
    ferventcoder commented on f9ecefa
  • Apr 08 2015 05:36

    Jaykul on ListCommand

    (compare)

  • Apr 08 2015 05:36

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (maint) Line wrapping. (compare)

  • Apr 08 2015 05:10
    Jaykul commented on 5742f16
  • Apr 08 2015 05:09
    Jaykul commented on 5742f16
  • Apr 08 2015 05:07

    Jaykul on InstallCommand

    (maint) Line wrapping. (compare)

  • Apr 08 2015 04:36
    ferventcoder commented on 5742f16
  • Apr 08 2015 04:28
    Jaykul commented on 5742f16
  • Apr 08 2015 03:13
    ferventcoder commented on 5742f16
  • Apr 08 2015 03:13
    ferventcoder commented on 5742f16
  • Apr 07 2015 16:15
    ferventcoder commented on 83ef921
  • Apr 07 2015 15:06
    Jaykul commented on 83ef921
  • Apr 07 2015 14:46
    ferventcoder commented on 83ef921
  • Apr 07 2015 14:45
    ferventcoder commented on 83ef921
  • Apr 06 2015 16:32

    Jaykul on master

    Add Install and Uninstall Refac… (compare)

  • Apr 05 2015 06:33

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (compare)

  • Apr 05 2015 06:27

    Jaykul on 0.9.9.3

    (compare)

  • Apr 05 2015 06:27

    Jaykul on InstallCommand

    (GH-132) Make InstallCommand a… (compare)

Joel Bennett
@Jaykul
Of course it's true
NugetCommon.GetRemoteRepository(configuration, nugetLogger).ToList()
Nothing can come back until they have all come back
try: choco list sub
Rob Reynolds
@ferventcoder
yeah, will need to fix
I made that change somewhere along the way
chocolatey/choco@226e998
Joel Bennett
@Jaykul
By the way, I meant to ask yesterday -- are there tests which test the actual output of the commands like source list?
Rob Reynolds
@ferventcoder
Found it
Maybe? The test coverage isn’t where I want it to be.
The integration tests however cover a ton of closer to black box scenarios
Joel Bennett
@Jaykul
yeah, I just wanted to see a couple, because ... well, I added a list to ensure that source_list is called
But obviously I need one with a mock list of sources to ensure the list is returned
Just, you know, to make sure nobody breaks my change in the future ;-)
Rob Reynolds
@ferventcoder
chocolatey/choco#143
Joel Bennett
@Jaykul
heh
But ... why!?
Joel Bennett
@Jaykul
The awesome thing is you call ToList on that at least three times :fearful:
There must be some history there
Rob Reynolds
@ferventcoder
It was like DIAF for some reason
Richard Simpson
@RichiCoder1
:+1: on list discussion
Joel Bennett
@Jaykul
chocolatey/choco#146
This noticeably improves the speed of choco list ... commands
Richard Simpson
@RichiCoder1
Nice :)
Joel Bennett
@Jaykul
Anyone know what this actually means? chocolatey/choco#147
Richard Simpson
@RichiCoder1
It doesn't appear to actually filter out apps, but rather included apps installed on the machine, but that aren't connected to a choco package. I could be reading this wrong though:
https://github.com/chocolatey/choco/blob/master/src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs#L93
Gary Ewan Park
@gep13
that is my understanding as well. One of the new features of Chocolatey vNext is the ability to synchronize applications that have been installed by Chocolatey, and applications that appear in Add/Remove Programs as they have been installed manually. the premise being that Chocolatey can "take over" upgrade/update of those applications that were installed manually
Joel Bennett
@Jaykul
Yeah, ok, I see that's what it actually does
Only problem is, if you pass that parameter, the list of "installed programs" isn't filtered AT ALL
so you can do like:
choco list SublimeText3 -lp
and it lists ... everything
that's installed locally
Honestly, this feature is screwy, it doesn't belong on the same command
I mean, it's just confusing
choco list SublimeText3 -p # the p does nothing
Gary Ewan Park
@gep13
I believe I might be right in saying that this particular "feature" isn't complete yet
Joel Bennett
@Jaykul
choco list SublimeText3 -lp # the "SublimeText3" does nothing
yeah, well, so far, it seems to me like these should be separate commands
That's all I'm saying
In code they basically are
except they're not, so the logic path is really twisted and hard to follow.
Rob Reynolds
@ferventcoder
@Jaykul @gep13 it's meant to be used only with list -local only
adding a filter like SublimeText3 can produce "interesting" results
Joel Bennett
@Jaykul
lol
Rob Reynolds
@ferventcoder
basically it should only be used on list local with no filter - some more validation may be necessary there
Joel Bennett
@Jaykul
gotcha
I've just been looking at it because I need nuget results, but I don't need your registry feature
And I want to make sure that I don't get it accidentally ;-)
but because the registry lookup is done inside the list method ...