Hey all, I am helping out to get react-hotkeys up-to-speed. I'll be focusing on getting the backlog of pull requests and issues resolved before refactoring the project to work with later versions of React and then making good on some of the promises for V1.
Please let me know if you have any input. A lot of stuff I'll be dealing with in these issues and PRs I have on passing familiarity with.
Hey, Jamhseed. This is probably going to be a somewhat asynchronous conversation. From what I understand, the people who have expressed interest in helping out are distributed across quite a few time zones. So I ask for your patience.
I am toying around at the moment with the Projects feature on github to try and capture and allocate the work that needs doing on the repository.
enterhandler. Any idea why that happens? I expected react-hotkeys to not propagate the event to the form (which is outside of my select component and outside of my HotKeys component).
Hi, I'm trying to use enzyme test in my app for checking if the shortcuts work in the app, but I couldn't find any way, how to test it with react-hotkeys. The react-hotkeys in app work properly but the tests couldn't check that.
I made test branch (JarekParal/kentico-onboarding-js@68b788c) where I'm testing the enzyme test without react-hotkeys and everything work (enzyme tests + shortcuts in app).
But when I have react-hotkeys in the app (JarekParal/kentico-onboarding-js@f97464b), the enzyme's simulate events are not catch by react-hotkeys. I tried to send all types of events: keypress, keydown, keyup + key, keyCode, which and nothing work.
Could you help me please?
const keyMap = getApplicationKeyMap();that component renders before the keys are bound. Even if the
GlobalHotKeysis defined higher in the tree.
getApplicationKeyMap()is still quite new, and it's very helpful to hear about different ways it's being used that I have previously tested. If you have the time, do you think you could file an issue that explains the problem you were having? It helps me better keep track of the work to be done on the project and to discuss possible solutions. Your suggestion of a context provider sounds like a good one.