Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Christoph Burgdorf
    @cburgdorf
    That's indeed interesting. Thanks for sharing
    Kevin K.
    @kbknapp
    :+1:
    vyp
    @vyp
    also just realised the new changelog for clog for 0.4.0 has 'v' in front of it while the others don't
    obviously this is tiny, but you know, when people first come to see this is about changelog generation, they'll probably check the changelog.md of the repo for a bit of a demo
    Kevin K.
    @kbknapp
    There's a bit of a complex issue behind that. I've got an idea on how to handle it, I've just gotta submit it. In the mean time we can just strip the v from the most recent version to match all the rest, and future uses won't include it.
    I'll see if I can put it together today
    Kevin K.
    @kbknapp
    Ok, I was on mobile earlier so I couldn't fully explain. The issue is most semver examples show the v such as v1.2.3 but you can't parse that string to semver structs, you have to strip the v first. Because the logic that strips the v (if it exists) and the logic that writes the new version to the changelog.md are in totally different places they have no knowledge of each other. i.e. the part doing the writing doesn't know if a v existed prior or not. So right now it just places a v no matter what just to be in line with semver examples. What I plan on doing is adding an Option<bool> to the ClogConfig struct which will indicate if a v was present or not, and make a conditional write based on that.
    Kevin K.
    @kbknapp
    Alright, just put in a PR for this
    The PR includes manually stripping the 'v' from the most recent changelog.md just to be consistent so we don't have to re-run it
    vyp
    @vyp
    Ahh just saw this.
    I was just more thinking about manually editing the v away, or adding a v to other ones, for consistency
    But nice work nonetheless
    Yeah you're right, that's probably the way to go
    vyp
    @vyp
    kbknapp: i made the clog aur package makedepend on the official rust package (now that it's on beta4-1)
    is that cool?
    Kevin K.
    @kbknapp
    Yeah of course! I always prefer official packages to aur ones.
    R. Kyle Murphy
    @orclev
    I opened a new issue to add a feature but I've already implemented it in my fork. I'm waiting to issue the PR until I get some feedback on whether you'd like to see any changes made to my implementation. The details of what the feature is, and my implementation are available in #38
    Kevin K.
    @kbknapp
    I'll take a look today once a get a few mins, thanks!
    R. Kyle Murphy
    @orclev
    np, mostly implementing this stuff because it's handy for me. We're using stash currently and I'm trying to move us to using clog, so the ability to generate commit links would be really nice.
    R. Kyle Murphy
    @orclev
    looks like it's failing on the stable channel because of the feature I had to enable. Not sure exactly how to fix that.
    R. Kyle Murphy
    @orclev
    sorry, bit of a Rust newb, experienced Haskeller so I've got the basic idea how to do most things but some of the gotchas (in particular this stable/unstable thing) kind of throw me for a loop
    Kevin K.
    @kbknapp
    No worries ;)
    Christoph Burgdorf
    @cburgdorf
    @kbknapp I just noticed that when there's from-latest-tag=true activated through the config we can't just disable it via CLI by passing from-latest-tag=false
    Kevin K.
    @kbknapp
    If you pass a --from abcd1234 it will override the config. I think it's because the --from-latest-tag doesn't take a true/false, its only a flag. So the only way to disable it if it's already in the config is to pass in a --from
    Christoph Burgdorf
    @cburgdorf
    yep, but you can't easily get to the default which boils down to ...HEAD (omitting the from entirely).
    you can't pass --from=""
    Kevin K.
    @kbknapp
    Try --from " " I'm curious if that would in a hacky sort of way
    Kevin K.
    @kbknapp
    We could add --all or change --from-latest-tag to accept true false values, but I'm not sure it's be super useful (assuming the blank space works) unless you're doing something like your project of running clog on in someone else's repo (ie not one you can easily remove fields in the config from)
    Or just easily get first commit hash
    Kevin K.
    @kbknapp
    I just tested clog --from "" and it seems to work
    Interesting...but clog --from="" doesn't work as it says it's not a value. This is a bug in clap, I'll start investigating.
    Kevin K.
    @kbknapp
    clap is fixed. I'm putting the a dep-update PR now which allows clog to use any of the following:
    $ clog --from=
    $ clog --from ""
    $ clog --from=""
    any of these effectively do ...HEAD
    Christoph Burgdorf
    @cburgdorf
    Awesome! Thanks for patching
    Kevin K.
    @kbknapp
    No problem
    Pascal Precht
    @PascalPrecht
    @kbknapp what was the url again to download binaries of clog? :)
    Pascal Precht
    @PascalPrecht
    @kbknapp @cburgdorf I've created some meaningful labels for the clog repository. When creating issues or receiving PRs, simply assign one from each section. https://github.com/thoughtram/clog/labels
    Kevin K.
    @kbknapp
    Pascal Precht
    @PascalPrecht
    Thank you!
    Kevin K.
    @kbknapp
    Awesome! Will do :)
    No problem. I haven't re-built the latest yet since there hasn't been a new release yet, 0.8.2 is the most recent build.
    Pascal Precht
    @PascalPrecht
    @kbknapp you aware of this? thoughtram/clog#54
    Kevin K.
    @kbknapp
    Just saw it. That was by design, but it can be changed pretty easily.
    Pascal Precht
    @PascalPrecht
    oh okay
    Kevin K.
    @kbknapp
    Since if never used the original angular one I'm not sure if that was a legacy feature from them or not?
    Pascal Precht
    @PascalPrecht
    I'd vote for always generating a list.
    Brian Pearce
    @brianp
    If I don’t have a footer, or break the 100 line character max, is that considered a mal-formed commit that will get skipped?
    Just trying to run clog for the first time and it gets no results
    Brian Pearce
    @brianp
    ahhh found it
    I’ve been doing feat(subject) Msginstead of feat(subject): Msg