slackbot2<keviny> The problem is this: aggregator produce business error. Dataflow check to see if there is any sink configured. It doesn’t see sink configured, so it didnt check the business error.
slackbot2<keviny> So my change is to make it check the business error wether there is a sink or not
slackbot2<hsiliev> I see
slackbot2<hsiliev> Getting back to "2 different endpoints" ... I don't see that in the code. Now we have only one afaict
slackbot2<keviny> I notice the reason we don’t see this in our side is because we have sink
slackbot2<hsiliev> Yep. We want to have one too. That's why I'm asking so many questions :slightly_smiling_face:
slackbot2<keviny> ok, the current design is this [org aggregation, consumer aggregation, duplicate doc]. When posting to the sink it will post the org aggregation to /v1/metering/aggregated/usage and consumer to /v1/metering/aggregated/usage.
slackbot2<keviny> I think the Dataflow was designed so that it can post the the docs produced to different app, hence it becomes like that
slackbot2<keviny> In this case we don’t want to post to different endpoint
slackbot2<keviny> so they become the same
slackbot2<keviny> I think we have a dataflow app that will post the docs to different endpoint
slackbot2<hsiliev> Endpoints might be different but the host is not really an array, is it?
slackbot2<keviny> Yeah the host is just one
slackbot2<hsiliev> We are using the partitioning?
slackbot2<keviny> it would forward it to the partition based on that
slackbot2<hsiliev> Thanks. I want to dig deeper, so I'll add some tests on top of your PR. Would be a good excercise
slackbot2<hsiliev> Good day/night :slightly_smiling_face:
slackbot2<keviny> I’ll add a test on the case where no sink is configured when i get the chance. Have some urgent stuff to do :(
slackbot2<keviny> Good night and thanks
slackbot2<keviny> @hsiliev I added the test for my PR yesterday :slightly_smiling_face:
slackbot2<hsiliev> At least I know what this part of the tests do
slackbot2<keviny> 401 is authorization issue though
slackbot2<keviny> We don't mark doc as error. it is stored in the error db
slackbot2<keviny> yeah, if we don't configure the replay, we actually is not calling the replay
slackbot2<keviny> so if we don't pass time or env.REPLAY it is not going to attempt to replay
slackbot2<keviny> It is basically to take care of stuff that might not processed succesfully when cf restart the app
slackbot2<hsiliev> I see. Thanks
slackbot2<rajkiranrbala> Have a meeting here
slackbot2<rajkiranrbala> I forgot to thank you @hsiliev
slackbot2<rajkiranrbala> I havent explored the Codacy fully yet
slackbot2<rajkiranrbala> But it looks really cool
slackbot2<hsiliev> Our status: Broker: working on a new integration tests module to allow interaction with cf and uaa clients added create & update of plans and mappings still having issues with abacus module dependencies Abacus: reported a bug for error detection. Thanks to @keviny for fixing it business errors not handled by
cf-bridgeon “missing” linux-container plan due to network issues. Proposed a fix in PR fine-