Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Yuki Ito
    @110y
    @lgruen Thank you for preparing! I have send a request for transfer the repository. I could not transfer the repository from mercari organization directly, so I used my own account temporary ( mercari -> 110y -> lgruen ).
    Leonhard Gruenschloss
    @lgruen
    Thanks very much! Wow, one more indirection :).
    Leonhard Gruenschloss
    @lgruen

    Transferred now! :)
    https://github.com/cloudspannerecosystem/wrench

    Added you as an admin. Please let me know if anything looks amiss.

    I'll also send you a PR for CircleCI integration.
    If you could prepare a PR for the website (https://github.com/cloudspannerecosystem/cloudspannerecosystem.github.io/blob/master/index.md), that would be awesome.
    Yuki Ito
    @110y
    @lgruen Thanks! I sent a PR, please review it when you have time: cloudspannerecosystem/cloudspannerecosystem.github.io#7
    Yuki Ito
    @110y
    And next, we would like to initiate transfer mercari/yo : https://github.com/mercari/yo as well. Could you initiate the first step (clone as staging repository)?
    Leonhard Gruenschloss
    @lgruen
    Thanks a lot! Added some minor comments to the PR.
    Also sent you two PRs for wrench: https://github.com/cloudspannerecosystem/wrench/pulls
    Yes, yo sounds like a great next step. I'll try to have a look tomorrow.
    Leonhard Gruenschloss
    @lgruen
    @110y, do we need to retain the LICENSE.xo file?
    Yuki Ito
    @110y
    @lgruen Do we have any concerns about retaining LICENCSE.xo?
    Leonhard Gruenschloss
    @lgruen
    I was just wondering why there are two LICENSE files.
    Masahiro Sano
    @kazegusuri
    yo is a fork of xo. Though it fully re-write the code. At that time we kept xo license file as is and put a new license file. Both are the same license as MIT.
    It is better both copyrights are in a same license file
    Leonhard Gruenschloss
    @lgruen
    Okay, so just keep one LICENSE then (as MIT)?
    Masahiro Sano
    @kazegusuri
    yes. If we keep only one LICENSE file. Could you add xo's copyright to it?
    Leonhard Gruenschloss
    @lgruen
    Thanks, @110y and @kazegusuri! I've drafted a change at https://github.com/lgruen/mercari-yo-staging/compare/cla. Does that look good to you?
    I haven't looked at the CircleCI configuration in detail yet, but I don't think we'd need to change much.
    Yuki Ito
    @110y
    @lgruen Thanks, it looks good! Next step is Google internal approval?
    Leonhard Gruenschloss
    @lgruen
    @110y Thanks for the quick review! Yes, I'll start the internal approval process. I'll also be traveling for the next two weeks, but I'll try to make progress on this anyway.
    Yuki Ito
    @110y
    Have a safe travel!
    Leonhard Gruenschloss
    @lgruen
    Thank you very much! Unfortunately had to cancel the trip just now due to COVID-19.
    Leonhard Gruenschloss
    @lgruen
    @110y Are you okay with lgruen/mercari-yo-staging@fc30e61
    ?
    Yuki Ito
    @110y
    @lgruen Yes!
    Leonhard Gruenschloss
    @lgruen
    @110y Great, thanks!
    Yuki Ito
    @110y
    @lgruen I will initiate to transfer the repository soon!
    Yuki Ito
    @110y
    @lgruen I've initiated transfer the repository to your account!
    Leonhard Gruenschloss
    @lgruen
    @110y Thanks very much! I haven't accepted yet because I'm still missing the final approval in the internal chain. Hopefully shouldn't take much longer.
    Yuki Ito
    @110y
    :thumbsup:
    Leonhard Gruenschloss
    @lgruen
    @110y Will keep you posted! Related to wrench, did you see cloudspannerecosystem/wrench#21
    ?
    Yuki Ito
    @110y
    @lgruen Thank you for notifying. I've just merged now!
    Leonhard Gruenschloss
    @lgruen
    @110y Finally got all the approvals! Can we try the repo transfer again, please?
    Yuki Ito
    @110y
    image.png
    @lgruen Yes! I've already requested the transfer from 110y/yo to lgruen/yo. Could you reconfirm it?
    Leonhard Gruenschloss
    @lgruen
    @110y The previous request (from March 4) unfortunately has already expired ("Oops! That repository transfer has expired.")
    Yuki Ito
    @110y
    @lgruen Got it, I've just re-sent the invitation now!
    Leonhard Gruenschloss
    @lgruen
    @110y Awesome, thank you very much! I've added you as an admin. Can you please take a look to make sure everything looks alright? https://github.com/cloudspannerecosystem/yo
    I'll take a look at the CircleCI integration tomorrow if that's okay. Is there anything I should look out for? Is all that's needed this set of environment variables? (https://github.com/cloudspannerecosystem/yo/blob/master/.circleci/config.yml#L48)
    If you could send another description snippet for the website, that would be great!
    Yuki Ito
    @110y
    @lgruen Thanks a lot! Everything looks good!
    Is all that's needed this set of environment variables?
    Yes, will work fine.
    If you could send another description snippet for the website, that would be great!
    I will send PR soon!
    Leonhard Gruenschloss
    @lgruen
    @110y Thanks! I've configured the CircleCI environment variables, but it looks like yo expects an existing database? (https://circleci.com/gh/cloudspannerecosystem/yo/91)
    Masahiro Sano
    @kazegusuri
    yeah. Now we haven't automated the database creation. We use an existing database in a CI.
    Leonhard Gruenschloss
    @lgruen
    @kazegusuri Thanks! Could you send me instructions on how to generate that database in our Cloud Spanner instance, please?
    Yuki Ito
    @110y
    @lgruen I've send the PR which adds description about yo to ecosystem website. Please take a look when you have time! cloudspannerecosystem/cloudspannerecosystem.github.io#8
    And next, we would like to transfer spool: https://github.com/gcpug/spool which is a database pooling tool for CI. Could you please initiate the transfer process for it?