Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Masahiro Sano
    @kazegusuri
    yes. If we keep only one LICENSE file. Could you add xo's copyright to it?
    Leonhard Gruenschloss
    @lgruen
    Thanks, @110y and @kazegusuri! I've drafted a change at https://github.com/lgruen/mercari-yo-staging/compare/cla. Does that look good to you?
    I haven't looked at the CircleCI configuration in detail yet, but I don't think we'd need to change much.
    Yuki Ito
    @110y
    @lgruen Thanks, it looks good! Next step is Google internal approval?
    Leonhard Gruenschloss
    @lgruen
    @110y Thanks for the quick review! Yes, I'll start the internal approval process. I'll also be traveling for the next two weeks, but I'll try to make progress on this anyway.
    Yuki Ito
    @110y
    Have a safe travel!
    Leonhard Gruenschloss
    @lgruen
    Thank you very much! Unfortunately had to cancel the trip just now due to COVID-19.
    Leonhard Gruenschloss
    @lgruen
    @110y Are you okay with lgruen/mercari-yo-staging@fc30e61
    ?
    Yuki Ito
    @110y
    @lgruen Yes!
    Leonhard Gruenschloss
    @lgruen
    @110y Great, thanks!
    Yuki Ito
    @110y
    @lgruen I will initiate to transfer the repository soon!
    Yuki Ito
    @110y
    @lgruen I've initiated transfer the repository to your account!
    Leonhard Gruenschloss
    @lgruen
    @110y Thanks very much! I haven't accepted yet because I'm still missing the final approval in the internal chain. Hopefully shouldn't take much longer.
    Yuki Ito
    @110y
    :thumbsup:
    Leonhard Gruenschloss
    @lgruen
    @110y Will keep you posted! Related to wrench, did you see cloudspannerecosystem/wrench#21
    ?
    Yuki Ito
    @110y
    @lgruen Thank you for notifying. I've just merged now!
    Leonhard Gruenschloss
    @lgruen
    @110y Finally got all the approvals! Can we try the repo transfer again, please?
    Yuki Ito
    @110y
    image.png
    @lgruen Yes! I've already requested the transfer from 110y/yo to lgruen/yo. Could you reconfirm it?
    Leonhard Gruenschloss
    @lgruen
    @110y The previous request (from March 4) unfortunately has already expired ("Oops! That repository transfer has expired.")
    Yuki Ito
    @110y
    @lgruen Got it, I've just re-sent the invitation now!
    Leonhard Gruenschloss
    @lgruen
    @110y Awesome, thank you very much! I've added you as an admin. Can you please take a look to make sure everything looks alright? https://github.com/cloudspannerecosystem/yo
    I'll take a look at the CircleCI integration tomorrow if that's okay. Is there anything I should look out for? Is all that's needed this set of environment variables? (https://github.com/cloudspannerecosystem/yo/blob/master/.circleci/config.yml#L48)
    If you could send another description snippet for the website, that would be great!
    Yuki Ito
    @110y
    @lgruen Thanks a lot! Everything looks good!
    Is all that's needed this set of environment variables?
    Yes, will work fine.
    If you could send another description snippet for the website, that would be great!
    I will send PR soon!
    Leonhard Gruenschloss
    @lgruen
    @110y Thanks! I've configured the CircleCI environment variables, but it looks like yo expects an existing database? (https://circleci.com/gh/cloudspannerecosystem/yo/91)
    Masahiro Sano
    @kazegusuri
    yeah. Now we haven't automated the database creation. We use an existing database in a CI.
    Leonhard Gruenschloss
    @lgruen
    @kazegusuri Thanks! Could you send me instructions on how to generate that database in our Cloud Spanner instance, please?
    Yuki Ito
    @110y
    @lgruen I've send the PR which adds description about yo to ecosystem website. Please take a look when you have time! cloudspannerecosystem/cloudspannerecosystem.github.io#8
    And next, we would like to transfer spool: https://github.com/gcpug/spool which is a database pooling tool for CI. Could you please initiate the transfer process for it?
    Leonhard Gruenschloss
    @lgruen
    @110y Thanks very much! Added a minor comment. I'll take a look at spool tomorrow!
    Yuki Ito
    @110y
    @lgruen Thanks! Fixed it.
    Leonhard Gruenschloss
    @lgruen
    @110y Thanks very much! Merged.
    Vyacheslav Kim (Kane)
    @kanekv
    Hello everyone. What is a good place to ask generic spanner questions? Is there a spanner community?
    Leonhard Gruenschloss
    @lgruen
    @kanekv There are a few options, e.g. Stack Overflow -- see https://cloud.google.com/spanner/docs/getting-support
    Mayur Kale
    @mayurkale22
    Hi, could someone review and merge this? cloudspannerecosystem/website#5. It is very simple.
    Leonhard Gruenschloss
    @lgruen
    @mayurkale22 No problem, done!
    Mayur Kale
    @mayurkale22
    @lgruen thank you :)
    flowerinthenight
    @flowerinthenight
    Hi, I have a repo https://github.com/flowerinthenight/spindle. It's a public version of what we use in production at the moment. I wonder if this repo can join the ecosystem?
    skuruppu
    @skuruppu
    Thanks @flowerinthenight for reaching out. Just wanted to let you know that we won't be able to check it out till early Jan as most of the team is away for the end of year holidays. Hope that's ok.
    flowerinthenight
    @flowerinthenight
    No worries. Thanks.
    Vyacheslav Kim (Kane)
    @kanekv
    Hello, is it a good place to talk about generic spanner stuff?
    skuruppu
    @skuruppu
    @kanekv you certainly can discuss general spanner topics here. To get a broader audience, especially if you have questions, you may still want to consider having a discussion in place like StackOverflow.
    skuruppu
    @skuruppu
    @flowerinthenight, really sorry for the delay. The repo you linked to is very interesting. Just wanted to ask you a couple of questions to help us decide.
    1. Would you be able to give some background on why you're using this approach in your production app? Better still, if you could document some use cases in the README, that would be great.
    2. Why did you choose Spanner for this over other databases?
    flowerinthenight
    @flowerinthenight

    @skuruppu No problem at all.

    1. Most of our teams employ some sort of distributed processing in our services, and distributed locking is quite a common technique in this area. We use some of the more well known ones such as Zookeeper and Consul. These systems are quite difficult to maintain by themselves though, so any option that are easier when it comes to maintenance are welcome to us. Redis is also common in our backends and I even have a Redis-based distributed locker lib https://github.com/flowerinthenight/kettle that we use as well. But the Redis version is not really that reliable as described here. This would lead me to:

    2. We use Spanner heavily as one of our main databases, among others. So if I could do distributed locking using Spanner itself, I don't have to maintain another Zookeeper just for locking. I think TrueTime is crucial here and may even be more reliable than the Redis version, time will tell. So far, our Zookeepers are the most reliable but I think that this library can be as reliable as well, which it is, so far.

    skuruppu
    @skuruppu
    Thanks heaps for the details @flowerinthenight. I will take a closer look at the repo next week and also figure out the steps needed to do an import. Hope it's ok if I get back to you late next week.