These are chat archives for cltk/cltk

15th
Aug 2016
Kyle P. Johnson
@kylepjohnson
Aug 15 2016 00:39
Anaconda already has the C dependencies we need -- and they work well (I use numpy, gensim, and pandas at work).
What I want to know is how I will upload updated code to the conda repo
@souravsingh you've got some outstanding tickets, so @manu-chroma might be better for this particular task
Nimit Bhardwaj
@nimitbhardwaj
Aug 15 2016 03:33
Hey Kyle, I made the complete repo cltk/punjabi_text_gurban, what I do now, oyou suggested earlier for punctuation and tokenization, what I do
Kyle P. Johnson
@kylepjohnson
Aug 15 2016 06:09
@nimitbhardwaj First add docs for Punjabi stopwords (I just made you a ticket: cltk/cltk#357
Nimit Bhardwaj
@nimitbhardwaj
Aug 15 2016 06:10
OK thanks this will be done
Kyle P. Johnson
@kylepjohnson
Aug 15 2016 06:11
Once this is done, I'll DM you some new ideas. If we can find some modern treebanks, it might be fun to try on classical texts.
Nimit Bhardwaj
@nimitbhardwaj
Aug 15 2016 06:11
OK
Sourav Singh
@souravsingh
Aug 15 2016 09:17
We can make use of Travis CI to automate the build process for conda packaging.
About accepting pull requests from master branch, It does not create a problem for the maintainer of a project
Sourav Singh
@souravsingh
Aug 15 2016 09:24
It creates a problem for the contributor when the contributor wants to pull the changes to the code back to his fork and there is a divergence in code between the upstream master and local master branch.
Sourav Singh
@souravsingh
Aug 15 2016 10:55
which you can see when Ratul created #358
Manvendra Singh
@manu-chroma
Aug 15 2016 12:44
A contributor should technically not work in the master branch of his fork.
@souravsingh are you talking about the problem with merge ?
Sourav Singh
@souravsingh
Aug 15 2016 13:24
@manu-chroma Exactly!
Kyle P. Johnson
@kylepjohnson
Aug 15 2016 14:25
I see, yes you're bother right that it is better for a contributors to do work in a "feature branch", then merge the changes into master, then submit the PR. Do I have it right?
Sourav Singh
@souravsingh
Aug 15 2016 16:30
For contributors, It is better to do code change in a branch, send a PR. The maintainer can later merge the code changes in the branch, if the CI tests look good.