These are chat archives for coala/coala-bears

24th
Jul 2016
Karan Sharma
@mr-karan
Jul 24 2016 05:52 UTC
left you some comments @Redridge
Lasse Schuirmann
@sils
Jul 24 2016 06:10 UTC
good morning
Karan Sharma
@mr-karan
Jul 24 2016 06:10 UTC
morning
Lasse Schuirmann
@sils
Jul 24 2016 06:18 UTC
@mr-karan I have a few small proposals to the write good thing, reviewing now :)
Karan Sharma
@mr-karan
Jul 24 2016 06:18 UTC
awesome :)
Lasse Schuirmann
@sils
Jul 24 2016 06:21 UTC
there you go!
Karan Sharma
@mr-karan
Jul 24 2016 06:22 UTC
yep, seeing :)
Karan Sharma
@mr-karan
Jul 24 2016 06:52 UTC
left a note, just in case for your reference. Also, it's a TIL moment for me :)
Lasse Schuirmann
@sils
Jul 24 2016 06:52 UTC
TIL?
Karan Sharma
@mr-karan
Jul 24 2016 06:52 UTC
Today I Learned
Lasse Schuirmann
@sils
Jul 24 2016 06:53 UTC
cool :)
you gotta replace l()[key] by l[key]
because l already contains the locals dict
Karan Sharma
@mr-karan
Jul 24 2016 06:53 UTC
ah yeah that was a typo, my bad.
Lasse Schuirmann
@sils
Jul 24 2016 06:53 UTC
plus your solution is faster than getting locals() in the dict comprehension anyway
hey we don't have full coverage on coala bears!??
can someone check that out? I'm leaving, will be back somewhen within an hour.
Karan Sharma
@mr-karan
Jul 24 2016 06:55 UTC
I'll check that.
Lasse Schuirmann
@sils
Jul 24 2016 06:55 UTC
we should fix the coverage and apply the codecov yml fix thing to coala-bears as well so it doesn't happen again
Karan Sharma
@mr-karan
Jul 24 2016 07:08 UTC
done with the changes coala-analyzer/coala-bears#581
Karan Sharma
@mr-karan
Jul 24 2016 07:15 UTC
here's the fix for codecov.yml @sils1297 coala-analyzer/coala-bears#619
Lasse Schuirmann
@sils
Jul 24 2016 07:37 UTC
@mr-karan yeah but now it fails :P we gotta fix the coverage first
Karan Sharma
@mr-karan
Jul 24 2016 07:52 UTC
Ah, btw for write-good bear the updated asciinema is https://asciinema.org/a/80761
@Asnelchristian It's a simple fix I guess, you just need to check for both Python versions in the test.
        if not sys.version_info >= (3, 4):
            return 'Yapf only supports Python 2.7 and Python 3.4+'
basically this is the problematic part
Lasse Schuirmann
@sils
Jul 24 2016 08:04 UTC
just ignore 2.7 as coala doesn't support it
@abhsag24 how's the indentation algorithm? Do we have something usable? I'm at GUADEC from august 10 and it would be really nice to have something awesome that could do indentation more or less well for vala.
that would also act well as some field testing
Lasse Schuirmann
@sils
Jul 24 2016 08:10 UTC
Damn @Udayan12167 I love this design! I feel like the cEP payed off totally!
Christian Asnel Ngoulla Sob
@AsnelChristian
Jul 24 2016 11:29 UTC
what is #pragma: no cover for ?
Adhityaa Chandrasekar
@adtac
Jul 24 2016 11:33 UTC
@Asnelchristian to not evaluate coverage for that block
(actually to maintain a 100% coverage) :P
Christian Asnel Ngoulla Sob
@AsnelChristian
Jul 24 2016 11:33 UTC
okay :) thanks i am going to use then
Tushar Gautam
@tushar-rishav
Jul 24 2016 11:37 UTC
@Asnelchristian That's like your wild card :stuck_out_tongue:
Christian Asnel Ngoulla Sob
@AsnelChristian
Jul 24 2016 11:38 UTC
@tushar-rishav :+1:
coala-analyzer/coala-bears#622 is a quick one
(i am just using the wild card @tushar-rishav )
:)
We could just let --show-bears take optional comma-separated input
If there isn't any value, just print everything
Lasse Schuirmann
@sils
Jul 24 2016 11:42 UTC
yep doing that
Christian Asnel Ngoulla Sob
@AsnelChristian
Jul 24 2016 11:49 UTC
@hypothesist i guess we also need to do the same with --show-capabilities
?
Lasse Schuirmann
@sils
Jul 24 2016 11:54 UTC
yeah I'm doing that!
Adhityaa Chandrasekar
@adtac
Jul 24 2016 12:04 UTC
he's doing that!
Lasse Schuirmann
@sils
Jul 24 2016 12:04 UTC
who's ding that? Me?
Christian Asnel Ngoulla Sob
@AsnelChristian
Jul 24 2016 12:04 UTC
?!
Tushar Gautam
@tushar-rishav
Jul 24 2016 12:11 UTC
@Asnelchristian :smile: :+1:
Abhay Raizada
@abhsag24
Jul 24 2016 12:43 UTC
@sils1297 The PR fixes a lot of issues, in fact makes it a lot usable it still messes up formatted docstrings though, so we have to be careful and ignore the IndentationBear over those areas
I'm not sure about Vala I'll have to check its syntax
Lasse Schuirmann
@sils
Jul 24 2016 12:58 UTC
cool
@Redridge wanna review? :) coala-analyzer/coala#2554
Lasse Schuirmann
@sils
Jul 24 2016 13:27 UTC
@tushar-rishav can you review the last commit at coala-analyzer/coala#2554 real quick?