These are chat archives for coala/coala-bears

6th
Aug 2016
caichinger
@caichinger
Aug 06 2016 16:43
hi all,
I would like to proceed with this coala-analyzer/coala-bears#605 I am currently working on in https://github.com/caichinger/coala-bears/tree/605_ipynb_pep8bear.
Wow, you are pretty fast :D
Should I create a PR or what is "the next step"?
There are a few things that need to be dicsussed I think.
Adhityaa
@adtac
Aug 06 2016 16:43
Hello :)
Christian Asnel Ngoulla Sob
@AsnelChristian
Aug 06 2016 16:44
Hi @caichinger
:)
caichinger
@caichinger
Aug 06 2016 16:46
pls see above, I accidentially sent the message prematurely and edited it...
and hi @Asnelchristian :)
also, i am not sure whether i should write here or in the issue.
Adhityaa
@adtac
Aug 06 2016 16:49
Here's perfectly fine
And yes, I'd say the PR is the next step
That is if you think it's ready. If not, you can still make the PR and mark it as WIP
We can start reviewing it if you feel so :)
caichinger
@caichinger
Aug 06 2016 16:51
okay, PR with WIP sound good! I will go for that and point out my questions there.
"We can start reviewing it if you feel so" hard to say but if i feel so but some feedback would be good :D
Lasse Schuirmann
@sils
Aug 06 2016 17:07
@caichinger start the PR title with WIP: exactly so our bot will know it's WIP
caichinger
@caichinger
Aug 06 2016 17:22
@sils1297 i will do so, just found a bug, therefore it takes longer ^^
caichinger
@caichinger
Aug 06 2016 17:31
created PR. the bot is a pretty cool thing btw! ;)
caichinger
@caichinger
Aug 06 2016 18:12
i have problems understanding the reported failures, more precisely, i am not sure whether/how they are related to my PR. can maybe someone take a look?
i will be afk for a while.
And GitCommitBear found issues that were non-comformant
For instance, refactored PEP8JupyterNotebookBearTest to work directly with supplied... is too big for a commit head
Although I thought Gitmate doesn't bother with WIP: PRs? @sils1297
Christian Asnel Ngoulla Sob
@AsnelChristian
Aug 06 2016 18:15
@hypothesist you are so fast :) .... woaw! I had just enough time to open the PR :)
Adhityaa
@adtac
Aug 06 2016 18:16
haha :D I have some time on my hands right now :P
Christian Asnel Ngoulla Sob
@AsnelChristian
Aug 06 2016 18:18
:+1:
caichinger
@caichinger
Aug 06 2016 18:48
@hypothesist , thanks for pointing that out; i read but somehow forgot about it, sorry!
i do a rebase to change the messages?
Adhityaa
@adtac
Aug 06 2016 18:53
@caichinger yep
(mark the commits you want to change as edit and git commit --amend)
caichinger
@caichinger
Aug 06 2016 18:55
what do you mean by mark as edit?
Adhityaa
@adtac
Aug 06 2016 18:56
when you do git rebase --interactive HEAD~5 (5 there means you want to edit up to 5 commits behind HEAD) it'll open up an editor with the commits you want to pick/edit/...
if you change one of the commit
commit's pick to edit it'll stop at that commit and allow you to change it
caichinger
@caichinger
Aug 06 2016 18:56
ah, okay, i thought you meant something in the message itself
just to be sure, through ammend i will finaly end up with one single commit, right?
Adhityaa
@adtac
Aug 06 2016 18:58
yep
caichinger
@caichinger
Aug 06 2016 18:59
okay, i will first try this out somewhere else...
thx for your help! :)
Adhityaa
@adtac
Aug 06 2016 19:00
@caichinger I made a tutorial recently about rebase: https://asciinema.org/a/78683
The first few minutes are basic, you can speed through them
Just wanted to point that out :)
caichinger
@caichinger
Aug 06 2016 19:02
@hypothesist nice, thank you!
and next time i wont forget about ammeding in the first way hehe
Adhityaa
@adtac
Aug 06 2016 19:03
Glad to help :)
Lasse Schuirmann
@sils
Aug 06 2016 19:20
@hypothesist the only difference GitMate does for WIP PRs is that it applies the process/wip label instead of pending review
Adhityaa
@adtac
Aug 06 2016 19:21
@sils1297 Is there anyway to pause gitmate for some PRs?
Lasse Schuirmann
@sils
Aug 06 2016 19:21
@hypothesist no