These are chat archives for coala/coala-bears

7th
Aug 2016
caichinger
@caichinger
Aug 07 2016 18:20

Hi there :)
I have two questions:

  1. Could one of you please take a look at the AppVeyor build in
    coala-analyzer/coala-bears#655
    There is a problem as
    https://ci.appveyor.com/project/coala/coala-bears/build/1.0.2306/job/9umn2526i63jny12
    shows but I do not know what it means with respect to my PR.
    What does it mean and what do I have to do?

  2. How do I correctly merge upstream changes into my branch while still doing ammend-only
    commits?
    Should I do git merge --squash and then git commit ammend? But then all your commits
    end up in my single commit. I guess for the PR, i.e. the diff it does not matter but it
    confuses me...

Thanks again for your patience!

Lasse Schuirmann
@sils
Aug 07 2016 18:20
  1. @Makman2 ^ you're our windows guy :)
  2. We do a rebase.
caichinger
@caichinger
Aug 07 2016 18:22
@sils1297 so fast! :D
ad 2.: so I do as I said and thats fine?
Lasse Schuirmann
@sils
Aug 07 2016 18:23
yes :)
caichinger
@caichinger
Aug 07 2016 18:23
ok, thx!
sils @sils1297 is surprised that people are beginning to use this channel appropriately :)
Lasse Schuirmann
@sils
Aug 07 2016 18:30
@caichinger ping us if you need help :)
at least github shows you have conflicts, some people have some git problems when they're new even if they are already experienced devs
caichinger
@caichinger
Aug 07 2016 18:36
it is kind of a struggle ;)
thanks, I will let you know whether I understand the build problem or not. I am waiting for the new build.
since you are frequently updating master I will most likely always have conflicts - I will try to keep the fork in sync. :)
an interesting(instructive struggle of course! :D
Lasse Schuirmann
@sils
Aug 07 2016 18:41
what's the conflict anyway, aren't you making a new file?
conflicts are rare
ouuuh @caichinger it looks like your PR reverts quite some stuff
you only want to add your file, right?
caichinger
@caichinger
Aug 07 2016 18:43
yes, two files and one line in the requirements file.
mhm... that was for sure not my intention ^^
I fear I got lost while merging upstream changes
I will try to fix the problem, I have to go offline now, the mosquitos are coming hehe
Mischa Krüger
@Makman2
Aug 07 2016 18:49
@caichinger the ci issue on appveyor is not your fault
checkstyle has major connection problems sometimes
restarting the build should work :+1:
Lasse Schuirmann
@sils
Aug 07 2016 18:49
oh that one
Mischa Krüger
@Makman2
Aug 07 2016 18:49
@caichinger shall I rebuild or did you change your PR anyway?
Lasse Schuirmann
@sils
Aug 07 2016 18:49
right don't worry about that one @caichinger just ping one of us, most active people here can retrigger
caichinger
@caichinger
Aug 07 2016 20:41

@Makman2 build worked fine this time, thanks for looking at it.
Overall I think I am making progress, slowly but steadily :)

codecov complains about an uncovered line in the NotebookHandler and since the remaining automatic checks look fine, can one of you please take a look at the second question I formulated in https://github.com/coala-analyzer/coala-bears/pull/655/ (i.e. where to put notebook related stuff?)?
I can of course add the missing test to PEP8JupyterNotebookBearTest to make the checks pass but it feels like the wrong place.

I have to do some other things now but hopefully I can come back to this tomorrow. Until then I wish you a nice evening! :)

Lasse Schuirmann
@sils
Aug 07 2016 20:42
@caichinger the bear-using-bears idea is currently not being worked on
@mr-karan wanted to look into it a bit but he is busy with other awesomeness https://www.youtube.com/watch?v=JKHCklHhAnc
caichinger
@caichinger
Aug 07 2016 20:44
there are always too many awesome things ;)
but how about the notebook handling? the notebook could also be R and Julia, therefore I am asking.
Lasse Schuirmann
@sils
Aug 07 2016 20:45
Ah! So we could generalize the bear later to work for R and Julia as well?
caichinger
@caichinger
Aug 07 2016 20:45
imho I would leave the current bear as is, I think that is fine. but having notebook reading/writing defined within the same module is strange.
yes. you just need to parse the json file and then apply whatever bear to the code cells
Lasse Schuirmann
@sils
Aug 07 2016 20:46
Agreed, leave it as is and file an issue to move out notebook handling and create bears for R and Julia as well
gotta cook a bit ;)
caichinger
@caichinger
Aug 07 2016 20:46
okay, sounds good
:)
thx for responsing so quickly. ;)
Lasse Schuirmann
@sils
Aug 07 2016 21:04
sure, did you hear my lightning talk? Remember the "Respond now" slide?