These are chat archives for coala/coala-bears
Hi there :)
I have two questions:
Could one of you please take a look at the AppVeyor build in
There is a problem as
shows but I do not know what it means with respect to my PR.
What does it mean and what do I have to do?
How do I correctly merge upstream changes into my branch while still doing ammend-only
Should I do
git merge --squash and then
git commit ammend? But then all your commits
end up in my single commit. I guess for the PR, i.e. the diff it does not matter but it
Thanks again for your patience!
@Makman2 build worked fine this time, thanks for looking at it.
Overall I think I am making progress, slowly but steadily :)
codecov complains about an uncovered line in the NotebookHandler and since the remaining automatic checks look fine, can one of you please take a look at the second question I formulated in https://github.com/coala-analyzer/coala-bears/pull/655/ (i.e. where to put notebook related stuff?)?
I can of course add the missing test to PEP8JupyterNotebookBearTest to make the checks pass but it feels like the wrong place.
I have to do some other things now but hopefully I can come back to this tomorrow. Until then I wish you a nice evening! :)