hi, please someone restart automatic checks for coala-analyzer/coala-bears#655. imo they should be fine. thanks!
restarting now :)
done
great :)
someone wants to review coala-analyzer/coala-bears#722 ?
I'm doing the final ports to
@linter
so we can delete
Lint in the next release :+1:
hey
@Makman2 just wanted to tell you that youre awesome!
you're doing that quite often these times :P :P :P
is that a problem?!
@Adrianzatreanu but thanks again with-combatant-against-bad-code :P
not at all :P
RLintBear: Refactor to Linter v2 API
commit f0405bdc7eff94a8d0f22936c7fb33c7ad747bdc @Makman2 Makman2 committed on Apr 3
commit f0405bdc7eff94a8d0f22936c7fb33c7ad747bdc @Makman2 Makman2 committed on Apr 3
3 apr
thats an old one :D
yeah I created them a while ago
but they had issues
and I was too lazy to fix 'em ... :3
they look good
i approved them
nice feel free to merge :)
bam and another branch gone :D
Hey @Asnelchristian we have a PHP user here, I feel like code sniffer gets more important every day. Do you think it's complicated to add all those options?
damn that was fast :O got all 5 remaining bears to work instantly :O
coala-analyzer/coala-bears#723 , the last three not using
@linter :)
(yet)
now-i-want-to-get-my-pr-merged-first!
wawawawawaaaa! coala-analyzer/coala-bears#724
(It's already approved)
no not really @sils1297
I reject it hereby
:P
neat @Adrianzatreanu if you need any help I'm available right now :)
btw. @Adrianzatreanu do you need anything :)
most of those are not really settings
@Asnelchristian I feel there must be way more settings than there are on that link I gave you we just have to find it..
@sils1297 no lasse, youve done a lot today, plus i have to study for like half an hour or so, but if i do need help, ill elt ya know ;) thx
@Adrianzatreanu you sound weird. Did I do something wrong :(
wow
i just had a day where i was thankful to 2 people
and im suddenly accused by both of being weird today
bumps up motivation to being a better person
:D sorry, we had a good laught about that
but I was afraid of being a bit harsh to you earlier as well...
when :( ?
docopt
no optparse?
no docopt I think
I get this always confused
you were harsh?
i thought thats usually you
I'm trying very hard not to be harsh all the time :(
hah i was just making fun of you as you did earlier
:p payback
:'(
sils @sils1297 is very sensible and will not dare to go outside the apartment today...
@sils1297 i found out about phpcbf
i am trying to modify it so that it can correct the file
hum
it is not working ....
@Asnelchristian youre making magic with bears :(
oh
my compliment went too early
now it feels awkward
Hey people
I got annoyed a lot by the recent CI failures that are going on
this shouldn't happen
hey dictator
ah yes
I think this PR might help:
coala-analyzer/coala-bears#725
are you removing checkstyle bear?
nope, I'm caching the download that fails
and hopefully it/ll get better
you know what would fix it?
moving to gitlab
tell me, little pawn
no it wouldn't.
hey @Adrianzatreanu
coala is not fun.
Can you file an issue?
It sucks. It always complains.
It never does fun things.
shouldnt it be
CI: Cache bear download directory
cache is the verb
you are caching the bear download directory
?
am i getting this wrong?
well it's the bear download cache directory
because the bear downloads it and caches it there
but that's not fun either :(
okok
yeah coala is not fun
MAKE SOMETHING FUN!
so loud
stop yelling, lasse
are you having alcohol again?
sils @sils1297 grabs the table and throws it out over the balcony onto the next house
WE STILL DON'T HAVE A SOLUTION
TO COALA NOT BEING FUNNY
can you fix it?
oh my god that must sound so intimidating for newcomers
when the maintainer goes rogue...
:(
is it funny?
no
it's intimidating
duh
damn!
THEN YOU BE FUNNY!
:japanese_goblin:
lasse, im scared
hi scared
hey simone
he's got lots of pasta
so he says pasta is good
not funny\
:/
what's funny...
u
me?
him?
u
@sils1297 still around?!
yes
okay
hey @sils1297 i also need you to talk about the cib show description thingie :D
but ill let christian first
we can actually add paths to the rhino, jslint, gjslint, zend configuration files
and modify the indent-size
apart from that did you find any other configs ?
@sils1297 so you said that by doing
cib list <bear> it should show the docstring from that bear after importing it :) ?
@Adrianzatreanu ahm... no. cib list should just show the names IMO.
@Asnelchristian sorry I don't fully get what you want :/
ok so having cib list would show the names of all installed bears
and cib list --all should show the names of all possible bears?
yes
ok and how to show details about a bear?
talking about this
yeah for that you make a show subcommand
ok so
so
cib show PEP8Bear would do that
cib show bearx
ok
but show only works with one bear at a time
correct
how would I catch the docstring?
i tried doing PEP8Bear.doc but its None
get the metadata?
i tried in python shell
coala has all this done for you, there's a show_bear function or so somewhere
that you could just call
hm
let me check what it needs
the -c thing works by now huh
?
yes
neat
:+1:
but you didn't fix the issue that it requests from pypi which bears exist wethre you need it or not :(
but i told you how im checking it
:/
i need it ..
im not sure how i should pass the bear
you import the bear class right?
that's the bear
ok
@Asnelchristian almost good to merge, asciinema missing
aaah my mum.... she is always calling me...
ah okay...
@Asnelchristian found something else...
nope
@sils1297 quite unsure what to give those
show_bear(package_object)
@Adrianzatreanu so my thoughts on this:
except for sections you just pass true
but
I think we should in coala remove the sections parameter
and remove the whole showing bears functionality from coala
and let cib do it
because it doesn't belong into coala
cool, some other time :D
what are the sections tho?
but file an issue :angel:
okey
they are the sections so the user will see which bears are used in which sections
but how do i place them here then?
either you pass it an empty dict
and see what happens
nah that's wrong
rather change the method in coala to not show the sections
so jsut remove whole sections functionality from coala?
yep it's quite useless :)
cool, please review it in 2mins :D
i have to change show_enumeration too :/
no
why>
its called with sections
yeah remove the call!
oh its called ony once
what are you doing man :P
:D
hey does someone want to make a bear for python? https://github.com/openstack/bandit I think that'd be a real deal breaker for a lot of people
@Nosferatul interested :p ?
https://github.com/coala-analyzer/coala/pull/2681/files @sils1297 please :D
@underyx ^ ? We need this possibly in the next days? Maybeyou could do it on your pseudo-20%-time-thingie.
ahm...
@Adrianzatreanu ...
don't you...
:( ?
want to adjust the calls of that function?
it's a positional parameter :(
I already have a prototype without tests
ah really ok
damn it
everything will break! :fire:
coala-analyzer/coala-bears@512088c
so if someone picks up bandit there's nothing much left to do except tests^^
@sils1297 i am going to do the asciinema tomorrow i really have to go
ah @Makman2 is there a PR? Can you rebase it? Then we could possibly get this in real quick?
I have no tests @sils1297
@Asnelchristian ok I'm marking it WIP, also there's one other issue that might be a real concern. See you :)
@Makman2 rebase it and give it to someone else
just wanted to say :D
alright: coala-analyzer/coala-bears#726
if someone wants to write a new bear :+1:
(or at least complete it :P)
sils @sils1297 votes for @underyx
or @chauffer
@Makman2 I gave it a title so people would see that this is for pickup
:+1:
@sils1297
these 2 i dont know how to fix
:/
i fixed the rest of the tests
@Adrianzatreanu you're funny :)
:D
you fixed the tests but not the functionality
thanks
not many people tell me that im funny
you always submit the best code snippets for review :)
:/
what did i not do now?
well you didn't adjust the usages
except those in the tests...
you should grep for usages!
i thought i did
hm
ah found
it was a sneaky one!
your diff doesn't show any such changes
it was a few lines above where print_bears would use show_bear
thats all
fixing tests for print_bears now too
ok this should have fixed it
492 contributions in the last year
shit thats a lot
in 6 months or so
so @sils1297
(venv) 192-168-0-102:cib adrianzatreanu$ python3 coala_package_manager/installation_tool.py show PEP8Bear
<class 'module'>
Traceback (most recent call last):
File "coala_package_manager/installation_tool.py", line 331, in <module>
sys.exit(main())
File "coala_package_manager/installation_tool.py", line 324, in main
show_bear(package_object, True, True, ColorPrinter)
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/coalib/output/ConsoleInteraction.py", line 695, in show_bear
console_printer.print(bear.name, color="blue")
AttributeError: module 'coalaPEP8Bear.PEP8Bear' has no attribute 'name'
is the output for
package_object = importlib.import_module(
'coala' + args['<bear>'][0] + '.' + args['<bear>'][0])
print(type(package_object))
show_bear(package_object, True, True, ColorPrinter)
im passing a module, right?
how does passing an object work inside of this?
how do you get the bear? You do have the object anyway in your tool don't you?
um, no?
i just have its name
im running show bear_name
@sils1297 sorry if bothering you but you said earlier that u are available, so i profit of that ;d
oh that was before, now my groceries arrived and I'm hungry :P
ok im waiting :D
@Adrianzatreanu Sure!
im not really sure thats still valid though
:/
Oh :worried:
@sils1297 dont forget about me, my life is depending on you!
@Adrianzatreanu really?
I'm here now but only a tiny bit, choose your question carefully, young padawan.
it is up there
i dont know why its not working :D
you're importing the .py file which is the module, not the bear
how do you import the bear when you install the requirements?
why can't you do the same?
the same
:D
really!? that works?
and then im using getattr to get .REQUIREMENTS
link to code?
wait a sec
let me try one bit of code
nah not working
package_object = importlib.import_module(
'coala' + package_name + '.' + package_name)
for requirement in getattr(package_object, package_name).REQUIREMENTS:
this is how i roll for reqs
see you do getattr(package_object, package_name)
you don't do that in the other one
-> code duplication
whaaat :/ ?
you gotta reduce your duplication, I have the feeling that you have still some of that, whenever I find an issue it's duplication.
the getattr gets the bear from the module
so you have to pass the getattr to show_bears instead of the object
no i tried that when i said wait a se
Traceback (most recent call last):
File "coala_package_manager/installation_tool.py", line 330, in <module>
sys.exit(main())
File "coala_package_manager/installation_tool.py", line 323, in main
show_bear(getattr(package_object, args['<bear>'][0]), True, True, ColorPrinter)
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/coalib/output/ConsoleInteraction.py", line 695, in show_bear
console_printer.print(bear.name, color="blue")
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/pyprint/Printer.py", line 43, in print
return self._print(output, **kwargs)
AttributeError: 'str' object has no attribute '_print'
@sils1297 is this beyond you??
oh sorry getting prompted from too many locations when I actually only want to sleep :P
sleep, then!
(after helping me out with this)
what the hell is wrong with your printer
what did you do!??
what printer should i use?
im using ColorPrinter idk
you're giving it a class...
are you drugged today? :P
what
give it an instance!
you can't pass
ConsolePrinter
you gotta pass
ConsolePrinter()
oh
of course it has no self...
i had no idea what a printer was :D
but well you can just read the traceback?
cant say it was that clear
"add ()"
well this one looks to be with the printer!
Traceback (most recent call last):
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/pyprint/ColorPrinter.py", line 44, in _print
return self._print_colored(output, **kwargs)
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/pyprint/ColorPrinter.py", line 56, in _print_colored
raise NotImplementedError
NotImplementedError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "coala_package_manager/installation_tool.py", line 331, in <module>
sys.exit(main())
File "coala_package_manager/installation_tool.py", line 324, in main
show_bear(getattr(package_object, args['<bear>'][0]), True, True, ColorPrinter())
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/coalib/output/ConsoleInteraction.py", line 695, in show_bear
console_printer.print(bear.name, color="blue")
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/pyprint/Printer.py", line 43, in print
return self._print(output, **kwargs)
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/pyprint/ColorPrinter.py", line 46, in _print
return self._print_uncolored(output, **kwargs)
File "/Users/adrianzatreanu/venv/lib/python3.5/site-packages/pyprint/ColorPrinter.py", line 65, in _print_uncolored
raise NotImplementedError
NotImplementedError
adrian.
the colorprinter is an abstract class
thsi sounds bad
pass a console printer
basically NotImplementedError yells at you "I'm abstract" :)
:/
sils @sils1297 is tired
sorry ^
what printer should i use instead?
:point_up: August 29, 2016 12:27 AM
:point_up: August 29, 2016 12:22 AM
oh cool, nailed it
thanks
@sils1297 what is the best text coloring tool i should use :D ?
@Adrianzatreanu colored pencils :P
just kidding :)
:D
i found termcolor
looks quite good
cib 0.5.3 with colored output and nicely printed, and the brand new
cib show <bear_name> which gives you a lot of useful output about each bear, is now live and rocking for testing!
testing it right now :)
@Adrianzatreanu this doesn't seem to be normal
RLintBear is installing.. DONE!
Bears that failed installing:
RLintBear