These are chat archives for coala/coala-bears

1st
Sep 2016
AbdealiJK
@AbdealiJK
Sep 01 2016 04:10
I had 2 ideas for the issue. Remind me to write them down somewhere
AbdealiJK
@AbdealiJK
Sep 01 2016 04:51
@Adrianzatreanu where is cib hosted :| The pyPI has no link to the repo and google cant find it because it's too small
AbdealiJK
@AbdealiJK
Sep 01 2016 05:01

Here are the possibilities in my opinion:

  1. Lazy imports: Make a patch to load the imports only when it is being used. There's a recipe for this at http://code.activestate.com/recipes/473888-lazy-module-imports/ Note that bear writers need not write this, cib can just add it to the top. Also, this needs to be tested, there are comments about C python modules not working correctly.
  2. Sanitize bears when processing - When the bear is being processed by cib, remove all statements that can be removed. i.e. remove all functions, decorators etc. Also remove all imports that can cause import errors. This removal could be done using regex or python's AST parser (whichever works). Now this sanitized bear will have all metadata required, so use this sanitized bear for the dependency checking.

Please put this in the related issue ...

Lasse Schuirmann
@sils
Sep 01 2016 07:50
ouh lazy imports are interesting
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 01 2016 12:49
AbdealiJK
@AbdealiJK
Sep 01 2016 12:51
@Adrianzatreanu Not sure what we're talking about
Lasse Schuirmann
@sils
Sep 01 2016 12:54
@Adrianzatreanu I think we definitely need a way to like cib install CPDBear==0.9
and also spec the version in the coafile for the civ install -c option
otherwise CI may break
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 01 2016 13:01
What CI? :D
@AbdealiJK u asked where u can find cib
@sils1297 sure, but for this i need to make for bears versions like nondev
AbdealiJK
@AbdealiJK
Sep 01 2016 13:12
@Adrianzatreanu I meant the source code / github repo / gitlab repo / issue tracker
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 01 2016 13:12
Oh
Lasse Schuirmann
@sils
Sep 01 2016 13:12
@Adrianzatreanu well for that feature you could also pass a dev version
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 01 2016 13:13
Wait searching now that one not working
Apparently not wew
Www
But
AbdealiJK
@AbdealiJK
Sep 01 2016 13:51
@Adrianzatreanu would be nice to add the gitlab URL to the pypi page (to the setup.py)
www.gitlab.com/coala/cib gives me a 404 error ...
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 01 2016 13:58
Yeah i mentioned that that link is wrong
I gave you a new one
Ill open an issue for the url
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 01 2016 14:10
Good afternoon guys :)
coala-analyzer/coala-bears#759
though i am still to add some configs
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 01 2016 14:21
@sils1297 thanks for the fast review
hum
:sweat_smile:
should i remove function_name_case
and use hyphenated_lowercase as default naming convention
and you need to explain what hyphenated lowercase is
the comment itself is only about having hyphenated lowercase instead of hyphenated_lowercase
so the user doesn't need ugly underscores in the coafile
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 01 2016 14:51
neat :) it is clear
now
thanks
Lasse Schuirmann
@sils
Sep 01 2016 17:11
@AbdealiJK got time now?
merging your changes now
@Adrianzatreanu did you give anyone access yet? Can we possibly write a script that does that?
Lasse Schuirmann
@sils
Sep 01 2016 17:25
argh @AbdealiJK tests missing :/ your lambdas I think
Lasse Schuirmann
@sils
Sep 01 2016 18:38
hey @abhsag24 where are your bears? Didn't we merge any of them? :/
Abhay Raizada
@abhsag24
Sep 01 2016 19:26
IndentationBear and AnnotationBear are merged
LineBreak is still in progress
Lasse Schuirmann
@sils
Sep 01 2016 19:38
ah great @abhsag24 I thin we'l make a patch to the annotation bear tomorrow so it'll just return no annotations if it doesn't support the language
I think that should be a default behaviour
and then we'll do auto removal of todo comments for the keywordbear
Abhay Raizada
@abhsag24
Sep 01 2016 19:49
but that is kinda of a hack right?
Lasse Schuirmann
@sils
Sep 01 2016 19:49
why?
Abhay Raizada
@abhsag24
Sep 01 2016 19:49
it should return no coalang found, because there are annotations, it just doesnt know about them
Lasse Schuirmann
@sils
Sep 01 2016 19:49
this way you can use it if you need the data only optionally
you want to be able to use the bear as a dependency and it shouldn't error out
you may error out if the annotation bear doesn't give you anything useful
or you may proceed with processing without the data if you can
like in the case of the keywordbear
Abhay Raizada
@abhsag24
Sep 01 2016 19:51
yes but it errors out because of the right reason, wouldnt the better way be to not run the AnnotationBear in the first place in such a case?
Lasse Schuirmann
@sils
Sep 01 2016 19:53
but a dependency is always run
how can I write a bear that works for all languages
and if the annotation bear gives information it uses them to enhance the results?
Abhay Raizada
@abhsag24
Sep 01 2016 19:53
but a dependency is always run
^thats the problem
Lasse Schuirmann
@sils
Sep 01 2016 19:54
yeah and the dep can just return empty or an error hidden result
Abhay Raizada
@abhsag24
Sep 01 2016 19:54
there should be a setting in coala to avoid running the deoendency then right?
caichinger
@caichinger
Sep 01 2016 21:05
@sils1297, AppVeyor failed, I have not seen this error yet. Something related to the CoffeeLintBear. Not sure why this popped up...
Lasse Schuirmann
@sils
Sep 01 2016 21:05
@caichinger already investigating, it's not your fault
it's failing all builds
there was a new pyflakes release
and our deps have gone haywire
shit we'll have to fix this :/
and you'll have to rebase it again after
I hope we can get this fixed within an hour
caichinger
@caichinger
Sep 01 2016 21:07
nasty :/
okay, not problem for me. in case I fall asleep too early I will rebase tomorrow morning...
Lasse Schuirmann
@sils
Sep 01 2016 21:07
:+1:
really nasty it's not even our dependency
it's a dep of a dep which conflicts with a dep from another dep
due to the update
caichinger
@caichinger
Sep 01 2016 21:08
argh
Lasse Schuirmann
@sils
Sep 01 2016 21:08
and it affects the release even
caichinger
@caichinger
Sep 01 2016 21:08
damn it... sounds really annoying!
Lasse Schuirmann
@sils
Sep 01 2016 21:08
oh yes it's a work-through-the-night-scenario :P
@fneu around?
caichinger
@caichinger
Sep 01 2016 21:12
fingers crossed :)
Lasse Schuirmann
@sils
Sep 01 2016 21:17
@caichinger hotfix available it should work
let's see
with a bit of luck this is over soon
caichinger
@caichinger
Sep 01 2016 21:21
I ll give it a try!
Lasse Schuirmann
@sils
Sep 01 2016 21:21
not yet
it's not merged yet but I have the hotfix submitted
we're also trying to reach the maintainers on IRC
if they do a quick release for their requirements it's solved as well
cleaner
caichinger
@caichinger
Sep 01 2016 21:21
okay, I see
Lasse Schuirmann
@sils
Sep 01 2016 21:23
but one or the other will definitely happen soon
caichinger
@caichinger
Sep 01 2016 21:25
:+1:
caichinger
@caichinger
Sep 01 2016 21:32
I am too tired to stay up any longer today but I will rebase before going to work tomorrow. All the best for tonight :)
Lasse Schuirmann
@sils
Sep 01 2016 21:32
cool @caichinger see you tomorrow!
@caichinger I might rebase it for you
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 01 2016 21:55
@sils1297 havent given access yet. I dont know if you can modify permissions using a script, I'll give it a try tomorrow. We decided to wait until we agree who to give access to and then we do it :d
Lasse Schuirmann
@sils
Sep 01 2016 21:55
:+1:
Lasse Schuirmann
@sils
Sep 01 2016 22:22
@caichinger and your bear is merged! This is awesome :)
sils @sils1297 goes tweeting