These are chat archives for coala/coala-bears

3rd
Sep 2016
AbdealiJK
@AbdealiJK
Sep 03 2016 11:09
@sils1297 around ?
Lasse Schuirmann
@sils
Sep 03 2016 11:12
kind of
what do you need :)
AbdealiJK
@AbdealiJK
Sep 03 2016 11:15
Wanted a review - but I forgot that I've still not fixed that coverage issue :P And not addressed your previous comments
so, nevermind. But would like a review in a bit
Lasse Schuirmann
@sils
Sep 03 2016 11:15
ok ping me when you need it again :)
AbdealiJK
@AbdealiJK
Sep 03 2016 11:15
:+1:
AbdealiJK
@AbdealiJK
Sep 03 2016 12:17
Is it me or is appveyor faster than our circleci builds ?
Lasse Schuirmann
@sils
Sep 03 2016 12:17
we're sponsored by appveyor
-> better and more servers
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 03 2016 12:17
:D
thats cool!
AbdealiJK
@AbdealiJK
Sep 03 2016 12:20
@sils1297 coala-analyzer/coala-bears#747
Lasse Schuirmann
@sils
Sep 03 2016 12:26
:+1: I'll be eating my plate and review then ASAP
AbdealiJK
@AbdealiJK
Sep 03 2016 12:34
I have one more minor commit to add. Let me know when done
Lasse Schuirmann
@sils
Sep 03 2016 12:34
just push it on top?
AbdealiJK
@AbdealiJK
Sep 03 2016 12:34
I will be pushing on top. But will incorporate your comments in that push too
Lasse Schuirmann
@sils
Sep 03 2016 12:35
ok
AbdealiJK
@AbdealiJK
Sep 03 2016 12:37
@sils1297 "|".join(['a','b']) gives a|b .. not |a|b|
BTW: PuppetLintBear, I'd normally have added configs too. But I have no idea about puppet and not interested in trying it out atm. The aim of that commit is to get the PR coala-analyzer/coala-bears#238 closed.
Lasse Schuirmann
@sils
Sep 03 2016 12:42
you mean @sims1253 ?
AbdealiJK
@AbdealiJK
Sep 03 2016 12:42
Ah. yes, I indeed meant @sims1253
Maximilian Scholz
@sims1253
Sep 03 2016 12:43
:)
AbdealiJK
@AbdealiJK
Sep 03 2016 12:56
@sils1297 When you say "not a bugfix" - What do you want me to do there about ES version ? Remove the commit ?
Lasse Schuirmann
@sils
Sep 03 2016 12:56
sorry I want you to change the Fixes toa Closes in the message
AbdealiJK
@AbdealiJK
Sep 03 2016 12:57
I see, does that matter very much ? (Just asking)
Lasse Schuirmann
@sils
Sep 03 2016 12:57
we use it for bug prediction
also for determining what can be backported
AbdealiJK
@AbdealiJK
Sep 03 2016 12:57
Hm, I see - got it
Lasse Schuirmann
@sils
Sep 03 2016 12:57
this would break versioning for a backport
AbdealiJK
@AbdealiJK
Sep 03 2016 13:02
I hate the github new UI.
done ?
Lasse Schuirmann
@sils
Sep 03 2016 13:05
yes sorry
done
AbdealiJK
@AbdealiJK
Sep 03 2016 13:08
Can I delete all the existing ack/unack comments in the PR ? Its confusing
Lasse Schuirmann
@sils
Sep 03 2016 13:08
yep but please reack
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 03 2016 13:10
what new github ui?
Lasse Schuirmann
@sils
Sep 03 2016 13:22
@AbdealiJK no reacks?
@Adrianzatreanu also win build fails
ah @AbdealiJK I mean
gitters autocomplete is confusing :/
AbdealiJK
@AbdealiJK
Sep 03 2016 13:48
Sorry its not ready yet. On a call.
AbdealiJK
@AbdealiJK
Sep 03 2016 15:33
@sils1297 You can begin with coala-analyzer/coala-bears#747 if you want. Still debugging the last commit on windows though