These are chat archives for coala/coala-bears

9th
Sep 2016
Lasse Schuirmann
@sils
Sep 09 2016 08:56
Hey @/all bears interested people. We've got a quality problem with the bears. A lot of bears work in theory and in our tests but are never ran in production like circumstances.
Thanks for @sims1253 for bringing this up, I noticed that as well
and I think we should do something about this
CC @Makman2 who had been preaching for better tests for bears for some time as well
Adhityaa
@adtac
Sep 09 2016 08:58
integration tests for each bear
not just a valid_file, invalid_file test
something more... I don't know... real-life?
Maximilian Scholz
@sims1253
Sep 09 2016 08:59
Just as a how I stumbled into this:
Procrastinating from my thesis writing I thought I could setup coala for it so just get all the natural language bears into a file and go.
WriteGoodLintBear and AlexBear need a npm package which I had to look for via google, LanguageToolBear needs language tools, again no link in docs, ProseLintBear workt after a pip install but had to look that up too myself.
The language setting for LanguageToolBear is not documented as i have to guess how to tell him what language I need (it needs eng-us for example but wont understand english, ger or german)
after that, LanguageToolBear still does not yield errors for wrong words :/
Adhityaa
@adtac
Sep 09 2016 09:00

no link in the docs

You mean in bear-docs?

Maximilian Scholz
@sims1253
Sep 09 2016 09:00
yes
Adhityaa
@adtac
Sep 09 2016 09:01
I guess we could use the REQUIREMENTS attribute from the metadata to render something
CC @Adrianzatreanu
Maximilian Scholz
@sims1253
Sep 09 2016 09:01
ok. So I can give the language = en-UK which and he will take it but not yield errors. only en-US works so far. And I had to look into the code to find that
Lasse Schuirmann
@sils
Sep 09 2016 09:01
urghs silently errors out?
Adhityaa
@adtac
Sep 09 2016 09:01
Those kind of things should go into the param docs of the bear IMO
no way we can automatically generate those in bear-docs if it's not documented somewhere!
Maximilian Scholz
@sims1253
Sep 09 2016 09:04
I mean in the future it could be part of writing the bear to also include settings (and what the settings can be filled with), at least where to find the tools that are a dependency and such
Lasse Schuirmann
@sils
Sep 09 2016 09:05
maybe where to find a tool could be a ManualRequirement thing
that would be more or less mandantory
Maximilian Scholz
@sims1253
Sep 09 2016 09:07
I mean it would be nice to have install directions but a link to the tool page should be enough
Adhityaa
@adtac
Sep 09 2016 09:08
I'm working on it
Lasse Schuirmann
@sils
Sep 09 2016 09:08
the ManualRequirement would have a link and some install commands as arguments
then the error message would generate instructions for the user from that
(as well as the other requirements given)
Adhityaa
@adtac
Sep 09 2016 09:40
Ok bear-docs now has a link to the source code in case it will be useful
(at the heading)
small steps :P
Lasse Schuirmann
@sils
Sep 09 2016 09:41
good one!
Adhityaa
@adtac
Sep 09 2016 09:42
Also @sils1297 I made generate.py into a executable ./generate
easier
heads up for the next time you run it :P
Lasse Schuirmann
@sils
Sep 09 2016 09:44
:+1:
Adhityaa
@adtac
Sep 09 2016 09:48
Gotta run now. I'm adding the requirements thing later today :+1:
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Sep 09 2016 10:03
:point_up: September 9, 2016 12:01 PM i dont see how you can use REQUIREMENTS to see what language it needs :(
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 10:19
Good morning :)
Lasse Schuirmann
@sils
Sep 09 2016 10:25
hey :)
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 10:27
uhm... is there something very important i can help with right now :sweat_smile:
@sils1297
btw. how are you doing ?
Lasse Schuirmann
@sils
Sep 09 2016 10:29
@Asnelchristian reviews, bug triaging, bug fixing, fixing up your pending PRs
anything except new features I guess :P
i think we have to remove the old settings from the list due to the parameter deprecation
it is error prone
coala-analyzer/coala-bears#802
is a clear example
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 11:09
@sils1297 are you here
?
Lasse Schuirmann
@sils
Sep 09 2016 11:10
sure
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 11:10
okay
i was thinking of modifying deprecate_settings
Lasse Schuirmann
@sils
Sep 09 2016 11:10
:+1: what exactly?
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 11:10
so that when the user provide both a deprecated, and the new setting replacing it,
their values are checked
and
Lasse Schuirmann
@sils
Sep 09 2016 11:11
?
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 11:11
if they conflict , the value of the new setting is used but a message is printed telling the user that the setting was deprecated and the values are conflicting so that things like coala-analyzer/coala-bears#802 never happen again
Lasse Schuirmann
@sils
Sep 09 2016 11:12
:+1:
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 11:15
what do you think ?
Lasse Schuirmann
@sils
Sep 09 2016 11:25
@Asnelchristian some more sanitychecking would be good if you can do it
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 11:38
@sils1297 coala-analyzer/coala#2739 :)
Lasse Schuirmann
@sils
Sep 09 2016 11:48
@Asnelchristian doesn't that fix an issue or something?
not that I know of.
it's awesome.
shipit
ship it
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 11:50
:) :P :+1:
cobot ship it
Lasse Schuirmann
@sils
Sep 09 2016 11:51
now:
ship it
Lasse Schuirmann
@sils
Sep 09 2016 11:52
bot needs restart after channel invitation
just did tat
Meet Mangukiya
@meetmangukiya
Sep 09 2016 11:52
@underyx can we have a .coafile for the cobot coffee files?
Lasse Schuirmann
@sils
Sep 09 2016 11:53
I have one somewhere
[Default]
bears = CoffeeLintBear
files = **.coffee
Bence Nagy
@underyx
Sep 09 2016 11:54
:coffee:
Christian Asnel Ngoulla Sob
@AsnelChristian
Sep 09 2016 11:54
:tea:
Lasse Schuirmann
@sils
Sep 09 2016 11:54
@meetmangukiya you can add SpaceConsistencyBear
meetmangukiya @meetmangukiya thinks @underyx is on coffee break
Lasse Schuirmann
@sils
Sep 09 2016 11:54
it'll do the tab/spaces conversion for you
Meet Mangukiya
@meetmangukiya
Sep 09 2016 11:56
@sils1297 that :point_up: September 9, 2016 5:23 PM didn't change anything in the file
Lasse Schuirmann
@sils
Sep 09 2016 11:56
use SpaceConsistencyBear
Meet Mangukiya
@meetmangukiya
Sep 09 2016 11:57
what do I write in the config under
[SpaceConsistencyBear]
# what is the config :P
Lasse Schuirmann
@sils
Sep 09 2016 12:00
no bears = CoffeeLintBear, SpaceConsistencyBear
Bence Nagy
@underyx
Sep 09 2016 14:43
hey people with WIP PRs, you might want to rebase now cause there's a whole bunch of fixes for CI on master
Meet Mangukiya
@meetmangukiya
Sep 09 2016 14:58
@sils1297 should making issues from gitter be incorporated, if no then I should stop working on it I guess :laughing:
Lasse Schuirmann
@sils
Sep 09 2016 14:58
@meetmangukiya I think we want that but we need to make sure people don't abuse it
@meetmangukiya so we could possibly file the issues with their accounts or rate limit it somehow or make it a maintainers only feature
Meet Mangukiya
@meetmangukiya
Sep 09 2016 15:00
If we want to file issues from their account, we need to use oauth2 :/ That can be possible I guess :/ Lets see
but a downside of this bot making issues is that we need full repo's name that too correct, the same that github has