These are chat archives for coala/coala-bears

27th
Oct 2016
Meet Mangukiya
@meetmangukiya
Oct 27 2016 14:46

(sadly github doesn't have a rebase button ...)

AFAIK there does exist one :/ for maintainers only though ... sils had shared a post from github blog about that :/

Lasse Schuirmann
@sils
Oct 27 2016 14:47
well not really, there's a rebase and merge which isn't the same
Meet Mangukiya
@meetmangukiya
Oct 27 2016 14:51
:+1: memory loss :P
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:35

cobot file issue GitCommitBear: Make the regex match message more verbose

|    | Shortlog of HEAD commit does not match given regex.

This can be written a bit better.

Mischa Krüger
@Makman2
Oct 27 2016 18:35
@meetmangukiya what would you change?
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:35

cobot file issue coala-bears GitCommitBear: Make the regex match message more verbose

|    | Shortlog of HEAD commit does not match given regex.

This can be written a bit better.

coala-bot
@coala-bot
Oct 27 2016 18:35
Here you go: coala/coala-bears#942
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:35
the given
See https://github.com/coala/coala/pull/2900#issuecomment-256719293
It is very unclear what has to be done
Mischa Krüger
@Makman2
Oct 27 2016 18:36
yeah the bear is quite generic, that's why the message is that generic.
But yeah what about including the regex into the message?
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:37
yeah, atleast that should be done,
the purpose of the regex should be included as well.
Mischa Krüger
@Makman2
Oct 27 2016 18:37
purpose?
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:38
what the regex was meant to check
Mischa Krüger
@Makman2
Oct 27 2016 18:38
Shortlog of HEAD commit :)
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Oct 27 2016 18:38
"Shortlog of HEAD commit does not match given regex." -> "Shortlog of HEAD commit does not match given regex." + regex
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:38
what was the short log supposed to be like,, ^^
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Oct 27 2016 18:38
well yeah but you still have no idea what it should be like
i agree with @meetmangukiya this time
Mischa Krüger
@Makman2
Oct 27 2016 18:38
that's why we should include the regex
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Oct 27 2016 18:38
yeah exactly
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:38
but can figure something at least
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Oct 27 2016 18:39
@meetmangukiya wanna do it or should i do it really fast?
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:39
if the regex is mentioned :P
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Oct 27 2016 18:39
if you do it ill help you merge it fast
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:39
I'll do it :P Gotta complete hacktoberfest :P
Mischa Krüger
@Makman2
Oct 27 2016 18:39
haha :+1: :D
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:39
assign me
Mischa Krüger
@Makman2
Oct 27 2016 18:39
go go go - you have 5 minutes for the PR :+1:
:P
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Oct 27 2016 18:40
gogogo
Mischa Krüger
@Makman2
Oct 27 2016 18:42
3 minutes left @meetmangukiya
:P
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Oct 27 2016 18:47
times over
@Makman2 will now take over
Mischa Krüger
@Makman2
Oct 27 2016 18:48
...
done, but rebase issue!
Mischa Krüger
@Makman2
Oct 27 2016 18:48
@meetmangukiya sorry but this is not a ready PR...
you lost ... :D :P
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Oct 27 2016 18:48
hah
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:49
ever since the invalidlinkregex is ammended, every rebase fails :(
Mischa Krüger
@Makman2
Oct 27 2016 18:49
did you open a new branch on our master?
then you shouldn't have conflicts^^
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:50
yeah.. I just realised that :P
Adhityaa
@adtac
Oct 27 2016 18:50
did you change your fork's master @meetmangukiya
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:51
yeah.. long back I guess
well 10 minutes late :P
Mischa Krüger
@Makman2
Oct 27 2016 18:55
now you lost twice
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:55
I hope it'd be fine master @Makman2
Mischa Krüger
@Makman2
Oct 27 2016 18:55
shame on you
:P
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:56
@Makman2 gogogo!! review!
Mischa Krüger
@Makman2
Oct 27 2016 18:56
gimme the PR :O
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:56
activity box in the right
Mischa Krüger
@Makman2
Oct 27 2016 18:56
oh ... yes ...
Makman2 @Makman2 shame on me :3
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:56

ah.. wait

here it is coala/coala-bears#943

Mischa Krüger
@Makman2
Oct 27 2016 18:57
no colon between Fixes ISSUE-ID
Meet Mangukiya
@meetmangukiya
Oct 27 2016 18:57
indeed @Makman2 given that you been contributor for more then a year :P
done!

indeed @Makman2 given that you been contributor for more then a year :P

well, this was an assumption

Mischa Krüger
@Makman2
Oct 27 2016 18:59
missing space behind period
I'm there since beginning :)
so yes assumption is right :)
+ or maybe add a \n behind the period, then the regex is more dedicated from the text^^
dedicated is the wrong word, hope you get what I mean^^
Meet Mangukiya
@meetmangukiya
Oct 27 2016 19:01
:+1:
Yeah I got it
Make it stand out -- more focus on the regex -- more importance to the regex .. is what you mean I assume.
Done!
Merge!!
lol.. that got a bit intense! :P
Mischa Krüger
@Makman2
Oct 27 2016 19:03
hyper hacking :3
alright everything acknowledged, waiting for CI to pass :+1:
Meet Mangukiya
@meetmangukiya
Oct 27 2016 19:19
CI makes people realise that hyperhacking ain't efficient enough!
AFAIR the renaming was done long back, right?
How do the current PRs CI pass then :confused: ?
Mischa Krüger
@Makman2
Oct 27 2016 19:30
sorry haven't read your stuff, gimme a minute doing currently something else
Meet Mangukiya
@meetmangukiya
Oct 27 2016 19:30
CC @sils something that I think(dont know for sure) is important ^^
sure @Makman2
I think I'll go to bed now :wave:
@Makman2 the 5 minute PR is gonna take longer then a day I guess :P
meetmangukiya @meetmangukiya is going to bed, thats why.
Mischa Krüger
@Makman2
Oct 27 2016 19:34
oh if you have a bit time still @meetmangukiya
you just need to adapt a test
some test asserted for the yielded message, just change it to include the regex used in the test :)
Lasse Schuirmann
@sils
Oct 27 2016 19:57

cobot new issue documentation Define how aspects and settings should be named

This should go into the documentation.

  • An aspect should just talk about a property of something, not qualifying it. Don't name it TooLong but Length
  • Then give it settings, e.g. Metadata.CommitMessage.Shortlog.Length can have a setting max_shortlog_length

About settings:

  • Do not use "allow" or "check", aspects can be turned on or off but Settings should change behaviour.
  • For bool: use "shortlog_colon" if it must have a colon in the shortlog. Describe the thing that should be true: "shortlog_starts_upper_case". Give as much context as needed but not more.
coala-bot
@coala-bot
Oct 27 2016 19:57
Here you go: coala/documentation#223
Lasse Schuirmann
@sils
Oct 27 2016 20:10

cobot new issue coala Make a metadata aspect class

Which should cover all aspects that the GitCommitBear can check.

I'll do this difficulty low

coala-bot
@coala-bot
Oct 27 2016 20:10
Here you go: coala/coala#2901