These are chat archives for coala/coala-bears

10th
Nov 2016
Niklas
@NiklasMM
Nov 10 2016 06:54
It seems like there is no Pyflakes bear. Is there a reason for that? Seems like an elemental bear to have :)
John Vandenberg
@jayvdb
Nov 10 2016 06:54
there is an issue, or pull about it
and yes, as the main developer of pyflakes atm, I find it terribly that we dont have a bear for it
Niklas
@NiklasMM
Nov 10 2016 06:55
hmm let's see
there was a PR for a flake8 bear
coala/coala-bears#857
but it was closed
And since flake8 is also just a wrapper, I think it would be better to have individual bears
John Vandenberg
@jayvdb
Nov 10 2016 06:56
nod
Niklas
@NiklasMM
Nov 10 2016 06:57
ah and there is this coala/coala-bears#169
John Vandenberg
@jayvdb
Nov 10 2016 06:57
and flake8 v3 is a weird and unstable wrapper now
maybe it will be good later, but I doubt it adds anything that we do not want to be doing inside coala
Niklas
@NiklasMM
Nov 10 2016 06:58
I think flake8 is heavily used, maybe we should make it easy for users to transition from flake8 to PEP8Bear and PyflakesBear
John Vandenberg
@jayvdb
Nov 10 2016 06:59
If we want to use the flake8 plugins, then we have a good reason to have a flake8 bear. but actually this is a tiny part of flake8, and we could copy it.
Niklas
@NiklasMM
Nov 10 2016 06:59
ah yes
wasn't aware of plugins
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 08:44
@jayvdb Should I resume on the flake8 bear?
John Vandenberg
@jayvdb
Nov 10 2016 09:04
No. It is not a good idea.
Niklas
@NiklasMM
Nov 10 2016 09:04
Make a pyflakes bear instead? :+1:
John Vandenberg
@jayvdb
Nov 10 2016 09:04
A pyflakes bear is more important and less buggy
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 09:06
My Flake8Bear gave weird results, so I closed my PR. I did not understand why it is happening. Writing a bear is simple.
Wasted a lot of time on it
We already have an issue on PyFlakes coala/coala-bears#825
Niklas
@NiklasMM
Nov 10 2016 09:10
Would you be willing to work on that?
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 09:11
Yeah! Its fine
@jayvdb I remember @sils saying that someone has asked for Flake8Bear - customer request.
Niklas
@NiklasMM
Nov 10 2016 09:15
We already have 1/3 of "Flake8Bear" with PEP8Bear
With Pyflakes Bear we would have 2/3
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 09:15
Yeah!
John Vandenberg
@jayvdb
Nov 10 2016 09:16
What feature do they want?
Niklas
@NiklasMM
Nov 10 2016 09:16
and that McCabe analyzer that is the third tool Flake8 wraps can probalbly be done by a bear too
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 09:16
MCCabe complexity is was about to say that
@jayvdb I don't know
John Vandenberg
@jayvdb
Nov 10 2016 09:17
Need to know that
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 09:18
He just said that he had a customer request for Flake8Bear. We shall ask him once he is online.
John Vandenberg
@jayvdb
Nov 10 2016 09:18
Could be they need pep8-naming or pydocstyle, which are common flake8 plugins
Lasse Schuirmann
@sils
Nov 10 2016 09:59
@jayvdb @srisankethu usually they want syntax only checking
John Vandenberg
@jayvdb
Nov 10 2016 10:01
Then they want pyflakes
The only features missing are the codes that flage assigns to each error, and the noqa"
... To disable certain codes.
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 12:12
So I think we can add a status/blocked to coala/coala-bears#169 issue and I will work on PyFlakes.
Niklas
@NiklasMM
Nov 10 2016 12:32
:+1: +1
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 12:32
@NiklasMM Nice work with the JinjaBear
:)
Niklas
@NiklasMM
Nov 10 2016 12:33
Thanks! :D
Lasse Schuirmann
@sils
Nov 10 2016 12:42
oh you updated jinja2 bear
sils @sils is excited
Lasse Schuirmann
@sils
Nov 10 2016 12:46
@NiklasMM and it's up on PyPI!
:tada:
Niklas
@NiklasMM
Nov 10 2016 13:37
w0000t!
btw, what's the release schedule for coala-bears?
is there any? :D
Lasse Schuirmann
@sils
Nov 10 2016 13:39
no schedule. You can install it with --pre right now
but I was hoping to do a stable release next week of everything
coala and bears
Niklas
@NiklasMM
Nov 10 2016 13:40
yeah @srisankethu sneak that Pyflakes bear into that :smile:
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 13:41
:)
Niklas
@NiklasMM
Nov 10 2016 13:42
ermagherd! Jinja2 is not in the Readme.md :-O
Lasse Schuirmann
@sils
Nov 10 2016 13:43
wanna make another PR? ;)
Niklas
@NiklasMM
Nov 10 2016 13:44
Is it worth it? ^^
Lasse Schuirmann
@sils
Nov 10 2016 13:44
why not?
Niklas
@NiklasMM
Nov 10 2016 13:44
alright xD
anything else missing there?
Lasse Schuirmann
@sils
Nov 10 2016 13:44
don't think so
bear-docs will be updated soon
Adhityaa
@adtac
Nov 10 2016 13:48
@sils we should update bear-docs with every merge
wayyy easier :)
Lasse Schuirmann
@sils
Nov 10 2016 13:48
@adtac not sure actually :/
I'm thinking of only doing it at release time
Adhityaa
@adtac
Nov 10 2016 13:49
how about having two branches in bear-docs
and update the dev version with every merge
and master is stable
Lasse Schuirmann
@sils
Nov 10 2016 13:49
master and stable?
ok master and pre then
Adhityaa
@adtac
Nov 10 2016 13:49
yeah
Lasse Schuirmann
@sils
Nov 10 2016 13:53
so rultor can trigger it somehow
or we just do it daily or so
Adhityaa
@adtac
Nov 10 2016 13:53
@sils can you export coala-bot's or gitmate-bot's username password in the rultor_secrets.asc?
I mean export and update the key
Lasse Schuirmann
@sils
Nov 10 2016 13:53
then I'd have to redo the asc
but yeah I guess
Adhityaa
@adtac
Nov 10 2016 13:54
I'll make the PR in a minute
Lasse Schuirmann
@sils
Nov 10 2016 13:55
ok ping me when it's there
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 15:54
@jayvdb pyflakes doesn't have any arguments?
John Vandenberg
@jayvdb
Nov 10 2016 15:57
It has one env var
pyflakes_select and pyflakes_ignore you suggested?
John Vandenberg
@jayvdb
Nov 10 2016 15:59
And it is normally called using the API, which gives you access to overriding the builtins list
That is a flake8 feature
A custom severity map will suffice; a customisable severity is a perfect solution
Not sure if coala allows users to create their own map yet
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 16:02
@linter takes in the severity_map
John Vandenberg
@jayvdb
Nov 10 2016 16:02
Pyflakes has a few rules which occasionally have false positives. They should be level info, the rest are error level
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 16:03
Ok! I will make a PR on pyflakes soon :)
John Vandenberg
@jayvdb
Nov 10 2016 16:03
Unused* are info, as they dont break anything
Shadowed* are errors IMO
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 16:04
As far as I know, pyflakes does Unused imports, Undefined Elements and ..?
John Vandenberg
@jayvdb
Nov 10 2016 16:05
See pyflakes.messages from memory
There are many messages, and they dont have good inheritance to manage the severity
We do a decent job , and then we can raise a bug or PR upstream, to improve the forwards compatibility
The maintainer is fairly hard to guess where he is going with it, so having another downstream client (coala) may help me get in some api improvements
Sri Sanketh Uppalapati
@srisankethu
Nov 10 2016 16:24
@jayvdb For now I pushed a basic PR, I have my college research work to do. Can you review and tell me what more is needed?
coala/coala-bears#985