These are chat archives for coala/coala-bears

11th
Nov 2016
John Vandenberg
@jayvdb
Nov 11 2016 03:14
IMO, we should drop support for Python 2 bears. And invoke python linters inside the same runtime as coala. That solves coala/coala-bears#929
Then if anyone needs Python 2 linting, the need to invest in solving the comlexities of that issue, and ensuring we test on both Python 2 and Python 3
Python 3 linting is good for Python 2 code; it means the code is Python 3 ready, which should be the goal of all Python code now
Nobody should be writing Python 2 only code now
Lasse Schuirmann
@sils
Nov 11 2016 09:15
true, I do know though that we do have commercial users that use python 2 and haven't made the switch yet.
coala is yet another reason to switch so having bad python 2 support is better than not having python 2 support - it's like being on a trial :P
Niklas
@NiklasMM
Nov 11 2016 09:23
Uhm yeah... we do use python2... And that makes it kinda hard to adopt coala
I think neglecting python2 will alienate many potential users (unfortunately)
Lasse Schuirmann
@sils
Nov 11 2016 09:25
yep, not so much in the open source but in the commercial and research sector
companies are usually like "yeah we want to switch but it isn't high prio enough" and researchers even still depend on libs that are python 2 only, they have no idea and intention even :P
Niklas
@NiklasMM
Nov 11 2016 09:26
were now using flake8 and it seems that at the moment we can't get that functionality from coala
at least for python2
personally, I can work around that
but less involved users will be like "meh, too much work"
Lasse Schuirmann
@sils
Nov 11 2016 09:28
yep
Niklas
@NiklasMM
Nov 11 2016 11:04
oh dear guys, either I'm using it wrong or PEP8Bear needs some work
Lasse Schuirmann
@sils
Nov 11 2016 11:04
what's happening?
Niklas
@NiklasMM
Nov 11 2016 11:04
the output is not very helpfil
it just says The code does not comply to PEP8.
Niklas
@NiklasMM
Nov 11 2016 11:09
possibly a limitation of autopep8
Lasse Schuirmann
@sils
Nov 11 2016 11:10
yep it kind of is, autopep8 just gives us the corrected code and we have no idea what it corrects
Niklas
@NiklasMM
Nov 11 2016 11:10
=(
Lasse Schuirmann
@sils
Nov 11 2016 11:10
we could run it for every error class one by one
which we might need to do when we're switching to cEP 5
Niklas
@NiklasMM
Nov 11 2016 11:10
or maybe call it AutoPEP8Bear
as that's really a different tool it seems
meh, I'll go to lunch ^^
afk
Sri Sanketh Uppalapati
@srisankethu
Nov 11 2016 11:33
Yeah! The PEP8Bear does not correct all the pep8 errors
Niklas
@NiklasMM
Nov 11 2016 12:31
And autopep8 finds errors that pep8 doesn't find
Niklas
@NiklasMM
Nov 11 2016 12:49
is this how the output is supposed to look?
or is something funky going on with my terminal?
sils @sils doesn't see a thing
Niklas
@NiklasMM
Nov 11 2016 12:50
hm ok it looks better in another terminal
oh
i posted a picture
Lasse Schuirmann
@sils
Nov 11 2016 12:51
ah yeah I think that may be a pygments bug
Niklas
@NiklasMM
Nov 11 2016 12:51
ok
still, I can't use PEP8Bear like this
I need people to know whats wrong
should we have a PEP8Bear and an AutoPEPBear?
Lasse Schuirmann
@sils
Nov 11 2016 12:52
yeah, we can do that
should be easy to get pycodestyle into that
I wouldn't use the name PEP8Bear
@Udayan12167 are you around? I need to know what you did towards deprecation stuff. I want to finish that
ok @NiklasMM wanna write a PyCodestyleBear? Should be really quick
I'll go and make deprecation work, then we deprecate PEP8Bear and rename it to AutoPEP8Bear
Niklas
@NiklasMM
Nov 11 2016 12:55
neat
yeah I guess I could do that
should I open an issue?
Lasse Schuirmann
@sils
Nov 11 2016 12:58
don't care
Niklas
@NiklasMM
Nov 11 2016 12:58
:D
Niklas
@NiklasMM
Nov 11 2016 13:08
coala/coala-bears#986
@sils assign me plz?
Lasse Schuirmann
@sils
Nov 11 2016 13:09
done
Niklas
@NiklasMM
Nov 11 2016 13:09
ty
John Vandenberg
@jayvdb
Nov 11 2016 13:11
i think pycodestyle will be python 3 only soon
Lasse Schuirmann
@sils
Nov 11 2016 13:31
@NiklasMM coala/coala#2989 - you like that?
it does work
Niklas
@NiklasMM
Nov 11 2016 13:33
yeah looks cool
Lasse Schuirmann
@sils
Nov 11 2016 13:40
ok pushed the real deal with tests. Should all pass now.