These are chat archives for coala/coala-bears

14th
Dec 2016
Naveen Kumar Sangi
@nkprince007
Dec 14 2016 09:41
@jayvdb I don't understand how to fix #1112 . All the commits don't have issue related URLs right?
What is the criterion to check a commit for issue related URL?
John Vandenberg
@jayvdb
Dec 14 2016 09:44
@nkprince007 , if the commit body ends with Fixes/Closes #123, that should always be a URL instead of #123
("always" for coala org; maybe other orgs have different rules)
Naveen Kumar Sangi
@nkprince007
Dec 14 2016 09:44
Ok @jayvdb
But could we make it more generic?
John Vandenberg
@jayvdb
Dec 14 2016 09:45
I also dont have a magic answer for the larger problem, of whether all commits should include an issue link.
The coala dev team needs to decide that
i.e. do we stop being lazy, and always create an issue for every commit ?
Naveen Kumar Sangi
@nkprince007
Dec 14 2016 09:45
Thanks for the suggestion :smile: @jayvdb
Meet Mangukiya
@meetmangukiya
Dec 14 2016 09:46

i.e. do we stop being lazy, and always create an issue for every commit ?

I thought we already did that :/

John Vandenberg
@jayvdb
Dec 14 2016 09:47
well, it is a general rule, but .. we dont abide by it always
Lasse Schuirmann
@sils
Dec 14 2016 09:47
well if I do a refactoring I usually don't wanna have an issue per commit
John Vandenberg
@jayvdb
Dec 14 2016 09:47
nod. the maintainers are the usual people violating this general rule ;-)
Lasse Schuirmann
@sils
Dec 14 2016 09:48
certainly ;)
John Vandenberg
@jayvdb
Dec 14 2016 09:48
myself included a few times
as GitCommitBear is always looking at the top commit in CI, it will only check that one has an issue.
gitmate however ... :/
Meet Mangukiya
@meetmangukiya
Dec 14 2016 09:50
I've chosen precise in Circle but still uses trusty in packages :/
John Vandenberg
@jayvdb
Dec 14 2016 09:51
uses trusty in packages - what does this mean?
Meet Mangukiya
@meetmangukiya
Dec 14 2016 09:52
Similar to this
Get:10 http://archive.ubuntu.com trusty-updates/universe Sources [214 kB]
John Vandenberg
@jayvdb
Dec 14 2016 09:52
have you looked at the CircleCI coala/coala builds ?
do they also have that line ?
Meet Mangukiya
@meetmangukiya
Dec 14 2016 09:53
I haven't
meetmangukiya @meetmangukiya looks
Meet Mangukiya
@meetmangukiya
Dec 14 2016 09:54
No, they have precise
Get:23 http://security.ubuntu.com precise-security/restricted amd64 Packages [10.8 kB]
John Vandenberg
@jayvdb
Dec 14 2016 09:55
have you pushed a new commit to your repo , after you changed to using precise?
Meet Mangukiya
@meetmangukiya
Dec 14 2016 09:55
No, just hit the rebuild button
John Vandenberg
@jayvdb
Dec 14 2016 09:56
It explicitly says hitting the rebuild button will not work
Meet Mangukiya
@meetmangukiya
Dec 14 2016 09:56
:sweat:
Sorry :(