These are chat archives for coala/coala-bears

15th
Dec 2016
Naveen Kumar Sangi
@nkprince007
Dec 15 2016 01:18
@/all could someone review #1115 again?
I've made some changes
And I wrote down the tests too.
John Vandenberg
@jayvdb
Dec 15 2016 01:54
looking good
Green Travis bear builds - PR'd. Off to work I go.
John Vandenberg
@jayvdb
Dec 15 2016 02:00
@dracarys09, after uploading, you should look at your patch again online, so you can see and fix silly mistakes quickly.
Naveen Kumar Sangi
@nkprince007
Dec 15 2016 04:32
@jayvdb could you suggest how many of the bitbucket keywords do we need to support. Check here
Naveen Kumar Sangi
@nkprince007
Dec 15 2016 04:48
So, we don't support bitbucket issue tracking, right?
John Vandenberg
@jayvdb
Dec 15 2016 04:48
Your issue is about URLs, and bitbucket doesnt support them.
Could you do some analysis of GitLab
we do want to support GitLab properly
Naveen Kumar Sangi
@nkprince007
Dec 15 2016 04:49
Yup, I've seen it.
Just need to add ing ending words
Any other hosts we need to take care of?
John Vandenberg
@jayvdb
Dec 15 2016 05:14
Launchpad) has git in beta
SourceForge ?
Abhijeet Dubey
@dracarys09
Dec 15 2016 09:15
@jayvdb when you reviewed coala/coala-bears#1116 you mentioned there is one extra commit in my patch
actually that was the first newcomer issue I solved
and I did that in master branch itself
since then it is present in PR for coala/coala-bears#1106 as well
how can I get rid of that specific commit from this PR ?
Niklas
@NiklasMM
Dec 15 2016 09:17
rebase your branch
on the current state of the branch to PR aims at
*the PR
Abhijeet Dubey
@dracarys09
Dec 15 2016 09:19
I wanted to remove the first commit from my PR I made (that was in master branch)
rest all the commits I want to keep (they are in different branch) for this PR
Niklas
@NiklasMM
Dec 15 2016 09:21
hmm not entirely sure what's going on
but you could use rebase -i and then drop the commits you don't want
be careful though. if they are not on any other branch, you might lose them
Abhijeet Dubey
@dracarys09
Dec 15 2016 09:25
I did git rebase -i HEAD~6
and removed the 1st commit
I think that is it right ?
Niklas
@NiklasMM
Dec 15 2016 09:26
yeah makes sense
Abhijeet Dubey
@dracarys09
Dec 15 2016 09:26
how to reflect these changes in PR ?
Niklas
@NiklasMM
Dec 15 2016 09:26
push
-f
Abhijeet Dubey
@dracarys09
Dec 15 2016 09:27
yes
thanks a lot
Niklas
@NiklasMM
Dec 15 2016 09:28
np
Naveen Kumar Sangi
@nkprince007
Dec 15 2016 09:33
Ok, will work on them both tomorrow @jayvdb, I've got an exam tomorrow
John Vandenberg
@jayvdb
Dec 15 2016 13:18
Could coala/coala-bears#1130 be reviewed pls. I need to rebase other work on top of it when merged.
Also coala/coala-bears#1129 unmerged is slowing down my travis build work
But 1130 is the priority item
John Vandenberg
@jayvdb
Dec 15 2016 14:11
We have a bunch of unmerged approved PRs from the CircleCI bustage, like coala/coala-bears#1105 . Is someone already preparing to push them? If not, I can do that.
mixih
@Mixih
Dec 15 2016 14:27
@jayvdb I acked the first pull you made