These are chat archives for coala/coala-bears

16th
Dec 2016
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 10:32
@Mixih circle build says not running Look here
Help me out here
Meet Mangukiya
@meetmangukiya
Dec 16 2016 10:33
@nkprince007 it is queued behind other builds
You are 3rd in queue as I see ;)
Its gonna take some while
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 10:33
Ok, where do I see the position stats?
Yup, I see it now..
TY @meetmangukiya
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 11:31
@meetmangukiya @jayvdb could you review my PR?
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 14:34
@sils, do you want me to change the fields to let the users specify the regexp?
Lasse Schuirmann
@sils
Dec 16 2016 14:35
what is this about?
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 14:35
GitCommitBear
#1115
Lasse Schuirmann
@sils
Dec 16 2016 14:39
why regex?
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 14:41
Because that'd be easier to match the URL with.
@jayvdb what do you suggest?
Lasse Schuirmann
@sils
Dec 16 2016 14:45
a regex is complicated
let them do a list of globs?
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 14:45
@sils as in ?
Lasse Schuirmann
@sils
Dec 16 2016 14:46
maybe list of regex is cool
so the user would give like (Closes|Fixes) https://github.com/.* or so?
John Vandenberg
@jayvdb
Dec 16 2016 14:46
what is an example of a URL which a glob isnt good enough
Lasse Schuirmann
@sils
Dec 16 2016 14:47
yeah I do think a glob is simpler
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 14:48
That's fine, I guess..
John Vandenberg
@jayvdb
Dec 16 2016 14:49
I think keeping the github/gitlab actual rules is important
and should be automatically detected, using .git/config
that should be the default
and then someone can activate a more specific pattern if they want to
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 14:51
Yeah, but I don't think the Git VCS actually supports a configuration of that sort..
It's just the Git Hosts which're actually implementing it in the way they wish.
John Vandenberg
@jayvdb
Dec 16 2016 14:54
correct, but from .git/config we know which hosts are being used (maybe that detection is a follow up task), and can default to the appropriate rules
and 90% of repos are hosted on github/gitlab/bitbucket
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 14:56
Yeah, but then again for URL matching, what do we do? Should we be asking the user for keywords? Since every repository has it's own requirements, like in our case we want the full URL. But in some repos, they just want you to add the issue#
John Vandenberg
@jayvdb
Dec 16 2016 14:58
if we have auto-voodoo for github/gitlab/bitkeeper , then IMO we should have a regex override setting, as only advanced users would use it, and they will be happier with a regex instead of a glob
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 15:00
That's much better @jayvdb
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 15:38

To do list for GitCommitBear

Use .git/config for host spec
Allow configuration with regexp for URL matching
Fix the docstring
Rewrite tests

Is that it, as of now @jayvdb
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 21:09
@jayvdb but use of .git/config needs to fetch the type of host based on url, this means that we'd require two shell commands to be run everytime, is this advisable?
@Mixih what do you suggest?
mixih
@Mixih
Dec 16 2016 21:12
hmm? for what?
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 21:13
As @jayvdb suggested to implement the use of .git/config to know about the git host used.
mixih
@Mixih
Dec 16 2016 21:14
use time on a test script to check performance :P
if it's negligible (<2sec), go for it
most bash commands have negiligable performance inpact anyways
Naveen Kumar Sangi
@nkprince007
Dec 16 2016 21:16
Ok. @Mixih