These are chat archives for coala/coala-bears

19th
Dec 2016
John Vandenberg
@jayvdb
Dec 19 2016 02:27
done
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 02:30
Sure @jayvdb
Do I have to worry about the change @dracarys09 suggested?
John Vandenberg
@jayvdb
Dec 19 2016 02:33
yes
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 02:35
Okay, but, regexp was only added to allow users with full configuration, right? Then why do we need to add another layer of security over it?
Also regexp always need not be numbers, right?
John Vandenberg
@jayvdb
Dec 19 2016 02:38
I think he is only asking you to make your test regex more precise
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 02:38
Okay.
BTW, what do you mean git config get-all? @jayvdb
John Vandenberg
@jayvdb
Dec 19 2016 02:39
you use get-regex . but you are not providing a regex.
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 02:40
url is the regex
John Vandenberg
@jayvdb
Dec 19 2016 02:40
url does not include any regex syntax
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 02:40
url is itself the regex for remotes
John Vandenberg
@jayvdb
Dec 19 2016 02:41
hmm
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 02:41
Consider here
[core]
    repositoryformatversion = 0
    filemode = true
    bare = false
    logallrefupdates = true
[remote "origin"]
    url = https://github.com/nkprince007/coala-bears.git
    fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
    remote = origin
    merge = refs/heads/master
[remote "main"]
    url = https://github.com/coala/coala-bears.git
    fetch = +refs/heads/*:refs/remotes/main/*
[branch "test"]
    remote = origin
    merge = refs/heads/test
[gitg]
    mainline = refs/heads/master
url marks the regular expression
John Vandenberg
@jayvdb
Dec 19 2016 02:42
nod. ive noted on the PR that I was wrong
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 02:43
Ok. Thanks :smile:
Muhammad Kaisar Arkhan
@yukiisbored
Dec 19 2016 03:04
[ERROR][10:00:11] There is a conflict in the version of a dependency you have installed and the requirements of coala. This may be resolved by creating a separate virtual environment for coala or running `pip install "libclang-py3==0.2"`. Be aware that the latter solution might break other python packages that depend on the currently installed version.

after installing libclang-py3==0.2

[ERROR][10:01:38] There is a conflict in the version of a dependency you have installed and the requirements of coala. This may be resolved by creating a separate virtual environment for coala or running `pip install "libclang-py3~=3.4.0"`. Be aware that the latter solution might break other python packages that depend on the currently installed version.

what's going on?

John Vandenberg
@jayvdb
Dec 19 2016 03:08
We need libclang-py3-3.4 iirc
see recent commits to requirements.txt
Muhammad Kaisar Arkhan
@yukiisbored
Dec 19 2016 03:15
(venv) yuki@matsuoka ~/venv $ pip3 install libclang-py3==3.4
Requirement already satisfied: libclang-py3==3.4 in /home/yuki/venv/lib/python3.5/site-packages
John Vandenberg
@jayvdb
Dec 19 2016 03:20
create a new venv ? it should work. then we need to investigate how your other venv is busted , and try to prevent that happening to other people
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 03:20
@jayvdb worked on the changes. Pushed moments ago. #1112
John Vandenberg
@jayvdb
Dec 19 2016 03:31
let me know when the build passes :P
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 03:31
Ok.
Muhammad Kaisar Arkhan
@yukiisbored
Dec 19 2016 03:37
same problem occured, I installed coala with pip3 install coala-bears --pre btw.
[ERROR][10:36:52] There is a conflict in the version of a dependency you have installed and the requirements of coala. This may be resolved by creating a separate virtual environment for coala or running `pip install "libclang-py3~=3.4.0"`. Be aware that the latter solution might break other python packages that depend on the currently installed version.
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 03:38
CI Build success on #1112 @jayvdb
John Vandenberg
@jayvdb
Dec 19 2016 04:01
@nkprince007 , ive reviewed it. please dont take the "bad design" comment personally -- we've all been designing it with you, and it is a "design by committee" problem - the result isnt pretty
@yukiisbored, that error is in a brand new venv? if so what setuptools is in that venv ?
Muhammad Kaisar Arkhan
@yukiisbored
Dec 19 2016 04:03
(new-venv) yuki@matsuoka ~ $ pip3 show setuptools 
Name: setuptools
Version: 32.1.2
Summary: Easily download, build, install, upgrade, and uninstall Python packages
Home-page: https://github.com/pypa/setuptools
Author: Python Packaging Authority
Author-email: distutils-sig@python.org
License: UNKNOWN
Location: /home/yuki/new-venv/lib/python3.5/site-packages
Requires:
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 04:12

@jayvdb, I'm very confused by the latter comment, I don't understand how to proceed. :worried:

Yeah, the variables need renaming, I understand that. I myself got confused a couple of times.
About cyclomatic complexity, yeah, that's for sure, it looks crappy.
But about the settings, right now, if we disable keyword_regex, it checks for presence of full URLs.
And also, upon enabling issue_checks, if we still set the keyword_regex in a correct manner. eg: (Fixes|Closes|Resolves\s+#[1-9][0-9]*) should check for miniaturized urls

Do we need to make the default second option as miniaturized urls?
BTW, for naming convention, it'd be better if we had a poll, since I couldn't conjure up a name that looks pretty enough about the issue mentioned #1112
John Vandenberg
@jayvdb
Dec 19 2016 04:16
the settings have multiple uses
It should be easy to require "(Fixes|Closes|...) <issue url>"
without touching the regex setting
'pretty' doesnt refer to setting names; it refers to the overall design.
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 04:20
Coming to the design, I was only making changes as everyone suggested, right? I haven't fabricated any of them.
If the issue only meant to change between the two settings, it wouldn't have taken this crazy shape, I suspect.
Please do suggest the names for settings.
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 04:26

And about

It should be easy to require "(Fixes|Closes|...) <issue url>"

It would be better if we had more insight into this;
How can we proceed without some information on the pattern?
This arbitrary line could mean a lot of things, right?

John Vandenberg
@jayvdb
Dec 19 2016 04:27
yes, you were doing as everyone told you ;-) which is why I say dont take it personally
we'll assign you to review the PR of coala/coala-bears#1134 , so think about that now ;-)
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 04:29
"Fixes|Closes|..." seems easy to be understood, but brewing up some pattern from it needs to be done, right?
John Vandenberg
@jayvdb
Dec 19 2016 04:29
I think you need to add a setting for auto-host detection, and another for requiring a URL, and another for a regex.
and the regex overrides the other two
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 04:29
Ok. And what about the names for the settings?
I'm not good with names @jayvdb. I'm pretty sure about it.
Muhammad Kaisar Arkhan
@yukiisbored
Dec 19 2016 04:30
I've uninstalled coala from my host python thing
and it works!
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 04:33
@jayvdb how about, we let loose of requiring a URL as boolean, to ask users to mention short reference or full reference as a string?
Okay, that seems to be addressed in a different issue as a follow up.
John Vandenberg
@jayvdb
Dec 19 2016 04:48
@yukiisbored , so there was a coala in your host, and the venv installation of clang-py failed because of it? do you have venv configured to inherit system packages?
Muhammad Kaisar Arkhan
@yukiisbored
Dec 19 2016 04:48
@jayvdb For the first question, I think so. I have no idea about the last one though because I just installed virtualenv and use the default configs
John Vandenberg
@jayvdb
Dec 19 2016 04:49
nod
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 05:43
@jayvdb Should we be having another setting for enabling "#<issue no>"?
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 06:04
I tried a fix @jayvdb, could you review it once the build is done?
John Vandenberg
@jayvdb
Dec 19 2016 09:11
@yukiisbored , can you roughly describe your clang-py problem at coala/coala#3339 - i.e. the steps you took, and errors you saw, and the setuptools version as you reported it earlier here.
Muhammad Kaisar Arkhan
@yukiisbored
Dec 19 2016 16:12
@jayvdb
Sure, I was installing coala-bears on my host and it says "There is a conflict in the version of a dependency you have installed and the requirements of coala" and it requires libclang-py3==0.2. So, I've installed it on my host and now it wants libclang-py3==3.4. Because of that, I created a new virtualenv and use that instead but it has the same result. So, I uninstalled coala and coala-bears from my host and now the virtualenv works.
John Vandenberg
@jayvdb
Dec 19 2016 23:10
@yukiisbored , could you paste that excellent description into a comment on coala/coala#3339 . Thx
Naveen Kumar Sangi
@nkprince007
Dec 19 2016 23:42
@jayvdb Thanks for the comment on the issue #1112
Hope it gets reviewed quick