These are chat archives for coala/coala-bears

22nd
Dec 2016
Muhammad Kaisar Arkhan
@yukiisbored
Dec 22 2016 05:44
John Vandenberg
@jayvdb
Dec 22 2016 05:46
eh? tailor passes? what is your question?
Muhammad Kaisar Arkhan
@yukiisbored
Dec 22 2016 05:47
wait? no, tailor fails. I have no idea what's going on with it. On my fork, btw.
John Vandenberg
@jayvdb
Dec 22 2016 05:50
I clicked ^ above. it is working
Muhammad Kaisar Arkhan
@yukiisbored
Dec 22 2016 06:25
anyway, I'm trying out Arch Linux for this :P
Naveen Kumar Sangi
@nkprince007
Dec 22 2016 16:12
@/all please share your opinions on my PR, please. https://github.com/coala/coala-bears/issues/1112#issuecomment-267953755
Mischa Krüger
@Makman2
Dec 22 2016 16:14
@nkprince007 on it :+1:
Meet Mangukiya
@meetmangukiya
Dec 22 2016 16:15
Does coala use 8 spaces or 4 spaces for hanging indents?
Mischa Krüger
@Makman2
Dec 22 2016 16:15
4 spaces
8 spaces only if the alignment would clash with the following block, e.g. for these cases
if (x == 1 or
    x == 2)
    # this looks bad
if (x == 1 or
        x == 2)
    # this looks better (more or less)
Meet Mangukiya
@meetmangukiya
Dec 22 2016 16:17
ok
Mischa Krüger
@Makman2
Dec 22 2016 16:54
@nkprince007 alright reviewed :+1:
Naveen Kumar Sangi
@nkprince007
Dec 22 2016 16:57
Tysm @Makman2
mixih
@Mixih
Dec 22 2016 16:57
@Makman2, how does coala handle intra-file ignores? does it pass it to the bear? OR does it just remove it form the file dict?
Mischa Krüger
@Makman2
Dec 22 2016 17:00
@nkprince007 sure :)
@Mixih no bears don't see anything from the ignores (except the ignore stmts in the files)
we postprocess results
so we acquire ranges which shall be ignored (by looking at start ignore xxx or now noqa)
then we let the bear run normally
mixih
@Mixih
Dec 22 2016 17:01
so, it's removed from the file dict... ah
Mischa Krüger
@Makman2
Dec 22 2016 17:01
and then we check each result
no it's not
mixih
@Mixih
Dec 22 2016 17:01
oh, the results for that line are removed then?
Mischa Krüger
@Makman2
Dec 22 2016 17:01
if we would do so we could loose context for the bears which is bad
mixih
@Mixih
Dec 22 2016 17:01
I see
Mischa Krüger
@Makman2
Dec 22 2016 17:01
yes exactly
results have a range
and then we just compare with each range we have in our ignore-list
mixih
@Mixih
Dec 22 2016 17:02
I see...
Mischa Krüger
@Makman2
Dec 22 2016 17:02
and if they overlap, we remove the range
ehh I mean the result :3
mixih
@Mixih
Dec 22 2016 17:02
Thanks
Mischa Krüger
@Makman2
Dec 22 2016 17:02
:+1: :)
mixih
@Mixih
Dec 22 2016 17:02
Guess, I didn't read that part of core yet :)
Mischa Krüger
@Makman2
Dec 22 2016 17:03
don't read the current core, it's awful
that's why I code a new one ;P
mixih
@Mixih
Dec 22 2016 17:04
I should start reading that as I'll need to review it soon shouldn't I....
Mischa Krüger
@Makman2
Dec 22 2016 17:04
I remove the current core more or less, so if you want to... :P
mixih
@Mixih
Dec 22 2016 17:05
oh no.... and I was just beginning to understand how everything fit together in current core xD
Mischa Krüger
@Makman2
Dec 22 2016 17:05
doesn't harm, but stuff gets simplified in the new core :P
currently it's really a mess
mixih
@Mixih
Dec 22 2016 17:05
it was a little confusing.. there were parts everywhere
thank god for reference tracking I added to my text editor
Mischa Krüger
@Makman2
Dec 22 2016 17:06
:P