These are chat archives for coala/coala-bears

30th
Dec 2016
euleram
@vijeth-aradhya
Dec 30 2016 00:08
Guys please check out PR #1223 - Added a new bear! :)
John Vandenberg
@jayvdb
Dec 30 2016 00:22
coala/coala-bears#1204 - the old setting names were not deprecated -- this is a breaking change
Lasse Schuirmann
@sils
Dec 30 2016 00:23
@jayvdb how do you mean? That's what that deprecate decorator is for right?
John Vandenberg
@jayvdb
Dec 30 2016 00:24
oh yes. i see it
Lasse Schuirmann
@sils
Dec 30 2016 00:24
anything wrong with that?
John Vandenberg
@jayvdb
Dec 30 2016 00:24
sorry .. still getting coffee levels up to normal
Lasse Schuirmann
@sils
Dec 30 2016 00:25
ah ok no issue
@jayvdb gotta go, can you merge coala/coala#3429 for me in like 15 mins when the build passes?
good night everyone :)
John Vandenberg
@jayvdb
Dec 30 2016 00:28
the addition of "remark-lint": ">=5.1.0", is a bit confusing ... have we also solved coala/coala-bears#926 ?
Naveen Kumar Sangi
@nkprince007
Dec 30 2016 00:40
@jayvdb Is #1115 okay?
euleram
@vijeth-aradhya
Dec 30 2016 10:25
Why does GitCommitBear fail on my machine? Is there a problem with that bear?
Lasse Schuirmann
@sils
Dec 30 2016 10:25
define "fail", command, output
euleram
@vijeth-aradhya
Dec 30 2016 10:32
There's a commit not in imperative mood as well :/
Lasse Schuirmann
@sils
Dec 30 2016 10:33
I'm pretty sure if you read the error and follow the instructions it'll work
but still it should autoskip the test :/
euleram
@vijeth-aradhya
Dec 30 2016 10:33
Yeah I was thinking the same
I wanted to know why CircleCI and Travis were failing in my PR ..
Lasse Schuirmann
@sils
Dec 30 2016 10:33
oh it's on the CI?
euleram
@vijeth-aradhya
Dec 30 2016 10:35
No on on my local machine only ^^ I just checked the tests to make sure none of the things I added were failing on my local machine
#1223 Here it's failing <
euleram
@vijeth-aradhya
Dec 30 2016 10:44
tests/haskell/GhcModBearTest.py ss
shows success on travis ^ but 93%?!
bears/haskell/GhcModBear.py 12 1 2 0 93% 28
Lasse Schuirmann
@sils
Dec 30 2016 10:46
test coverage missing
euleram
@vijeth-aradhya
Dec 30 2016 10:49
Oh thanks! does that mean I have to add more tests?
I have added 3 good files and 3 bad files for good enough syntax checks
here they are
Lasse Schuirmann
@sils
Dec 30 2016 10:52
well if coverage is 93% there's something missing
and that's probably line 28 or so
it tells you which branches are missing
euleram
@vijeth-aradhya
Dec 30 2016 10:58
branches? I'm sorry I'm new to debugging from CI.
I'm trying to find docs on how to debug and what exactly is missing.
Lasse Schuirmann
@sils
Dec 30 2016 10:58
line 28 isn't executed in any of your tests
that's all it tells you
euleram
@vijeth-aradhya
Dec 30 2016 11:00
Right. And line 28 is the return statement of create_arguments :sweat_smile:
Lasse Schuirmann
@sils
Dec 30 2016 11:01
so something must be seriously wrong, right?
euleram
@vijeth-aradhya
Dec 30 2016 11:01
Yeahh I
Lasse Schuirmann
@sils
Dec 30 2016 11:01
you can check locally btw. with py.test -k GhcMod --cov bears/haskell/GhcModBear.py
euleram
@vijeth-aradhya
Dec 30 2016 11:01
I'll look at this a bit later :smile: .. gtg
Yeah thanks a lot! :smile:
Lasse Schuirmann
@sils
Dec 30 2016 11:02
tests/haskell/GhcModBearTest.py ss
your tests are skipped on the CI
probably because the tool you use isn't installed on the CI
:tada:
euleram
@vijeth-aradhya
Dec 30 2016 11:02
Yeah oh s is for skip? :P
Right. I dont think Haskell related tools will be installed anyways xD
Lasse Schuirmann
@sils
Dec 30 2016 11:03
so you gotta install it on ci
euleram
@vijeth-aradhya
Dec 30 2016 11:03
Yeah it shows 100% on my local machine
Ok I'll do that ^^ I gtg now :sweat_smile: I'll ask here if I have doubts on installing it :smile:
Thanks a lot!
euleram
@vijeth-aradhya
Dec 30 2016 19:06
@Mixih CircleCI is failing, TravisCI is fine now :|
mixih
@Mixih
Dec 30 2016 19:06
hmm? which one?
euleram
@vijeth-aradhya
Dec 30 2016 19:06
I'll use the skipDecorator and check
mixih
@Mixih
Dec 30 2016 19:06
skip decorator mean you need a test class
which is a different way of doing things than what you have there
euleram
@vijeth-aradhya
Dec 30 2016 19:07
I dont understand Travis can get the dependency installed but Circle cant :/
mixih
@Mixih
Dec 30 2016 19:07
FYI
linky?
Rishav Kumar
@aptrishu
Dec 30 2016 19:07
link?
:P
euleram
@vijeth-aradhya
Dec 30 2016 19:08
CircleCI output
Pull #1223
Oh wait I just pushed, it's pending
mixih
@Mixih
Dec 30 2016 19:10
nvm, skip decorator may nto be the way to go here
euleram
@vijeth-aradhya
Dec 30 2016 19:10
oh
Okay wait it's not installing in both
Let me get it installed
mixih
@Mixih
Dec 30 2016 19:12
alright, you gotta fix the install then
mixih
@Mixih
Dec 30 2016 19:18
you need to install it through cabal it seems
euleram
@vijeth-aradhya
Dec 30 2016 19:24
yeah cabal is the default package installer for haskell
mixih
@Mixih
Dec 30 2016 19:25
but there is an apt package
euleram
@vijeth-aradhya
Dec 30 2016 19:25
you can do that with sudo apt-get as well if im not wrong
yeah so
mixih
@Mixih
Dec 30 2016 19:25
but it's not working....
euleram
@vijeth-aradhya
Dec 30 2016 19:25
that's easier right
hmm i'll check it out for some more time :+1:
euleram
@vijeth-aradhya
Dec 30 2016 19:32
I tried adding a few dependencies first as well, but still failing :3 hmm I wonder why it's skipping the tests still - there has to be some reason
euleram
@vijeth-aradhya
Dec 30 2016 22:41
Ok
travisci passes with ghc-mod apt package, but circleci fails :/ Is it missing some dependency or something :|
I tried putting all haskell related apt packages which was there in .travis.yml in deps.sh CircleCI still fails
sils @sils votes for dumping circleci or travis CI... though shalt not maintain redundant CI builds.
euleram
@vijeth-aradhya
Dec 30 2016 23:06
It doesnt skip, the tests fail so. But in Travis, it passes. So any ideas where it could have gone wrong. :) #1223
Lasse Schuirmann
@sils
Dec 30 2016 23:08
there's a dependency problem on circle... weird
euleram
@vijeth-aradhya
Dec 30 2016 23:13
Yeah I need to figure out why the tests fail :/ basically ghc-modis found and run, but isn't giving the right results in circle
euleram
@vijeth-aradhya
Dec 30 2016 23:20
Hey can I be promoted to developer as well? :D
Issues : coala/coala-bears#1195, coala/coala#3355
Reviews : coala/coala#3414 , coala/coala-bears#1222
Lasse Schuirmann
@sils
Dec 30 2016 23:27
there's also a submisson to coala.io/usability
you're all set indeed!
cobot inv @vijeth-aradhya to developers
coala-bot
@coala-bot
Dec 30 2016 23:27
Welcome @vijeth-aradhya, you are a part of developers team now! :tada: We hope to see more of you!
Lasse Schuirmann
@sils
Dec 30 2016 23:27
Congrats and welcome! :)
euleram
@vijeth-aradhya
Dec 30 2016 23:28
Yay! :smile: It feels great to be part of such a nice and helpful community! thanks a lot ppl
Mischa Krüger
@Makman2
Dec 30 2016 23:29
:tada: welcome :tada: