These are chat archives for coala/coala-bears

4th
Jan 2017
euleram
@vijeth-aradhya
Jan 04 2017 05:18
@sils The tests look good now!! :)
Lasse Schuirmann
@sils
Jan 04 2017 07:40
:+1: thanks @vijeth-aradhya
euleram
@vijeth-aradhya
Jan 04 2017 17:58
Guys can we merge #1223 yet? Are there any final modifications? :)
mixih
@Mixih
Jan 04 2017 17:59
I'd like to see that removal comment if we can kill it off if we upgrade circle....
euleram
@vijeth-aradhya
Jan 04 2017 17:59
Ahh yes, can i know the upgrade details?
mixih
@Mixih
Jan 04 2017 18:00
I don't know, @jayvdb is working on hat circle stuff
talk to him if you need more info :)
euleram
@vijeth-aradhya
Jan 04 2017 18:00
oh
is it gonna be ubuntu-14.04?
mixih
@Mixih
Jan 04 2017 18:00
ya
euleram
@vijeth-aradhya
Jan 04 2017 18:00
that sounds good :)
we could just add ghc-mod to the deps list after the update .. otherwise this method works ..
shall i add that info ^^ in the comment
euleram
@vijeth-aradhya
Jan 04 2017 18:23
Done :+1:
John Vandenberg
@jayvdb
Jan 04 2017 18:23
ok, reviewing now
John Vandenberg
@jayvdb
Jan 04 2017 18:46
@vijeth-aradhya , what is the minimum acceptable version of ghc-mod ?
euleram
@vijeth-aradhya
Jan 04 2017 18:49
3.4.* will do I guess (right now that's we do for circle and travis has a similar version as well)
John Vandenberg
@jayvdb
Jan 04 2017 18:50
trusty has 3.1.4
and you are installing 3.1.4 into circle
euleram
@vijeth-aradhya
Jan 04 2017 18:52
oh yeah sorry typo
John Vandenberg
@jayvdb
Jan 04 2017 18:52
how bad is 1.0.5 , which is provided by precise ?
euleram
@vijeth-aradhya
Jan 04 2017 18:52
3.1.*
it wasn't giving any results properly ^^
also it might be because it's compiler (ghc) was in a lower version or higher version (not compatible with it) - possible reason
John Vandenberg
@jayvdb
Jan 04 2017 19:02
why are you using DistributionRequirement instead of CabalRequirement ?
euleram
@vijeth-aradhya
Jan 04 2017 19:07
we are not using cabal to install the packages right
we are only using apt package
since ghc-mod can be installed by apt as well, i thought it's good to use DistributionRequirement
did anything change in ci?
travis is failing unusually
The command "pip install -r requirements.txt" failed and exited with 1 during .
Arjun Nemani
@nemaniarjun
Jan 04 2017 19:24
See the error above it?
I dont think we have used it yet, but we should be using it. And it allows a version to be specified
euleram
@vijeth-aradhya
Jan 04 2017 20:12
yes we can use it - even hlint uses apt now - we could change it to cabal :+1:
this is new - I hadn't seen this in dependency_management before
mixih
@Mixih
Jan 04 2017 21:47
well, we did split it out recently
which would mean that it has gotten some love recently :)