These are chat archives for coala/coala-bears

12th
Jan 2017
euleram
@vijeth-aradhya
Jan 12 2017 04:03 UTC
@sils I don't want to push you (I understand I have to wait for my PR to be reviewed) but it'd be great if you had a final look at the GhcModBear PR.. I'd love to work on other things as well.. :)
John Vandenberg
@jayvdb
Jan 12 2017 04:20 UTC
@incorrectusername , are you a GCI participant?
Yogesh Gupta
@incorrectusername
Jan 12 2017 06:41 UTC
@jayvdb No but I'm interested in gsoc.
John Vandenberg
@jayvdb
Jan 12 2017 06:43 UTC
ah ok. ;-)
Yogesh Gupta
@incorrectusername
Jan 12 2017 06:55 UTC
coala is taking part in gsoc ?
John Vandenberg
@jayvdb
Jan 12 2017 06:56 UTC
I expect so
Yogesh Gupta
@incorrectusername
Jan 12 2017 06:57 UTC
nice :smile:
euleram
@vijeth-aradhya
Jan 12 2017 08:31 UTC
@sils '. ' is the separator. Remember there was no space between msg in the previous thing. (So this is the separator now)
Lasse Schuirmann
@sils
Jan 12 2017 08:31 UTC
@vijeth-aradhya ok you need a rebase anyway, can you put a comment there and link to the issue you filed?
euleram
@vijeth-aradhya
Jan 12 2017 08:39 UTC
It was made purposely to suit integration with Emacs (wasn't really a bug). So for the separator, we need to use '-b'.
So is it necessary to link the issue?
I rebased and pushed it day befkre
Lasse Schuirmann
@sils
Jan 12 2017 08:40 UTC
make it a habit to rebase whenever you change something
it might sound tedious but rebasing takes mere seconds
we need the CI to rerun again
euleram
@vijeth-aradhya
Jan 12 2017 08:42 UTC
Alright :)
Thanks a lot!! :smiley:
Lasse Schuirmann
@sils
Jan 12 2017 08:45 UTC
without the rebase master could break due to logical issues
euleram
@vijeth-aradhya
Jan 12 2017 08:46 UTC
Yes I understand, I'll rebase as soon as I can get my hands on my laptop :)
Lasse Schuirmann
@sils
Jan 12 2017 08:47 UTC
but the comment is actually important otherwise someone will come and remove that thing without noticing
euleram
@vijeth-aradhya
Jan 12 2017 08:50 UTC
Hmm makes sense, I'll write explicitly about the usage as well and link the issue :+1:
Robin Saleh-Jan
@robinsjdotcom
Jan 12 2017 10:01 UTC
If my linter depends on a specific language/dependency to be available, should I add it to the .yml file?
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Jan 12 2017 11:21 UTC
@robinsjdotcom yeah, so that the CI installs it too
Robin Saleh-Jan
@robinsjdotcom
Jan 12 2017 11:22 UTC
@Adrianzatreanu Cool :)
Shruti Sharma
@shrutishrm512
Jan 12 2017 12:37 UTC
there is any link to get better understanding of Annotation bear?
Robin Saleh-Jan
@robinsjdotcom
Jan 12 2017 13:29 UTC
@shrutishrm512 Read the implementation of Annotation bear and if you don't understand parts of it either google it or check the coala/coala-bear docs.
Shruti Sharma
@shrutishrm512
Jan 12 2017 14:35 UTC
okay! thanks @robinsjdotcom
euleram
@vijeth-aradhya
Jan 12 2017 17:39 UTC
@sils Do I have to add a test for the separator? :no_mouth:
euleram
@vijeth-aradhya
Jan 12 2017 17:44 UTC
IMHO I think it's fine now :+1: Anything else to change? :)
Lasse Schuirmann
@sils
Jan 12 2017 20:56 UTC
@vijeth-aradhya I feel if we don't have a test someone might remove the argument, you could just modify your test to capture that missing space thingy as well right?
euleram
@vijeth-aradhya
Jan 12 2017 20:57 UTC
Hmm alright I'll look into it :+1:
Robin Saleh-Jan
@robinsjdotcom
Jan 12 2017 21:56 UTC

Anyone that can give me suggestions to increase test coverage? The code can be found here: coala/coala-bears#1291

Current coverage is at 30 %