These are chat archives for coala/coala-bears

13th
Jan 2017
Naveen Kumar Sangi
@nkprince007
Jan 13 2017 00:38
@Makman2 need your replies on comments in coala/coala-bears#1115
Mischa Krüger
@Makman2
Jan 13 2017 00:39
@nkprince007 on it
:+1:
Mischa Krüger
@Makman2
Jan 13 2017 00:49
@nkprince007 commented again, I'm off for today, so next review will take a while
Naveen Kumar Sangi
@nkprince007
Jan 13 2017 00:49
Ok. :smile:
Mischa Krüger
@Makman2
Jan 13 2017 00:49
especially I don't have really time tomorrow :/
maybe I get 1-2 hours together :+1:
alright cya :)
euleram
@vijeth-aradhya
Jan 13 2017 07:02
@sils I remember reading off here that the deprecation for change_line arg will be after 16th Jan or somrthing - please correct me if I'm wrong!
I remember that's why I stopped working on that as well
:thought_balloon:
Lasse Schuirmann
@sils
Jan 13 2017 07:03
I have no idea :P
euleram
@vijeth-aradhya
Jan 13 2017 07:04
Hows coala_utils version update going btw :O
Lasse Schuirmann
@sils
Jan 13 2017 07:05
@vijeth-aradhya it's done, I already told you?
isn't it?
euleram
@vijeth-aradhya
Jan 13 2017 07:05
Oh :O I thought there was one more PR to change coala version right
in gitlab
because that required a previous dependency version
Lasse Schuirmann
@sils
Jan 13 2017 07:07
coala-utils and dependency-management have both been updated and released, we need to still update the latter version in coala
but overall the releases have been done you should be able to just use it
euleram
@vijeth-aradhya
Jan 13 2017 07:08
Oh alright then :smiley: :+1:
@sils Did you check out the comment on GhcModBear?!
Lasse Schuirmann
@sils
Jan 13 2017 07:09
all my mails are read so I probably read it or accidentally not read it
euleram
@vijeth-aradhya
Jan 13 2017 07:10
coala/coala-bears#1267
sils @sils is afraid of all the mails he's getting every night
Lasse Schuirmann
@sils
Jan 13 2017 07:10
it's like when you sleep there's more and more work stacking up for you
euleram
@vijeth-aradhya
Jan 13 2017 07:13
Damn.. whatever it is, we gotta get good amount of sleep :stuck_out_tongue_closed_eyes: :sleeping:
Muhammad Kaisar Arkhan
@yukiisbored
Jan 13 2017 11:24
Hey guys, I'm creating ImageCompressionBear which category should I use?
image?
John Vandenberg
@jayvdb
Jan 13 2017 12:24
I think image is good
binary would be another option
media is slightly more generic than image, but less clear
Imo video processors would be distinct from image
cobot file issue pdf properties bear proposal
cobot file issue coala-bears pdf properties bear proposal
coala-bot
@coala-bot
Jan 13 2017 12:28
Here you go: coala/coala-bears#1301
John Vandenberg
@jayvdb
Jan 13 2017 12:29
i Always forget that
Muhammad Kaisar Arkhan
@yukiisbored
Jan 13 2017 12:29
(owo) yuki@matsuoka ~/git/optimage/test_data (master) $ coala -I -d ~/git/coala-bears/bears -b ImageCompressionBear -f valid2.png
Executing section Default...
[WARNING][19:28:33] Failed to read file '/home/yuki/git/optimage/test_data/valid2.png'. It seems to contain non-unicode characters. Leaving it out.
wut
John Vandenberg
@jayvdb
Jan 13 2017 12:29
aye. See rhemon's pr.
Bug in coala repo
im in busway macet ;)
Muhammad Kaisar Arkhan
@yukiisbored
Jan 13 2017 12:30
It's not Jakarta if there's no traffic ;)
I'm using coala version 0.10.0.dev20170113094654, it still doesn't work :/
John Vandenberg
@jayvdb
Jan 13 2017 12:35
coala/coala#3529
Muhammad Kaisar Arkhan
@yukiisbored
Jan 13 2017 12:40
so basically do not use -f?
John Vandenberg
@jayvdb
Jan 13 2017 13:00
Or fix that bug :)
But..yea maybe we need to workaround it , which means putting in a junk value like files = .coafile
yukiisbored @yukiisbored does the ultimate shruggie and run the bear via python3
Muhammad Kaisar Arkhan
@yukiisbored
Jan 13 2017 13:06
This is odd...
For some reason having file='<random thing goes here>' made it work
(owo) yuki@matsuoka ~/git/optimage/test_data (master) $ coala -I -d ~/git/coala-bears/bears -b ImageCompressionBear --file valid2.png -S image_files=valid2.png
Executing section Default...
[WARNING][20:06:44] Failed to read file '/home/yuki/git/optimage/test_data/valid2.png'. It seems to contain non-unicode characters. Leaving it out.
[WARNING][20:06:44] The context for the result (<Result object(id=0x269a363d7d0f4fb2af27b0c4d6fedd8f, origin='ImageCompressionBear', affected_code=(<SourceRange object(start=<SourcePosition object(file='/home/yuki/git/optimage/test_data/valid2.png', line=None, column=None) at 0x7fbc8dc1e9e8>, end=<SourcePosition object(file='/home/yuki/git/optimage/test_data/valid2.png', line=None, column=None) at 0x7fbc8dc1eba8>) at 0x7fbc8dc1e940>,), severity=NORMAL, confidence=100, message='This Image can be losslessly compressed to 69 bytes (savings: 439 bytes = 86.42%)', aspect=NoneType) at 0x7fbc8dc1e860>) cannot be printed because it refers to a file that doesn't seem to exist (/home/yuki/git/optimage/test_data/valid2.png).
|    | [NORMAL] ImageCompressionBear:
|    | This Image can be losslessly compressed to 69 bytes (savings: 439 bytes = 86.42%)
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit):
Anyway off to creating tests ._.
Muhammad Kaisar Arkhan
@yukiisbored
Jan 13 2017 13:24
Is this a good idea?
    @classmethod
    def check_prerequisites(cls):
        for requirement in cls.REQUIREMENTS:
            if isinstance(requirement, DistributionRequirement):
                executable = requirement.package['apt_get']
                if shutil.which(executable) is None:
                    return '{} is not installed'.format(executable)
        return True
or is it better if I create a tuple just for the executable names?
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Jan 13 2017 16:11
@yukiisbored "isinstance" :O
if you use "instanceof" in java at any of my homework they give you "0 points" on that homework
mixih
@Mixih
Jan 13 2017 16:13
why?
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Jan 13 2017 16:13
because they teach us its malicious and its really hard to introduce stuff when you use instanceof
and they push us to use polymorphism/visitor pattern, depending on what you need
mixih
@Mixih
Jan 13 2017 16:13
oh yeah....
instanceof can be limiting
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Jan 13 2017 16:13
@Mixih how old are you?
mixih
@Mixih
Jan 13 2017 16:14
but we use quite a bit of it :/
Why do you ask? :P
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Jan 13 2017 16:14
cuz u said u arent allowed to vote, and im curious how old you are
Muhammad Kaisar Arkhan
@yukiisbored
Jan 13 2017 16:14
inb4 felony
mixih
@Mixih
Jan 13 2017 16:15
:P younger than you
Muhammad Kaisar Arkhan
@yukiisbored
Jan 13 2017 16:15
@Adrianzatreanu Heh, weird. I use instance of a lot
Anyway, Java is weird. So yeah.
Quick move to off-topic before sims kicks us
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Jan 13 2017 16:15
@Mixih that doesnt decide anything :D
mixih
@Mixih
Jan 13 2017 16:15
:P
Rishav Kumar
@aptrishu
Jan 13 2017 16:19
I use instanceOf quite frequently.. like to assign an object to another..
Jitesh Pabla
@jiteshpabla
Jan 13 2017 17:14
hi, I made a PR recently (coala/coala-bears#1303), but the circleci build failed, can anyone guide me on how to go about this?
Robin Saleh-Jan
@robinsjdotcom
Jan 13 2017 17:20
@jiteshpabla Go through the circle-ci build, start at the first exception and go from there :)
Jitesh Pabla
@jiteshpabla
Jan 13 2017 17:28
oh ok, thanks @robinsjdotcom !