These are chat archives for coala/coala-bears

17th
Jan 2017
John Vandenberg
@jayvdb
Jan 17 2017 01:54
It means something is broken. as AppVeyor builds finish first, wait for the other CI to finish. If circle and travis also fail, it is a generic problem. If only Appveyor builds break, maybe it is a Windows only problem
Reethesh
@vreethesh
Jan 17 2017 12:40
@jayvdb Does that mean Appveyor is limited to Linux??
Adhityaa
@adtac
Jan 17 2017 12:48
No Appveyor is for Windows
@vreethesh
Reethesh
@vreethesh
Jan 17 2017 12:50
Oh sorry :+1: . I misunderstood @jayvdb 's comment. :smile:
@adtac t
Thanks*
Pratyush Prakash
@pratyushprakash
Jan 17 2017 13:40
I'm working on coala/coala-bears#792. How would one go about testing this?
Mischa Krüger
@Makman2
Jan 17 2017 13:40
look at tests for other bears ;)
Pratyush Prakash
@pratyushprakash
Jan 17 2017 13:42
I did. The problem here is this bear is run on a directory. I am assuming there would need to be a pyroma_test_files for this. But how do I run the bear in the context of that directory?
Mischa Krüger
@Makman2
Jan 17 2017 13:44

run on a directory

that means?

Pratyush Prakash
@pratyushprakash
Jan 17 2017 13:45
Its a GlobalBear which checks Python packaging best practices
Mischa Krüger
@Makman2
Jan 17 2017 13:45
ah
hm...
Pratyush Prakash
@pratyushprakash
Jan 17 2017 13:47
I've tried using change_directory from coala_utils.ContextManagers and then running the bear but that does not seem to work.
Never mind got it working now.
Mischa Krüger
@Makman2
Jan 17 2017 13:50
okay cool :)
Pratyush Prakash
@pratyushprakash
Jan 17 2017 17:46
Somethings wrong with coverage
It's giving a bunch of INTERNALERRORs
Pratyush Prakash
@pratyushprakash
Jan 17 2017 17:57
I think the new coverage is broken
I tried py.test and it worked fine. py.test --cov gave a bunch of internal errors. After changing coverage version everything is working fine
Today was the new release btw.
mixih
@Mixih
Jan 17 2017 17:59
ya, I have an issue if someone wants to fix it
pin it to 4.2.0 like it should have been
actually, I'll do it
Pratyush Prakash
@pratyushprakash
Jan 17 2017 18:00
I think this is important cause many PRs are failing for no reason
mixih
@Mixih
Jan 17 2017 18:00
I'm at the workstation ATM
one line fix
Pratyush Prakash
@pratyushprakash
Jan 17 2017 18:00
Yeah probably getting it done now is better
mixih
@Mixih
Jan 17 2017 18:04
coala/coala-bears#1318
done
Pratyush Prakash
@pratyushprakash
Jan 17 2017 18:05
Thanks
We should get this one merged ASAP
mixih
@Mixih
Jan 17 2017 18:06
I'm a maintainer ;)
Pratyush Prakash
@pratyushprakash
Jan 17 2017 18:06
:)
mixih
@Mixih
Jan 17 2017 18:07
so if you ack, I can get it merged pronto
Pratyush Prakash
@pratyushprakash
Jan 17 2017 18:07
I'm waiting for the tests to pass
mixih
@Mixih
Jan 17 2017 18:08
BTW, don't mark bears builds wip for this yet
Pratyush Prakash
@pratyushprakash
Jan 17 2017 18:08
yeah
Pratyush Prakash
@pratyushprakash
Jan 17 2017 18:28
@Mixih Should we do this for coala as well?
mixih
@Mixih
Jan 17 2017 18:31
maybe...