These are chat archives for coala/coala-bears

1st
Mar 2017
Satwik Kansal
@satwikkansal
Mar 01 2017 05:34
@jayvdb around?
John Vandenberg
@jayvdb
Mar 01 2017 07:15
ya, around
would appreciate if you can re-review coala/coala#3805
@satwikkansal ^
Satwik Kansal
@satwikkansal
Mar 01 2017 07:19
@jayvdb okay, also could you please have quick glance at coala/coala-quickstart#77 , just wanted to verify if my approach is correct :sweat_smile:
John Vandenberg
@jayvdb
Mar 01 2017 07:27
@satwikkansal , looking good until https://github.com/coala/coala-quickstart/pull/77/commits/3ce1d4be85e2 . that metadata should be in the coala languages and then the languages recorded in the bear metadata
as you dont want to have to fix coala and coala-bears for this fix, have a small additional private mapping function / data structure in coala-quickstart , which provides additional information for specific cases where there are grunt -> bear matches that we should use.
the more generic mapping can then be added to the bears incrementally as the coala generic language support grows
Satwik Kansal
@satwikkansal
Mar 01 2017 07:33
@jayvdb Okay. Actually, I generated that meta data by tweaking the existing generate_bear_requirements.py in coala-bears repo, would check how I could do the same in coala-quickstart and then maybe generate that meta-data during the runtime?
John Vandenberg
@jayvdb
Mar 01 2017 07:40
@satwikkansal , you dont need to save generated bear metadata in -quickstart , as you have all the bears loaded into memory
so you can extract that information at runtime
Yash Nisar
@yash-nisar
Mar 01 2017 08:46
@jayvdb @adtac @Makman2 , Can you please have a look at coala/coala-bears#1442 ? I have changed the LicenseCheckBear to detect whether a given file has a License or not. Is my approach satisfactory ?
Yash Nisar
@yash-nisar
Mar 01 2017 09:24
@sims1253 coala/coala-bears#803 seems to be solved ?
Maximilian Scholz
@sims1253
Mar 01 2017 09:27
@yash-nisar I'm feeling stupid. Take that out of my sight :D
Yash Nisar
@yash-nisar
Mar 01 2017 09:30
Shall we close this then? @sims1253
Maximilian Scholz
@sims1253
Mar 01 2017 09:31
i guess
Yash Nisar
@yash-nisar
Mar 01 2017 09:33
I was enthusiastic about solving that one. :smile:
I won't be able to close it :worried: , can you do it ?
Yash Nisar
@yash-nisar
Mar 01 2017 09:38
This also seems to be fixed @sims1253 @sils
coala/coala-bears#693
Maximilian Scholz
@sims1253
Mar 01 2017 09:47
closed them.
Yash Nisar
@yash-nisar
Mar 01 2017 09:49
Yayy !