These are chat archives for coala/coala-bears

3rd
Mar 2017
John Vandenberg
@jayvdb
Mar 03 2017 02:27
@damngamerz , one merged. coala/coala-bears#1455 rebase so it can be merged next?
John Vandenberg
@jayvdb
Mar 03 2017 03:41
@incorrectusername , coala/coala-bears#1335 can be rebased and merged now
Yogesh Gupta
@incorrectusername
Mar 03 2017 04:33
@jayvdb can you please do it :D . I'm in college now.
John Vandenberg
@jayvdb
Mar 03 2017 05:11
sure
John Vandenberg
@jayvdb
Mar 03 2017 06:03
(well ... "sure", if I get to it ... I probably wont get to it before you finish college)
it isnt a super urgent PR. But, your patch is approved so we should get it in first
Yogesh Gupta
@incorrectusername
Mar 03 2017 06:54
Yes :smile: :+1:
Saurav Singh
@damngamerz
Mar 03 2017 07:05
@jayvdb done :+1:
John Vandenberg
@jayvdb
Mar 03 2017 07:12
hmm. new failures. yay
coala/coala-bears#1472
Saurav Mehrotra
@Flap-Py
Mar 03 2017 11:16
cobot unassign coala/coala#3556
coala-bot
@coala-bot
Mar 03 2017 11:16
Unassigned, @Flap-Py!
Adhityaa
@adtac
Mar 03 2017 11:24
cobot help
coala-bot
@coala-bot
Mar 03 2017 11:24
cobot (invite|inv) <username> [to [team]] - Allows maintainers to invite users to the coala organization.
cobot <nevermind|nm> - Doesn't mind.
cobot <wa|wolfram> <question> - Searches Wolfram Alpha for the answer to the question.
cobot assign <issue_link> - Assigns issue <issue_link> to user
cobot explain <topic> - Returns the info we have on your topic.
cobot ghetto <text> - Real talk yo
cobot help - Displays all of the help commands that Hubot knows about.
cobot help <query> - Displays all help commands that match <query>.
cobot lmgtfy <term> - Searches google for you!
cobot mark (wip|pending) <pull URL> - Marks the given pull request as work in progress/pending review.
cobot new issue - Creates a GitHub issue given the title and repository.
cobot the rules - Make sure hubot still knows the rules.
cobot unassign <issue_link> - Unassign the user from the issue <issue_link>
ship it - Display a motivation squirrel
Adhityaa
@adtac
Mar 03 2017 11:27

cobot new issue coala-bears Create asciinemas directly from bear test files

Bear tests have these valid_files and invalid_files usually and it should be possible to create an asciinema from these in principle. Of course, human-made asciinemas are probably better, but if a bear doesn't have an asciinema url, we could generate one using this technique

coala-bot
@coala-bot
Mar 03 2017 11:27
Here you go : coala/coala-bears#1473
Adhityaa
@adtac
Mar 03 2017 11:30
cobot help review
coala-bot
@coala-bot
Mar 03 2017 11:30
cobot mark (wip|pending) <pull URL> - Marks the given pull request as work in progress/pending review.
Adhityaa
@adtac
Mar 03 2017 11:30
cobot help
coala-bot
@coala-bot
Mar 03 2017 11:30
cobot (invite|inv) <username> [to [team]] - Allows maintainers to invite users to the coala organization.
cobot <nevermind|nm> - Doesn't mind.
cobot <wa|wolfram> <question> - Searches Wolfram Alpha for the answer to the question.
cobot assign <issue_link> - Assigns issue <issue_link> to user
cobot explain <topic> - Returns the info we have on your topic.
cobot ghetto <text> - Real talk yo
cobot help - Displays all of the help commands that Hubot knows about.
cobot help <query> - Displays all help commands that match <query>.
cobot lmgtfy <term> - Searches google for you!
cobot mark (wip|pending) <pull URL> - Marks the given pull request as work in progress/pending review.
cobot new issue - Creates a GitHub issue given the title and repository.
cobot the rules - Make sure hubot still knows the rules.
cobot unassign <issue_link> - Unassign the user from the issue <issue_link>
ship it - Display a motivation squirrel
Saurav Singh
@damngamerz
Mar 03 2017 11:34
oh we have new failure.gr8!!
Yogesh Gupta
@incorrectusername
Mar 03 2017 13:15
@jayvdb done rebasing but tests are faliing :worried:
Satwik Kansal
@satwikkansal
Mar 03 2017 13:16
We've some golang issue that's causing the failure :worried:
John Vandenberg
@jayvdb
Mar 03 2017 13:53
coala/coala-bears#1472
We need ideas on how to solve that
Yash Nisar
@yash-nisar
Mar 03 2017 15:01
@jayvdb around ?
Yash Nisar
@yash-nisar
Mar 03 2017 15:41
I think I will need to remove the --lines argument, since it is not working as expected:
 yash  ~  licensecheck -l 1 mit_license.py 
mit_license.py: MIT/X11 (BSD like)
--lines, -l            Specify how many lines of the file header
                            should be parsed for license information
John Vandenberg
@jayvdb
Mar 03 2017 16:21
@yash-nisar , I was actually wondering about that
There is a very strange argument --tail INT described as : number of bytes to parse from bottom of each file; set to 0 to avoid parsing from end of file (default value: 5000)
how --lines and --tail work together is a bit of a mystery
We could (should?) look at how people are currently using this tool in their CI
Yash Nisar
@yash-nisar
Mar 03 2017 16:25
It worked @jayvdb , strange :O
So, how should we proceed with this ?
I don't think the --tail arg would be used much often
However, I have removed the --line arg too
or another workaround would be to specify both defaults, in the create_argements(..)
create_arguments(..) *
John Vandenberg
@jayvdb
Mar 03 2017 16:31
$  licensecheck -l 1 mit_license.py
mit_license.py: UNKNOWN
-l 60 works
Note if you remove the copyright line only, it responds with mit_license.py: *No copyright* MIT/X11 (BSD like)
I think your regex needs to be modified to allow that scenario
btw I am testing using licensecheck v3.0.29
Yash Nisar
@yash-nisar
Mar 03 2017 16:36
Yep, exactly
I had already modified it to output_regex=r'.*: .*UNKNOWN'
I was going to mention that in the PR
This is licensecheck, from the Debian devscripts package, version 2.16.2ubuntu3
Yash Nisar
@yash-nisar
Mar 03 2017 16:42
Did you install it from the devscripts package by sudo apt-get install devscripts
John Vandenberg
@jayvdb
Mar 03 2017 16:55
nope ; im on fedora ;-)
which version of Ubuntu are you testing on ?
Yash Nisar
@yash-nisar
Mar 03 2017 16:57
Ubuntu 16.04.2 LTS
:worried:
John Vandenberg
@jayvdb
Mar 03 2017 16:59
oh, it is a separate package in yakkety+ http://packages.ubuntu.com/zesty/devscripts
Yash Nisar
@yash-nisar
Mar 03 2017 17:00
Yup
http://paste.ubuntu.com/24102922/ <- This is how my licensecheck -h output looks like
Yash Nisar
@yash-nisar
Mar 03 2017 17:06
So how do we tackle this conflict that'll be faced by users of different distros ?
John Vandenberg
@jayvdb
Mar 03 2017 17:08
if --lines is broken on your version, the best option is for your lines setting to be None by default. When it is none, the argument isnt added.
Yash Nisar
@yash-nisar
Mar 03 2017 17:09
--lines works when used with --tails
Are we adding the --tails argument ?
John Vandenberg
@jayvdb
Mar 03 2017 17:38
sounds like you should add --tail also, again with a default of None
then the user can choose if they want --lines and/or --tail by adding those settings
Yash Nisar
@yash-nisar
Mar 03 2017 17:39
Alright. :smile:
John Vandenberg
@jayvdb
Mar 03 2017 17:40
the one major problem is going to be with the same LicensecheckBear config running on Fedora and Ubuntu -- may not have consistent results
Yash Nisar
@yash-nisar
Mar 03 2017 17:41
So what should we do ?
John Vandenberg
@jayvdb
Mar 03 2017 17:41
it is a problem for our CI, which are precise or trusty.
Yash Nisar
@yash-nisar
Mar 03 2017 17:42
Should we parse the entire file by default ?
John Vandenberg
@jayvdb
Mar 03 2017 17:42
build tests that work on Ubuntu trusty. Fedora users can find and fix any bugs, and somehow they need to get their fixes to also work on Ubuntu trusty. i.e. the problem is not your problem
Yash Nisar
@yash-nisar
Mar 03 2017 17:43
This will remove those consistencies and parse the entire file in both cases
Yeah, I got you. :smile:
John Vandenberg
@jayvdb
Mar 03 2017 17:43
a 'parse entire file' option is useful, but again it should be optional. parsing the entire file is a huge performance problem
Yash Nisar
@yash-nisar
Mar 03 2017 17:44
performance would be the bottleneck
The only way out is to give flexibility to the users to configure the --lines and --tail option
Is that okay @jayvdb ?
John Vandenberg
@jayvdb
Mar 03 2017 17:45
yup. both should be optional settings. someone else can enhance the bear later if they find a better solution
Yash Nisar
@yash-nisar
Mar 03 2017 17:47
Exactly