These are chat archives for coala/coala-bears

6th
Mar 2017
John Vandenberg
@jayvdb
Mar 06 2017 00:04
fix for the bears repo : coala/coala-bears#1487 ; should be green
John Vandenberg
@jayvdb
Mar 06 2017 01:37
Yay. It is green
Saurav Singh
@damngamerz
Mar 06 2017 03:24
ack ack ack ^ :smile: gr8 job :+1: @jayvdb quick merge ? :shipit:
John Vandenberg
@jayvdb
Mar 06 2017 03:36
Pinged maintainers to see if they have any objections to that approach
Speak now or forever hold your peace
John Vandenberg
@jayvdb
Mar 06 2017 04:26
merged.
John Vandenberg
@jayvdb
Mar 06 2017 04:38
@/all tree green again
get in quick before the next breakage ;-)
Adhityaa
@adtac
Mar 06 2017 04:39
Heh, but we know you'd be around to fix it up real quick :)
John Vandenberg
@jayvdb
Mar 06 2017 04:51
that seems to be the assumption, which is not very nice IMO
we cant assess the gsoc applicants properly if the tree is broken all the time
the tree being red should be a 'drop eveything' situation until gsoc selection is done IMO
Adhityaa
@adtac
Mar 06 2017 05:48
I agree. It looks like most breaks in bears is due to upstream versions changing? We should really look into Pipfile
And pin all our dependency versions to the exact number
we can update a couple of weeks before every release (two weeks time to iron out any issues)
but after the release, and before the next one, we can guarantee a working master
John Vandenberg
@jayvdb
Mar 06 2017 06:00
that would have not helped any of the recent breakages
Saurav Singh
@damngamerz
Mar 06 2017 06:36
oh finally my process approved PR will be merged rebasing :stuck_out_tongue:
Yash Nisar
@yash-nisar
Mar 06 2017 06:44
@damngamerz , our travis builds are failing due to the same error
John Vandenberg
@jayvdb
Mar 06 2017 06:44
fixed - see above
Yash Nisar
@yash-nisar
Mar 06 2017 06:44
+ go get -u github.com/golang/lint/golint
+ go get -u golang.org/x/tools/cmd/goimports
+ go get -u sourcegraph.com/sqs/goreturns
+ go get -u golang.org/x/tools/cmd/gotype
package golang.org/x/tools/cmd/gotype: cannot find package "golang.org/x/tools/cmd/gotype" in any of:
    /usr/local/go/src/golang.org/x/tools/cmd/gotype (from $GOROOT)
    /home/ubuntu/.go_workspace/src/golang.org/x/tools/cmd/gotype (from $GOPATH)
    /usr/local/go_workspace/src/golang.org/x/tools/cmd/gotype

bash .ci/deps.sh returned exit code 1
Repushed it just now @jayvdb :worried:
Saurav Singh
@damngamerz
Mar 06 2017 06:45
It's fixed :tada: @yash-nisar
John Vandenberg
@jayvdb
Mar 06 2017 06:45
@damngamerz , can you review coala/docker-coala-base#129 when CI is done.
Saurav Singh
@damngamerz
Mar 06 2017 06:45
well rebase and push @yash-nisar
John Vandenberg
@jayvdb
Mar 06 2017 06:45
@yash-nisar, rebase
Yash Nisar
@yash-nisar
Mar 06 2017 06:45
Okay, I'll go it again. :smile: , thanks @jayvdb @damngamerz
Saurav Singh
@damngamerz
Mar 06 2017 06:45
sure on the review :smile:
Yash Nisar
@yash-nisar
Mar 06 2017 06:47
made a stupid mistake. :worried:
Saurav Singh
@damngamerz
Mar 06 2017 06:48
NP mate :wink:
@jayvdb hey why removed python 2 dependencies ?
John Vandenberg
@jayvdb
Mar 06 2017 06:53
@damngamerz , read the issue and stuff
Saurav Singh
@damngamerz
Mar 06 2017 06:55
alright seems good will soon ack it as soon as build gets green :+1:
Saurav Singh
@damngamerz
Mar 06 2017 07:07
@jayvdb rultor awaits ur command coala/docker-coala-base#129
John Vandenberg
@jayvdb
Mar 06 2017 07:12
@incorrectusername, time to rebase coala/coala-bears#1335 again so we can merge it
Yash Nisar
@yash-nisar
Mar 06 2017 07:30
My tests pass locally but fail on circle ci, due to a difference in the lists.
pytest tests/general/LicenseCheckBearTest.py
======================= test session starts =======================
platform linux -- Python 3.5.2, pytest-3.0.6, py-1.4.32, pluggy-0.4.0
rootdir: /home/yash/coala-bears, inifile: setup.cfg
plugins: xdist-1.15.0, timeout-1.2.0, mock-1.5.0, env-0.6.0, cov-2.4.0
timeout: 35.0s method: signal
collected 2 items 

tests/general/LicenseCheckBearTest.py ..

==================== 2 passed in 0.21 seconds =====================
I checked deps.sh, the package devscripts was correctly installed IIUC
John Vandenberg
@jayvdb
Mar 06 2017 08:02
cobot file issue dependency_management Add method to get installed version
John Vandenberg
@jayvdb
Mar 06 2017 08:03
cobot file issue dependency_management Move gitlab project list from issue.coffee to a configuration file.
difficulty/low
Yash Nisar
@yash-nisar
Mar 06 2017 08:03
The tests pass locally, but why do they fail on travis and circle ci ? @jayvdb any ideas so I can take care in future ?
I read your review, :+1: , will do the required changes asap. :smile:
John Vandenberg
@jayvdb
Mar 06 2017 08:04
bug me again in 15 mins
John Vandenberg
@jayvdb
Mar 06 2017 08:57
@yash-nisar , wrt licensecheck, for circle, I suggest grabbing the .deb for devscripts amd64 2.14 , and at least trying to find the script version inside the code. It should be easy to run it without installing it. it is just a script , with common library dependencies. if that version of the script fails your tests, then we know that version is broken. (if it passes, then the problem could be in one of the dependencies)
Yash Nisar
@yash-nisar
Mar 06 2017 08:58
Okay @jayvdb , will work on it. Thanks a lot !
Yogesh Gupta
@incorrectusername
Mar 06 2017 09:43
@jayvdb done with rebase :+1:
euleram
@vijeth-aradhya
Mar 06 2017 09:59
I think I'll close this MR https://gitlab.com/coala/package_manager/merge_requests/18 since it requires design decisions to be made .. @yukiisbored @jayvdb Currently, we have this method in PipRequirement.py, we have to either make it general and keep it for all Requirement files or remove it and put it in cib
John Vandenberg
@jayvdb
Mar 06 2017 10:10
I've replied on the issue and provided feedback on the MR.
John Vandenberg
@jayvdb
Mar 06 2017 10:16
yay. two merged.
anyone else who thinks they have a PR ready to merge, pls ping me
and can I get a review of coala/coala-bears#1474 ; it just bit me again
Vamshi Krishna
@Vamshi99
Mar 06 2017 10:24
@jayvdb Done.
Muhammad Kaisar Arkhan
@yukiisbored
Mar 06 2017 11:24
@vijeth-aradhya Yeah, I'm planning to do that (or something similar to that) but due to school and a ton of homework, I basically have no time to do or think about it
Saurav Singh
@damngamerz
Mar 06 2017 14:00
@jayvdb quick look btw i followed npmrequirement to make it, hope this works :smile: https://gitlab.com/coala/package_manager/merge_requests/20
John Vandenberg
@jayvdb
Mar 06 2017 14:28
Looks quite good.
Re which('composer') , iirc, it is very common that composer is a local per–user installed tool named composer.php or similar
We desperately need to resolve the issue about appveyor ci
euleram
@vijeth-aradhya
Mar 06 2017 15:35
yeah thanks @jayvdb ill look into it
Vamshi Krishna
@Vamshi99
Mar 06 2017 16:00
@jayvdb This PR coala/coala-bears#1490 has conflicts because it over writes your command "go get -u github.com/jayvdb/gotype". Am I right?
conflict.PNG
John Vandenberg
@jayvdb
Mar 06 2017 16:09
Yup. If your solution is better, replace mine!
Yash Nisar
@yash-nisar
Mar 06 2017 16:11
strange behaviour by circle ci. :worried:
Vamshi Krishna
@Vamshi99
Mar 06 2017 16:11
I could not, I does not allows me to do so, Appveyor does not even running the tests, as it has conflicts.
John Vandenberg
@jayvdb
Mar 06 2017 16:12
@Vamshi99 , you can do anything with git
@yash-nisar , is that line covered when you run the tests locally?
Saurav Singh
@damngamerz
Mar 06 2017 16:21
@jayvdb alright, so if you need any changes just ping me !! one of the possible solution i can think of is adding global-tag composer global require <packagename>.which will install all packages globally.But IMO locally will work too as per circle and travis.Hmm for appveyor we have to fetch composer files.There's no other choice.
Yash Nisar
@yash-nisar
Mar 06 2017 16:25
100% coverage locally @jayvdb
ss.png
plus the tests pass locally
pytest tests/elm/ElmLintBearTest.py
======================= test session starts =======================
platform linux -- Python 3.5.2, pytest-3.0.6, py-1.4.32, pluggy-0.4.0
rootdir: /home/yash/coala-bears, inifile: setup.cfg
plugins: xdist-1.15.0, timeout-1.2.0, mock-1.5.0, env-0.6.0, cov-2.4.0
timeout: 35.0s method: signal
collected 6 items 

tests/elm/ElmLintBearTest.py ......

==================== 6 passed in 0.16 seconds =====================