These are chat archives for coala/coala-bears

14th
Mar 2017
John Vandenberg
@jayvdb
Mar 14 2017 02:49
anyone waiting for a review?
Chathurika Senani
@zenara
Mar 14 2017 03:02
To which branch should I PR my changes?
Master?
Abinash Senapati
@Techievena
Mar 14 2017 03:03
Yup
coala:master
Chathurika Senani
@zenara
Mar 14 2017 03:03
okay
And commit description msg should be replaced with something like this
README.rst: Updated the latest stable badge
This updates the latest stable version badge to 0.10.0 from 0.8.0 in readme file.
Closes #1408
right?
Abinash Senapati
@Techievena
Mar 14 2017 03:05
Ya spaces in between
Updated --> Update
Always use imperative sentences in commit message
Chathurika Senani
@zenara
Mar 14 2017 03:07
okay thanks
Abinash Senapati
@Techievena
Mar 14 2017 03:07
:smile:
Chathurika Senani
@zenara
Mar 14 2017 03:15
I wanted to create a PR for this coala/coala-bears#1408
And this is what I did
coala/coala-bears#1511
1511 ??
Abinash Senapati
@Techievena
Mar 14 2017 03:19
Reviwed check my comment.
Chathurika Senani
@zenara
Mar 14 2017 03:22
I'll change the commit message and I didn't get sqashing thing
Abinash Senapati
@Techievena
Mar 14 2017 03:22
Follow the link
cobot mark wip coala/coala-bears#1511
coala-bot
@coala-bot
Mar 14 2017 03:23
The pull request coala/coala-bears#1511 is marked work in progress. Use cobot mark pending or push to your branch if feedback from the community is needed again.
Yash Nisar
@yash-nisar
Mar 14 2017 11:09
@jayvdb addressed your comments in coala/coala-bears#1480
It would be nice if you would have a look, when you're free. :)
Abinash Senapati
@Techievena
Mar 14 2017 11:22
cobot mark wip coala/coala-bears#1425
coala-bot
@coala-bot
Mar 14 2017 11:22
The pull request coala/coala-bears#1425 is marked work in progress. Use cobot mark pending or push to your branch if feedback from the community is needed again.
John Vandenberg
@jayvdb
Mar 14 2017 11:47
@yash-nisar , did you see my comment about disabling color ?
Yash Nisar
@yash-nisar
Mar 14 2017 12:59
@jayvdb came online just now. :worried:
John Vandenberg
@jayvdb
Mar 14 2017 13:07
good timing :P
Yash Nisar
@yash-nisar
Mar 14 2017 13:28
haha :P
Thanks @jayvdb and @rultor :P