These are chat archives for coala/coala-bears

28th
Mar 2017
Yash Nisar
@yash-nisar
Mar 28 2017 05:12
Will keep that in mind @jayvdb :)
JACK_1729
@jack17529
Mar 28 2017 06:40
Is this the right way DistributionRequirement(packageName,type,version) ?
Niklas
@NiklasMM
Mar 28 2017 06:42
did you check the documentation?
JACK_1729
@jack17529
Mar 28 2017 06:44
yeah work in progress
I was on a page with written old docs and when I clicked on a new docs PWD
Yash Nisar
@yash-nisar
Mar 28 2017 07:54
sphinx fails with 1.4.9, trying 1.5.3 now @jayvdb
John Vandenberg
@jayvdb
Mar 28 2017 07:55
I've tried them both locally, and they fail
cobot file issue coala-bears upgrade Sphinx to 1.4.9
That is the version used by the coala and documentation repositories.
Spawning from https://github.com/coala/coala-bears/issues/1544#issuecomment-289671506
status/blocked on ^ bug
coala-bot
@coala-bot
Mar 28 2017 07:56
Here you go : coala/coala-bears#1554
Yash Nisar
@yash-nisar
Mar 28 2017 07:59
Okay, so I'm cancelling builds then
So should we undo the commit that created the bug and restore sphinx to the previous version ? or remove the example ? @jayvdb
George Joseph
@Shade5
Mar 28 2017 08:14
Can someone help me with this coala/coala-bears#1337. I can't get appveyor to pass. I've tried everything :sweat:
Niklas
@NiklasMM
Mar 28 2017 08:22
hmm looks like lxml is failing to install
looking at the pypi page it seems that Windows should be supportet though
do you have a Windows machine where you can try it out locally?
hm but there is no wheel for windows and python 3.4
maybe that's the problem?
George Joseph
@Shade5
Mar 28 2017 08:24
Yes, I've been trying to figure out a way to install it on windows
Abinash Senapati
@Techievena
Mar 28 2017 08:26
@Shade5 I am working on that and have made a bit of progress may be you can help me out. coala/coala-bears#1425
George Joseph
@Shade5
Mar 28 2017 08:28
@Techievena Yes, I know :sweat_smile: . Both of us have prs that are blocked due to this!
Abinash Senapati
@Techievena
Mar 28 2017 08:29
I have other issues too. apertium-lint is erroneous. :sweat_smile:
George Joseph
@Shade5
Mar 28 2017 08:30
Downloading the package manually and installing it seems to be the only way
But appveyor has no wget
Abinash Senapati
@Techievena
Mar 28 2017 08:31
There is some issues with arguement parsing I guess. See my comments on that PR.
We can use curl
in appveyor
Because I am able to install lxml properly on Windows and it is working fine but appveyor is showing issues.
George Joseph
@Shade5
Mar 28 2017 08:34
Where are you downloading lxml from ?
Abinash Senapati
@Techievena
Mar 28 2017 08:34
George Joseph
@Shade5
Mar 28 2017 08:36
You're saying the above doesn't work. Lets try http://lxml.de/build.html
Abinash Senapati
@Techievena
Mar 28 2017 08:37
No it works perfectly fine. Some issues in argument parsing in XMLBear for which it is showing build errors. And therefore my PR can't be merged.
John Vandenberg
@jayvdb
Mar 28 2017 08:39
@yash-nisar, removing the example is off the cards. We know we have a bug related to that commit; hiding the bug isnt helpful
George Joseph
@Shade5
Mar 28 2017 08:39
Cool, also we should make sure the development packages of libxml2 and libxslt are installed
Yash Nisar
@yash-nisar
Mar 28 2017 08:40
yes, that would hide the bug, so I'm planning to undo the commit, is that okay ?
John Vandenberg
@jayvdb
Mar 28 2017 08:40
@yash-nisar, in ^ that comment, could you link to the coala-bears issue , instead of a link to a travis job
Abinash Senapati
@Techievena
Mar 28 2017 08:41
Why development packages? @Shade5
John Vandenberg
@jayvdb
Mar 28 2017 08:43
:+1:
Yash Nisar
@yash-nisar
Mar 28 2017 08:44
So should we wait until those are fixed or should I undo the commit ?
We have some PRs blocked due to this issue so.. @jayvdb
John Vandenberg
@jayvdb
Mar 28 2017 08:47
We only found the problem an hour ago. I am sure another hour, and we will have a fix ;-) And if we dont, and undo is easy to do.
Yash Nisar
@yash-nisar
Mar 28 2017 08:47
Okay, no problem :) Thanks @jayvdb
John Vandenberg
@jayvdb
Mar 28 2017 08:55
So that commit added the docstrings to the wrapped function. Previously they were not being checked. Now they are. Sphinx doesnt like the syntax. Why not?
Is it a bug in sphinx, or is the syntax broken?
is the python syntax broken? Is the rst syntax broken?
Satwik Kansal
@satwikkansal
Mar 28 2017 09:29

I need some help regarding LocalBearTestHelper.check_results

def test_bad_documnentation(self):
        prepared = prepare_file(bad_file,
                                filename=None,
                                create_tempfile=True)
        self.maxDiff = None
        with prepared as (file, fname):
            self.check_results(
                self.uut,
                bad_file.splitlines(),
                [Result.from_values('DocformatterBear',
                                    message=result_message,
                                    file=fname,
                                    line=4,
                                    end_line=4,
                                    severity=RESULT_SEVERITY.NORMAL)])

^^ The above test fails because the value of file in the created Result (from Result.from_values method) and that in the result generated by the bear differ.

And when I try

def test_bad_documnentation(self):
        prepared = prepare_file(bad_file,
                                filename=None,
                                create_tempfile=True)
        self.maxDiff = None
        with prepared as (file, fname):
            self.check_results(
                self.uut,
                bad_file.splitlines(),
                [Result.from_values('DocformatterBear',
                                    message=result_message,
                                    file=fname,
                                    line=4,
                                    end_line=4,
                                    severity=RESULT_SEVERITY.NORMAL)],
                filename=fname,
                create_tempfile=False)

The list of results generated by the bear becomes empty

Adhika Setya Pramudita
@adhikasp
Mar 28 2017 11:45
Does a bear that can_fix somethingX always can detect it too?
Yogesh Gupta
@incorrectusername
Mar 28 2017 11:45
yes
Niklas
@NiklasMM
Mar 28 2017 11:45
I can't think of an instance where that would not be the case
HeisebergsUncertaintyBear - it can either fix your code or detect issues
Abinash Senapati
@Techievena
Mar 28 2017 11:47
@adhikasp To fix it it must detect it first :smiley:
Yogesh Gupta
@incorrectusername
Mar 28 2017 11:47
Specifying something to CAN_FIX makes it obvious that it can be detected too,
Adhika Setya Pramudita
@adhikasp
Mar 28 2017 11:52
Nice, thanks all :smile:
Pratyush Prakash
@pratyushprakash
Mar 28 2017 14:21
cobot assign coala/coala-bears#1220
coala-bot
@coala-bot
Mar 28 2017 14:21
:tada: You have been assigned to coala/coala-bears#1220
JACK_1729
@jack17529
Mar 28 2017 14:49
@pratyushprakash bear proposal doesn't means they are going to be solved in the GSOC period?
John Vandenberg
@jayvdb
Mar 28 2017 15:44
cobot file issue coala-bears Declare min ruby version for RubySyntaxBear
It was removed in 346ac8364
status/blocked on a version being added to DistributionRequirement constructor.
difficulty/newcomer
coala-bot
@coala-bot
Mar 28 2017 15:44
Here you go : coala/coala-bears#1560
John Vandenberg
@jayvdb
Mar 28 2017 15:45
@yash-nisar, you disappeared .. are you able to spend an hour or so on the build breakage tonight?
Yash Nisar
@yash-nisar
Mar 28 2017 16:33
@jayvdb , Do you mean resolving coala/coala#3786 ?
John Vandenberg
@jayvdb
Mar 28 2017 16:33
@yash-nisar , no , coala/coala-bears#1544 is the easy one to solve
Yash Nisar
@yash-nisar
Mar 28 2017 16:34
I've opened a PR for resolving RuboCopBear coala/coala-bears#1555
So, we've tested it for different sphinx versions, but of no help :worried: @jayvdb . I'm unable to find the cause of the bug.
John Vandenberg
@jayvdb
Mar 28 2017 16:43
@yash-nisar see https://gitter.im/coala/coala-bears?at=58da24e8b52518ed4db55922 , and my comments on the issue
Yash Nisar
@yash-nisar
Mar 28 2017 16:49

@jayvdb Didn't get his

The irony is that we want this badly formatted code in order to demonstrate what this bear can fix with this parameter fixed.

Does this mean that we require the example and it is trivial ?

John Vandenberg
@jayvdb
Mar 28 2017 17:00
yes, read the docstring ... the badly formatted code is intentional ...
Yash Nisar
@yash-nisar
Mar 28 2017 17:11

I don't have experience with sphinx so I'm unable to figure that out @jayvdb

Is it a bug in sphinx, or is the syntax broken? is the python syntax broken? Is the rst syntax broken?

Yash Nisar
@yash-nisar
Mar 28 2017 17:21
I think we should revert the commit until someone who has worked on sphinx/documentation generation takes it up @jayvdb
John Vandenberg
@jayvdb
Mar 28 2017 17:31
that isnt going to happen. either you or I fix the problem. :P
and im kinda hoping you can :P
Yash Nisar
@yash-nisar
Mar 28 2017 17:34
haha :P, I'll try doing it. :)
Adhityaa
@adtac
Mar 28 2017 17:35
what's the linter count again?
(number of bears)
64?
Yash Nisar
@yash-nisar
Mar 28 2017 17:36
dunno @adtac but bear-docs has to be updated
some bears haven't been added
Adhityaa
@adtac
Mar 28 2017 17:36
yeah doing that
if anyone else is interested it's 107 bears supporting 64 languages
Yash Nisar
@yash-nisar
Mar 28 2017 17:38
woah, massive :+1:
Adhityaa
@adtac
Mar 28 2017 17:39
can't resist a "that's what she said", sorry :D
Yash Nisar
@yash-nisar
Mar 28 2017 17:39
haha :P
Adhityaa
@adtac
Mar 28 2017 17:39
wait, we have travis integration in bear-docs now?
Yash Nisar
@yash-nisar
Mar 28 2017 17:41
I also noticed that just now !?
Meet Mangukiya
@meetmangukiya
Mar 28 2017 17:41
:/ it is completely generated and still CI :P
JACK_1729
@jack17529
Mar 28 2017 17:53
quick question does you all have to make coala compatible to use with virtualenv or any damn project can be run without making it compatible?
sils @sils doesn't understand the question
Yash Nisar
@yash-nisar
Mar 28 2017 18:26
@jayvdb Still no luck with the Indentation error, maybe you will have to take over. :smile:
Satwik Kansal
@satwikkansal
Mar 28 2017 18:31
:point_up: https://gitter.im/coala/coala-bears?at=58da2d0d08c00c092a22b9f8 Is this weird behavior a bug in LocalBearTestHelper.check_results or my approach is incorrect?
John Vandenberg
@jayvdb
Mar 28 2017 18:32
@meetmangukiya, if you look at the last PR, you will see "completely generated" involved lots of human errors
@yash-nisar , well if you can fix coala/coala-bears#1555 , that would be very helpful
as both fixes need to be ready before we can merge
Yash Nisar
@yash-nisar
Mar 28 2017 18:38
Yes, I can fix coala/coala-bears#1555
I tried finding for Unexpected indentation error sphinx on google but many were upstream bugs
John Vandenberg
@jayvdb
Mar 28 2017 18:41
have we defined a sphinx docstring style ?
Sanket Dasgupta
@SanketDG
Mar 28 2017 18:50
@jayvdb for now we just go with what is already there
i.e. the column based
which is very hard to maintain
so the ultimatum is to move to line by line description
John Vandenberg
@jayvdb
Mar 28 2017 18:51
because we're using triple backticks quite a bit, but they are not part of rst
Sanket Dasgupta
@SanketDG
Mar 28 2017 18:52
uh yes, I don't know how they happened
they shouldn't be there
.. python
    def some(): pass
this is how it is in sphinx
John Vandenberg
@jayvdb
Mar 28 2017 18:53
cobot file issue coala Remove triple backticks from RST
coala-bot
@coala-bot
Mar 28 2017 18:53
Here you go : coala/coala#4012
John Vandenberg
@jayvdb
Mar 28 2017 18:56
cobot file issue coala-bears Remove triple backticks from RST
coala-bot
@coala-bot
Mar 28 2017 18:56
Here you go : coala/coala-bears#1561
Yash Nisar
@yash-nisar
Mar 28 2017 19:26
@jayvdb Updated coala/coala-bears#1555 and addressed your comments :)
John Vandenberg
@jayvdb
Mar 28 2017 20:18
And coala/coala-bears#1562 should fix the build