These are chat archives for coala/coala-bears

4th
Apr 2017
Yash Nisar
@yash-nisar
Apr 04 2017 07:17
@jayvdb Can you have a look at coala/coala-bears#1575 when you're free ? :P
John Vandenberg
@jayvdb
Apr 04 2017 07:24
does it only happen on Circle?! that would be strange
Yash Nisar
@yash-nisar
Apr 04 2017 07:45
yes, travis passes
Shreyans
@shreyans800755
Apr 04 2017 09:06
Can someone help move ahead with coala/coala-bears#1543 ?
Its related to MP3CheckBear proposal coala/coala-bears#1519. MP3Check command works fine in my local. But with coala, it is somehow unable to process non-unicode file leading to failure.
And if I want to commit tests, I all need mp3 files. I'm not sure which files should I commit, and follow the policy at the same time.
John Vandenberg
@jayvdb
Apr 04 2017 09:14
@shreyans800755 , are you sure the tests pass on your system. We have a design bug which prevents any binary from working. @yukiisbored created a fix PR, but it was stalled.
Shreyans
@shreyans800755
Apr 04 2017 09:15
@jayvdb No. like a mentioned, normal mp3check command works with params, but using MP3CheckBear, it gives me error like following:
Executing section Default...
[WARNING][04:09:34] Failed to read file '/home/thereal/songs/HaiJunoon.mp3'. It seems to contain non-unicode characters. Leaving it out.
And other 4-5 warning concluding that it can't read the file
Yash Nisar
@yash-nisar
Apr 04 2017 09:51
@jayvdb should we revert coala/coala#3946 ? What do you suggest ?
John Vandenberg
@jayvdb
Apr 04 2017 11:12
@shreyans800755, then your bear is blocked , waiting for the binary file support
@yash-nisar, not yet ... we still dont know the cause. have you investigated my comment at https://github.com/coala/coala-bears/issues/1575#issuecomment-291442709
Yash Nisar
@yash-nisar
Apr 04 2017 11:29
@jayvdb IIUC, both travis and circleci use the same coala version that we have in requirements.txt, ie. coala>=0.11.0.dev20170322155718
John Vandenberg
@jayvdb
Apr 04 2017 11:39
@yash-nisar , due to caching that can be many different versions. Is .dev20170322155718 before the coala commit i suspect caused it?
Yash Nisar
@yash-nisar
Apr 04 2017 14:25
@jayvdb I tested it with the older version of coala ie. coala>=0.10.0.dev20170202144131, see https://circleci.com/gh/yash-nisar/coala-bears/32?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link and travis passes https://travis-ci.org/coala/coala-bears/builds/218470344, so IIUC the wraps decorator may be the cause
Shreyans
@shreyans800755
Apr 04 2017 14:41
cobot assign coala/coala-bears#1577
coala-bot
@coala-bot
Apr 04 2017 14:41
:tada: You have been assigned to coala/coala-bears#1577
Shreyans
@shreyans800755
Apr 04 2017 17:33
I'm getting following error on running pytest:
Traceback:
tests/general/FilenameBearTest.py:3: in <module>
from bears.general.FilenameBear import FilenameBear
bears/general/FilenameBear.py:6: in <module>
from coalib.bearlib.naming_conventions import (
E ImportError: cannot import name 'to_kebabcase'
Yash Nisar
@yash-nisar
Apr 04 2017 17:42
Have you rebased ?
Saurav Singh
@damngamerz
Apr 04 2017 18:01
John Vandenberg
@jayvdb
Apr 04 2017 19:55
@yash-nisar , any time you test with, or talk about, coala>=xyz, the results are useless
pip will install the latest
jayvdb @jayvdb clicks the links to find out the actual versions installed in those builds
yash-nisar @yash-nisar has repushed with coala==0.10.0.dev20170202144131
and I replaced >= with ==, so it is confirmed that we're using the previous version :)
John Vandenberg
@jayvdb
Apr 04 2017 20:41
see my comment on the issue
John Vandenberg
@jayvdb
Apr 04 2017 20:52
the main area of analysis is why does travis pass, but circle fail.