These are chat archives for coala/coala-bears

9th
Apr 2017
Yash Nisar
@yash-nisar
Apr 09 2017 07:13
woah, no activity on this channel since a long time :O
Zatreanu Adrian-Gabriel
@Adrianzatreanu
Apr 09 2017 09:25
you mean 2 days?
Yash Nisar
@yash-nisar
Apr 09 2017 11:43
Yep :P
Yash Nisar
@yash-nisar
Apr 09 2017 15:08
Are we installing nodejs as a dependency for any of the npm packages ? I cant find nodejs installed in CI
John Vandenberg
@jayvdb
Apr 09 2017 16:02
"@sils commented #1288" in the activity bar, but .. I cant see the comments anywhere.
Lasse Schuirmann
@sils
Apr 09 2017 16:03
I didn't
I deleted the spammy gitmate warnings
to make the history more readable
John Vandenberg
@jayvdb
Apr 09 2017 16:04
ah; nod.
Sanket Dasgupta
@SanketDG
Apr 09 2017 19:00
@yash-nisar then its probably by there by default
Yash Nisar
@yash-nisar
Apr 09 2017 19:09
You mean its there by default ? @SanketDG
Sanket Dasgupta
@SanketDG
Apr 09 2017 19:15
yup
Yash Nisar
@yash-nisar
Apr 09 2017 19:17
Thanks :)
John Vandenberg
@jayvdb
Apr 09 2017 20:29
@yash-nisar , now that your tests pass, you might want to split that PR into two (or more) -- one that introduces the base bear (and should merge quickly), and then others for the parts which overlap with other bears functionalities (which the reviewer will need to review carefully)
Yash Nisar
@yash-nisar
Apr 09 2017 20:31
Alright @jayvdb , will look into it tommorrow :)