These are chat archives for coala/coala-bears

10th
Apr 2017
Yash Nisar
@yash-nisar
Apr 10 2017 13:29
@jayvdb Can I have a quick review on coala/coala-bears#1601 ? The change comprises of 2 deletions :P
Niklas
@NiklasMM
Apr 10 2017 13:32

The change comprises of 2 deletions 

- The US Army command, when they pitched the dropping of the nuclear bombs. :boom:

Yash Nisar
@yash-nisar
Apr 10 2017 13:33
Haha, 2 massive deletions
@NiklasMM Can you review if you're free ? :P
Niklas
@NiklasMM
Apr 10 2017 13:33
damn, what gave it away?
Yash Nisar
@yash-nisar
Apr 10 2017 13:33
will take like 10 seconds
Niklas
@NiklasMM
Apr 10 2017 13:34
So these were unused I guess?
Adhityaa
@adtac
Apr 10 2017 13:34
@yash-nisar you don't have to ping someone for a review each time ;)
Niklas
@NiklasMM
Apr 10 2017 13:34
don't we have a check for unused imports? :-o
Yash Nisar
@yash-nisar
Apr 10 2017 13:34
Oops :worried:
Will keep that in mind @adtac
John Vandenberg
@jayvdb
Apr 10 2017 13:34
hmm ... that patch is a newcomer patch ... shouldnt be done by a dev :P
and yes, the goal should be to enable PyFlakesBear , or PyUnusedCodeBear
Yash Nisar
@yash-nisar
Apr 10 2017 13:41
Okay :+1:
Adhityaa
@adtac
Apr 10 2017 14:03
@aptrishu could you please reack commits that have been acked before - makes it easier to review
ugh, wrong room
Rishav Kumar
@aptrishu
Apr 10 2017 14:17
done @adtac
Adhityaa
@adtac
Apr 10 2017 14:18
:+1:
@aptrishu reack, not ack
you can do reack <sha>
and you need to reack the new commit
they'll change during rebases/amends
but if the contents are the same, you can go ahead and reack them to make it easier for reviewers (so that I can skip looking at that commit)
(although I don't think there aren't any internal differences between acks and reacks)
Rishav Kumar
@aptrishu
Apr 10 2017 14:53
yeah, actually i reacked first but it didnt work, thats why tried the ack..
:+1: