These are chat archives for coala/coala-bears

26th
Apr 2017
I'm working on this new comer issue coala/coala-bears#1613
where would JuliaRequirements be imported from, would appreciate little help
Yash Nisar
@yash-nisar
Apr 26 2017 11:37
From here
John Vandenberg
@jayvdb
Apr 26 2017 11:55
@yash-nisar can you guide coala/coala-bears#1661 through the process, giving commands necessary to fix the problem
John Vandenberg
@jayvdb
Apr 26 2017 12:35
another one merged. Thx @incorrectusername
Naveen Tata
@naveentata
Apr 26 2017 13:05
@jayvdb Can you review this coala/coala-bears#1496
John Vandenberg
@jayvdb
Apr 26 2017 13:19
@naveentata , it needs another rebase
Naveen Tata
@naveentata
Apr 26 2017 13:20
Oh kk :smile: :+1:
@jayvdb done with the rebase :smile:
Yogesh Gupta
@incorrectusername
Apr 26 2017 13:52
@jayvdb welcome :) . My exams and submission are going on else i would have been more active, sorry for that.
John Vandenberg
@jayvdb
Apr 26 2017 14:03
https://travis-ci.org/jayvdb/coala/builds/226002010 here is what it looks like on openSUSE
John Vandenberg
@jayvdb
Apr 26 2017 14:25
can someone help @prakashdanish with coala/coala-bears#1661 ; it is needed for this release.
do :
git rebase -i HEAD~3
change the first letter of the first three lines to
r ...
f ...
f ...
then change the commit message to something like:
JuliaLintBear: Switch to JuliaRequirement
Fixes https://github.com/coala/coala-bears/issues/1613
and then
git fetch upstream master
git rebase upstream/master
git push -f
Do this asap, and get your PR merged ;)
John Vandenberg
@jayvdb
Apr 26 2017 14:35
@mixih, can you add a note on coala/coala-bears#1650 about how many hours to go before you need it finished.
yash-nisar @yash-nisar wakes up
Yash Nisar
@yash-nisar
Apr 26 2017 14:38
The short nap turned out to be a loooong one, damn
Naveen Tata
@naveentata
Apr 26 2017 14:38
@jayvdb Can I be assigned to this as he was inactive for nearly 2 months?
coala/coala-bears#1358
John Vandenberg
@jayvdb
Apr 26 2017 14:39
@naveentata , we should wait a bit longer for @ankit01ojha to finish it
Naveen Tata
@naveentata
Apr 26 2017 14:40
ok :smile: :+1:
John Vandenberg
@jayvdb
Apr 26 2017 14:40
@naveentata , but you can do coala/coala-bears#1665
Naveen Tata
@naveentata
Apr 26 2017 14:43
Yeah, But it is newcomer ,so cobot will not allow me to assign :worried:
could you assign me?
@jayvdb
Yash Nisar
@yash-nisar
Apr 26 2017 14:44
How many requirements have been off the checklist ?
yash-nisar @yash-nisar is on the mobile version
John Vandenberg
@jayvdb
Apr 26 2017 14:45
5 so far
Yash Nisar
@yash-nisar
Apr 26 2017 14:46
Lets complete the checklist
Naveen Tata
@naveentata
Apr 26 2017 14:47
@yash-nisar Yeah, lets complete :smile:
Meet Mangukiya
@meetmangukiya
Apr 26 2017 14:48
ok, an outsider question: Does dependency_management express dependencies or installs?
Yash Nisar
@yash-nisar
Apr 26 2017 14:48
Only expresses as of now
Meet Mangukiya
@meetmangukiya
Apr 26 2017 14:49
So, does it suggest a relevant command to install the dependency ?
if not, what are the upsides of using it/what is the role of it?
John Vandenberg
@jayvdb
Apr 26 2017 14:52
it does installs also, but we havent activated that
Meet Mangukiya
@meetmangukiya
Apr 26 2017 14:53
wow, that is just awesome..
I can see its use outside coala
John Vandenberg
@jayvdb
Apr 26 2017 14:54
Meet Mangukiya
@meetmangukiya
Apr 26 2017 14:56
that is one hell of an error a traceback
Vamshi Krishna
@Vamshi99
Apr 26 2017 15:21
Lets complete the checklist
Need any help from me?
Yash Nisar
@yash-nisar
Apr 26 2017 15:22
coala/coala-bears#1663 is unassigned, if you'd like to take over
mixih
@Mixih
Apr 26 2017 15:22
freeze happens tonight ;)
go go go
Yash Nisar
@yash-nisar
Apr 26 2017 15:23
:runner: :stuck_out_tongue:
John Vandenberg
@jayvdb
Apr 26 2017 15:38
tonight is relative
mixih
@Mixih
Apr 26 2017 15:39
:P
UTC 0300 :P
Meet Mangukiya
@meetmangukiya
Apr 26 2017 15:39
ohh.. god not something other then UTC
oh... just another typo of yours :|
mixih
@Mixih
Apr 26 2017 15:39
I'm famous for them :P
Meet Mangukiya
@meetmangukiya
Apr 26 2017 15:40
I learnt about CEST, PDT recently
can't take no more
mixih
@Mixih
Apr 26 2017 15:40
CST is the way to go fam
Meet Mangukiya
@meetmangukiya
Apr 26 2017 15:40
why not just use UTC ftw
fam -- family?
mixih
@Mixih
Apr 26 2017 15:40
because people think 0300 is the morning and should be dark
so we have the whole tz mess :P
John Vandenberg
@jayvdb
Apr 26 2017 15:41
8 hours from now ?
mixih
@Mixih
Apr 26 2017 15:41
something like that
more like ten
I must have miscalculated DST again
John Vandenberg
@jayvdb
Apr 26 2017 15:47
@damngamerz, I havent seen any PRs from you for REQUIREMENTS. Are you going to be able to finish them by tonight .. if not, time to re-allocate your issues to someone else
Vamshi Krishna
@Vamshi99
Apr 26 2017 15:54
@jayvdb In this coala/coala-bears#1663 , we want maven-pmd-plugin, right?
Yash Nisar
@yash-nisar
Apr 26 2017 15:54
See coala/coala-bears#1662
and the PR associated with ^^
John Vandenberg
@jayvdb
Apr 26 2017 15:55
does maven-pmd-plugin contain cpd ?
Saurav Singh
@damngamerz
Apr 26 2017 15:55
Aah busy a bit. I will do it in an hour or so.
Vamshi Krishna
@Vamshi99
Apr 26 2017 15:55
I think CPD is a part of PMD
John Vandenberg
@jayvdb
Apr 26 2017 15:56
check that maven package contents
Meet Mangukiya
@meetmangukiya
Apr 26 2017 16:06
@sils as owner of coala organization I suggest you restrict the third-party application access. Currently all members can allow any application access to coala. Unless you intended to do that IMO you should change it. If anyone wants to try out things, then he can request you.
John Vandenberg
@jayvdb
Apr 26 2017 16:07
^ I agree. too risky
Meet Mangukiya
@meetmangukiya
Apr 26 2017 16:07
I think that reviewable.io creeped in when I was trying it out, but coala just gave access, even if I intended to use it personally
John Vandenberg
@jayvdb
Apr 26 2017 16:07
it makes me afraid to use integrations, because they can sometimes be aggressive marketing
Meet Mangukiya
@meetmangukiya
Apr 26 2017 16:08
some of them even ask for write access :(
mixih
@Mixih
Apr 26 2017 16:09
wait, they can grant write access to 3rd party integrations?
John Vandenberg
@jayvdb
Apr 26 2017 16:10
issue access isnt the same as write access
mixih
@Mixih
Apr 26 2017 16:10
still dangerous
John Vandenberg
@jayvdb
Apr 26 2017 16:10
yup
Meet Mangukiya
@meetmangukiya
Apr 26 2017 16:11
reviewable seriously edits comments to do marketing #shittyMarketing
#ForcedMarketing
mixih
@Mixih
Apr 26 2017 16:11
yep, that's really quite bad
Vamshi Krishna
@Vamshi99
Apr 26 2017 16:12
CPD.PNG
@jayvdb ^
Meet Mangukiya
@meetmangukiya
Apr 26 2017 16:14
didn't realize I posted on bears channel
and with our way of doing things, even newcomers can grant access, they just need to be a member IIKC
Vamshi Krishna
@Vamshi99
Apr 26 2017 16:17
check this https://maven.apache.org/plugins/maven-pmd-plugin/index.html for more info on that maven-pmd-plugin
John Vandenberg
@jayvdb
Apr 26 2017 16:18
@Vamshi99, sounds good.
Vamshi Krishna
@Vamshi99
Apr 26 2017 16:19
So, coala/coala-bears#1663 and coala/coala-bears#1662 needs the same work
Yash Nisar
@yash-nisar
Apr 26 2017 16:22
Yes, CPD is included in the PMD package, so both can be done in a similar manner :wink:
damngamerz @damngamerz wakes up making his ComposerRequirement PR.
Naveen Tata
@naveentata
Apr 26 2017 18:08
@jayvdb Can you review this coala/coala-bears#1673 ?
Saurav Singh
@damngamerz
Apr 26 2017 18:14
coala/coala-bears#1674 alright Done!
Still i need to find a way to add composer in CI :worried:
seems like my bash script is not working :cry:
John Vandenberg
@jayvdb
Apr 26 2017 18:15
@naveentata, please test on your own computer before uploading
If you dont know the solution for the harder part, just do the simple bit.
Naveen Tata
@naveentata
Apr 26 2017 18:17
Ok then, for now I will just add the requirement and I will work on that later, is that ok @jayvdb :smile:
John Vandenberg
@jayvdb
Apr 26 2017 18:17
perfect
John Vandenberg
@jayvdb
Apr 26 2017 19:05
@damngamerz , you can speed up your PR by killing the old build on https://circleci.com/gh/damngamerz/coala-bears
Saurav Singh
@damngamerz
Apr 26 2017 19:07
hmm done lets see if it passes or not :worried:
Yash Nisar
@yash-nisar
Apr 26 2017 19:08
@jayvdb Wanna include the StylintBear ? Should be ready after 1-2 iterations
John Vandenberg
@jayvdb
Apr 26 2017 19:10
not really. the requirements patches are more important and being delayed by all the other builds
Yash Nisar
@yash-nisar
Apr 26 2017 19:11
Oh okay :+1:
Saurav Singh
@damngamerz
Apr 26 2017 19:11
Build passed on circle :tada:
Naveen Tata
@naveentata
Apr 26 2017 19:34
@jayvdb Can you review this coala/coala-bears#1673 ?
John Vandenberg
@jayvdb
Apr 26 2017 19:44
yup; needs rebase.
g'night