These are chat archives for coala/coala-bears

3rd
May 2017
John Vandenberg
@jayvdb
May 03 2017 00:17
IMO, leave that thread brew a bit longer. if there is no other responses after a few days, send a follow up describing the missing parts of the python API that we plan to add.
also would be useful to investigate if the other APIs (Java, Ruby, etc) already have more advanced functionality compared to the Python library ... ;-)
Tulio Leao
@tupaschoal
May 03 2017 01:14
@Techievena seems that squashing them solved it, without having to change a thing, thanks :)
Abinash Senapati
@Techievena
May 03 2017 01:45
:+1:
Tulio Leao
@tupaschoal
May 03 2017 02:05
coala/coala-bears#1622
Only check missing is manual review, if someone could please help :)
coala/coala-bears#1621
Only failed on CircleCI, I don't get why. I tried to do everything like I did on #1622
Tulio Leao
@tupaschoal
May 03 2017 02:34
@Techievena there is no issue matching the PRs :(
Abinash Senapati
@Techievena
May 03 2017 02:35
You must be working on an issue right?
Tulio Leao
@tupaschoal
May 03 2017 02:36
Nope, I found out that those bears were missing these parameters and submitted the PR directly. I was told later that it is usual to start with an issue first :\
Abinash Senapati
@Techievena
May 03 2017 02:36
So just open up issues for them now and link them to the PRs.
Tulio Leao
@tupaschoal
May 03 2017 03:40
Done! Now both only have the review as pending :)
euleram
@vijeth-aradhya
May 03 2017 04:26
@Adrianzatreanu Have made different commits and most of the tests work :+1: With a little bit discussion: we can optimize and add more tests!
Zatreanu Adrian-Gabriel
@Adrianzatreanu
May 03 2017 11:31
Cool, will check later on @vijeth-aradhya
Vamshi Krishna
@Vamshi99
May 03 2017 13:04
@jayvdb Please review coala/coala-bears#1648 if you have time :grinning: