These are chat archives for coala/coala-bears

4th
May 2017
Vamshi Krishna
@Vamshi99
May 04 2017 14:29
@jayvdb gotype https://github.com/golang/tools/tree/master/cmd/gotype is back again, so we need not use your fork anymore. I changed that check it here coala/coala-bears#1494
John Vandenberg
@jayvdb
May 04 2017 14:33
Nice.
Vamshi Krishna
@Vamshi99
May 04 2017 14:44
:+1: Review please
John Vandenberg
@jayvdb
May 04 2017 15:44
@Vamshi99 and @Techievena ; both approved
@Vamshi99, a more detailed commit message would be better
Vamshi Krishna
@Vamshi99
May 04 2017 16:24
@jayvdb Changed it coala/coala-bears#1494 , needs reack and a merge
John Vandenberg
@jayvdb
May 04 2017 16:56
@Vamshi99 still needs rebase
Vamshi Krishna
@Vamshi99
May 04 2017 17:02
@jayvdb Done
Can't we use cherry-pick bot?
It took two more builds just to rebase and change commit message :worried:
John Vandenberg
@jayvdb
May 04 2017 17:13
possibly could; not sure it is ready yet
John Vandenberg
@jayvdb
May 04 2017 17:19
nobody else is using the build cycles atm, everyone is either weeping with joy or sadness at the moment
Vamshi Krishna
@Vamshi99
May 04 2017 17:21
Ah, okay. But, I just want to know how to use that, as it will be helpful and can I use it or only a maintainer can?
John Vandenberg
@jayvdb
May 04 2017 17:27
I have no idea. I assume only maintainers
Adhityaa
@adtac
May 04 2017 18:24
only maintainers yes
because the final PR needs to be merged by a maintainer anyway
Vamshi Krishna
@Vamshi99
May 04 2017 18:25
Do we have documentation for that @adtac
Adhityaa
@adtac
May 04 2017 18:26
it's still in development
but I assume we'll have some kind of documentation when we get it deployed
Vamshi Krishna
@Vamshi99
May 04 2017 18:27
Yeah, good to have it. And it is really helpful