These are chat archives for coala/coala-bears

5th
May 2017
John Vandenberg
@jayvdb
May 05 2017 02:53
cobot file issue coala-bears IndentationBear: Remove pragma no cover
It isnt necessary.
c.f. coala/coala-bears#1618
difficulty/newcomer
coala-bot
@coala-bot
May 05 2017 02:53
Here you go : coala/coala-bears#1709
John Vandenberg
@jayvdb
May 05 2017 03:00
cobot file issue coala-bears ClangCountingConditions: Remove two pragma no cover
We want to remove all #pragma: no cover c.f. coala/coala-bears#1618
Two of them in this file are not necessary.
Only one of them is necessary (c.f. coala/coala-bears#1710).
difficulty/newcomer
coala-bot
@coala-bot
May 05 2017 03:00
Here you go : coala/coala-bears#1711
Raghav Jindal
@ragvri
May 05 2017 04:16
Hi
John Vandenberg
@jayvdb
May 05 2017 04:16
hey!
Raghav Jindal
@ragvri
May 05 2017 04:16
Just wanted to make my first successful pull request
John Vandenberg
@jayvdb
May 05 2017 04:16
cobot inv ragvri
coala-bot
@coala-bot
May 05 2017 04:16

Welcome @ragvri! :tada:

To get started, please follow our newcomers guide. Most issues will be explained there and in linked pages - it will save you a lot of time, just read it. Really.

Do not take an issue if you don't understand it on your own. Especially if you are new you have to be aware that getting started with an open source community is not trivial: you will have to work hard and most likely become a better coder than you are now just as we all did.

Don't get us wrong: we are very glad to have you with us on this journey into open source! We will also be there for you at all times to help you with actual problems. :)

John Vandenberg
@jayvdb
May 05 2017 04:17
you should now have an email from GitHub
Raghav Jindal
@ragvri
May 05 2017 04:17
yes ... thanks for the invite
John Vandenberg
@jayvdb
May 05 2017 04:19
great. now I have assigned you to coala/coala-bears#1704
Raghav Jindal
@ragvri
May 05 2017 04:19
Thanks a lot :) I am really excited
John Vandenberg
@jayvdb
May 05 2017 04:21
ok, promise to not delete your fork again, or close a PR!?!
Raghav Jindal
@ragvri
May 05 2017 04:21
Yes sure.. I am really very sorry...I didn't know that it was a big deal. Please pardon me
John Vandenberg
@jayvdb
May 05 2017 04:23
ok.
what OS are you using?
Raghav Jindal
@ragvri
May 05 2017 04:23
Ubuntu
John Vandenberg
@jayvdb
May 05 2017 04:23
nice
ok, on your command line, type $ git commit --amend
it should open a text editor, possibly vi
yes?
Raghav Jindal
@ragvri
May 05 2017 04:24
yes it opened vi
John Vandenberg
@jayvdb
May 05 2017 04:25
do you know basic vi ?
Raghav Jindal
@ragvri
May 05 2017 04:25
yes
John Vandenberg
@jayvdb
May 05 2017 04:25
cool
ok, our commit guideline is at coala.io/commit
your first line should be: LicenseCheckBearTest: Use with to close file
then a blank line, and then on the last line put Fixes https://github.com/coala/coala-bears/issues/1704
save and close
Raghav Jindal
@ragvri
May 05 2017 04:26
done
John Vandenberg
@jayvdb
May 05 2017 04:27
great, now you need to force that amended commit into your existing PR. $ git push -f
Raghav Jindal
@ragvri
May 05 2017 04:28
warning: push.default is unset; its implicit value has changed in
Git 2.0 from 'matching' to 'simple'.
John Vandenberg
@jayvdb
May 05 2017 04:28
no worries
did it stop?
Raghav Jindal
@ragvri
May 05 2017 04:28
fatal: The current branch rjmessibarca has no upstream branch.
To push the current branch and set the remote as upstream, use
git push --set-upstream origin rjmessibarca
Should I use this command?
John Vandenberg
@jayvdb
May 05 2017 04:29
ok, let us check your remotes $ git remote -v
John Vandenberg
@jayvdb
May 05 2017 04:30
yup ok.. so then $ git push -f --set-upstream origin rjmessibarca
Raghav Jindal
@ragvri
May 05 2017 04:31
Done!
now we wait for the build bots to check everything
Raghav Jindal
@ragvri
May 05 2017 04:32
Ok thanks for your help. You are amazing
John Vandenberg
@jayvdb
May 05 2017 04:34
while we wait, you should add a remote: $ git remote add upstream https://github.com/coala/coala-bears
then see you have two remotes on $ git remote -v
Raghav Jindal
@ragvri
May 05 2017 04:34
yes
John Vandenberg
@jayvdb
May 05 2017 04:36
wait until the build bots are finished, then I'll help you make the changes requested at https://github.com/coala/coala-bears/pull/1712/commits/281dbf3b8ad365b10b244c16348e3457ffe0e351
Raghav Jindal
@ragvri
May 05 2017 04:36
I am getting changes requested in the pull request
Ok
John Vandenberg
@jayvdb
May 05 2017 04:36
doing the first PR slowly will help you see the process
Raghav Jindal
@ragvri
May 05 2017 04:37
yes..I am pumped up for the future
git push -f --set-upstream origin rjmessibarca Can you please tell me what does this do
According to me, the upstream was added later?
Vamshi Krishna
@Vamshi99
May 05 2017 04:41
Will it be nice if we have new channel for discussing git problems?
John Vandenberg
@jayvdb
May 05 2017 04:42
--set-upstream origin specified that for your branch called rjmessibarca, you want the push to always send it to the remote called origin
so now, when you are 'in' branch rjmessibarca, you can dogit push -f` and it will automatically know where to send it
Raghav Jindal
@ragvri
May 05 2017 04:43
oh
good to know
John Vandenberg
@jayvdb
May 05 2017 04:44
the remote called 'upstream' is unrelated. It is where you will fetch new code from, when PRs are merged
Raghav Jindal
@ragvri
May 05 2017 04:44
My commit is failing for 1 case :( and pending for 2
John Vandenberg
@jayvdb
May 05 2017 04:45
the CircleCI failure was a strange build problem not caused by you ... I have restarted the build, which should solve the problem.
Raghav Jindal
@ragvri
May 05 2017 04:51
Why did I need to use -f in git push?
John Vandenberg
@jayvdb
May 05 2017 04:58
when you did git commit --amend, you 'changed history' (in a very small way)
git lets you do that, and doesnt annoy you when you're changing history in your own repository on your computer
but, if you try to push a modified history to a server, the server will complain that you are modifying a public version
so you need to tell your client and the server than you know what you are doing, and you really want to publish a different commit
to do that, you using --force or -f
Raghav Jindal
@ragvri
May 05 2017 05:02
So if I understand you correct, the message that I wrote in commit should have created a new commit
To prevent that and applying the changes on the old commit we used -f
John Vandenberg
@jayvdb
May 05 2017 05:03
yes, instead of creating many commits, we only want one good commit
which requires amending the existing commit until it is good, and force pushing then to the server
each amended commit will have a different identifier
Raghav Jindal
@ragvri
May 05 2017 05:04
So for eg, if I have to make any changes to my branch after creating the pull request, I will have to just use git push -f origin rjmessibarca
Had I not set the --set upstream origin
John Vandenberg
@jayvdb
May 05 2017 05:05
git commit --amend; git push -f origin rjmessibarca
Raghav Jindal
@ragvri
May 05 2017 05:05
How can I view the identifiers you mentioned
John Vandenberg
@jayvdb
May 05 2017 05:05
the first command creates the new commit; the second publishes it
on coala/coala-bears#1712 , you will see 281dbf3
that is your current commit identifier
Raghav Jindal
@ragvri
May 05 2017 05:06
got it
git commit --amend just allows us to change the commit message?
John Vandenberg
@jayvdb
May 05 2017 05:06
$ git show will also show the identifier 281dbf3 (but it will have more digits on your computer)
git commit --amend allows you to change the contents and the commit message
git commit -a --amend is a quick way to include all modifications to files and update the commit message
Raghav Jindal
@ragvri
May 05 2017 05:08
What if I by chance create a new commit in my forked repo
But the pull request will need only one good commit
what to do then
John Vandenberg
@jayvdb
May 05 2017 05:10
if you have two commits, you can discard the top one using git reset HEAD~1
the changes will still be in your local copy
Raghav Jindal
@ragvri
May 05 2017 05:10
but won't the top one be the good commit?
John Vandenberg
@jayvdb
May 05 2017 05:10
and then git commit -a --amend to add those changes into the one good commit
if you have two commits, neither is a good commit
Raghav Jindal
@ragvri
May 05 2017 05:11
ok got it
any way to force open the git commit -a --amend in say pycharm?
John Vandenberg
@jayvdb
May 05 2017 05:12
no idea. ;-)
I use bash + vim
Raghav Jindal
@ragvri
May 05 2017 05:12
alright thanks a lot sir
John Vandenberg
@jayvdb
May 05 2017 05:12
I have not been knighted yet :P
Raghav Jindal
@ragvri
May 05 2017 05:12
do the checks usually take this much time
:stuck_out_tongue:
John Vandenberg
@jayvdb
May 05 2017 05:13
no, not usually ... I had to ask the Circle CI tests to be run without the cache , because there was a problem in the cache
usually 15 mins. without cache, 40 mins
Raghav Jindal
@ragvri
May 05 2017 05:14
Last question? Does joining a particular organisation like this one means I shouldn't be contributing to others. If a person is unable to contribute much , is he removed from the organisation?
John Vandenberg
@jayvdb
May 05 2017 05:15
no, you can be part of many organisations , and contribute as much or little as you want to each
not all projects require joining an organisation. coala has more 'process' than many projects, because we want to give newcomers a path to follow
Raghav Jindal
@ragvri
May 05 2017 05:16
wow this open source stuff seems to be amazing. I would be able to interact with highly advanced developers which would develop my skills also
John Vandenberg
@jayvdb
May 05 2017 05:16
I suggest you finish our newcomer process, then go look for other projects to play in
and then hopefully ... you come back to coala ;-)
Raghav Jindal
@ragvri
May 05 2017 05:17
I would love to stay here
The community seems very nice
John Vandenberg
@jayvdb
May 05 2017 05:31
ok, checks are all green
Raghav Jindal
@ragvri
May 05 2017 05:31
hurray
John Vandenberg
@jayvdb
May 05 2017 05:31
so now you can modify the code as requested
and then git commit -a --amend (no change to commit message) git push -f
Raghav Jindal
@ragvri
May 05 2017 05:32
got it
done
John Vandenberg
@jayvdb
May 05 2017 05:41
looks good
Raghav Jindal
@ragvri
May 05 2017 05:42
checks are running
should I now look at some low difficulty issues here. What do you recommend
John Vandenberg
@jayvdb
May 05 2017 05:55
merged
Raghav Jindal
@ragvri
May 05 2017 05:55
hooray
John Vandenberg
@jayvdb
May 05 2017 05:55
I recommend coala/coala-bears#1684 as a low issue
to do that, try to upgrade the requirement from 0.5.1 to 1.4 , and fix the test which is broken
Raghav Jindal
@ragvri
May 05 2017 05:56
ok...If I take up the issue, how much time do I have to fix it?
John Vandenberg
@jayvdb
May 05 2017 05:57
the python library safety has changed the constructor for Vulnerability
I think we'd like that fixed by about a month
Raghav Jindal
@ragvri
May 05 2017 05:58
Can I first have a detailed look at the issue before deciding if I would be able to do it
?
Just one question. If all the issues can be fixed by the advanced developers, do they leave the issues for the newcomers just to help us?
Adhityaa
@adtac
May 05 2017 06:08
some issues are marked newcomer so that you can get to know the process easily without getting bogged down with the difficulty of the problem itself
Raghav Jindal
@ragvri
May 05 2017 06:08
I just solved one such issue. Can I take another one?
Adhityaa
@adtac
May 05 2017 06:08
I recommend moving on to a difficulty/low issue
Raghav Jindal
@ragvri
May 05 2017 06:09
ok :)
Adhityaa
@adtac
May 05 2017 06:09
they're a tad more complicated than difficulty/newcomer, but they're still quite easy
John Vandenberg
@jayvdb
May 05 2017 06:20
@ragvri , yes, we create newcomer issues that are very easy. Which is why newcomers should only do one. So other newcomers have tasks to work on.
Creating newcomer issues is not easy, as we need to check it is an easy fix.
Raghav Jindal
@ragvri
May 05 2017 06:23
ohk...I didn't quite understand the issue you proposed me to solve. I don't know what to do there and what is the problem
John Vandenberg
@jayvdb
May 05 2017 06:27
you'll need to spend a bit of time looking at our safety bear. ask questions as you go, to make sure you are on the right path
jayvdb @jayvdb takes a nap
John Vandenberg
@jayvdb
May 05 2017 07:52
@ragvri , we also have a few repositories on gitlab, and you can do a 'newcomer' issue there also as it is a different workflow
John Vandenberg
@jayvdb
May 05 2017 08:06
if you want to do a gitlab newcomer, we need to add you to the team over on gitlab and assign it to you
John Vandenberg
@jayvdb
May 05 2017 18:40
@meetmangukiya replied re import sort
Meet Mangukiya
@meetmangukiya
May 05 2017 18:41
alright, thanks @jayvdb reverting those commits and see the tests..
John Vandenberg
@jayvdb
May 05 2017 18:42
and rebase ... and i'll merge it to get it off your plate.
Meet Mangukiya
@meetmangukiya
May 05 2017 18:43
:+1:
John Vandenberg
@jayvdb
May 05 2017 19:01
should i wait up for the push, or go to bed and ... it waits another week ..? ;-)
jayvdb @jayvdb is in a merging mood
Meet Mangukiya
@meetmangukiya
May 05 2017 19:02
uhmm.. building will take 1/2 hour
so depends upon you ;)
John Vandenberg
@jayvdb
May 05 2017 19:02
im happy to wait if I know it is going to happen
but I dont see the push yet
Meet Mangukiya
@meetmangukiya
May 05 2017 19:02
5-10 minutes..
John Vandenberg
@jayvdb
May 05 2017 19:03
kk
Meet Mangukiya
@meetmangukiya
May 05 2017 19:04
I'm gonna be sad if the builds fail as you pointed out
oh my!
John Vandenberg
@jayvdb
May 05 2017 19:07
hmm?
Meet Mangukiya
@meetmangukiya
May 05 2017 19:07
it fails, I am pushing now, but you might as well go to sleep
John Vandenberg
@jayvdb
May 05 2017 19:08
why does it fail??
Meet Mangukiya
@meetmangukiya
May 05 2017 19:08
yields a result when it shouldn't
John Vandenberg
@jayvdb
May 05 2017 19:08
in your new tests or the old tests ? ;-)
Meet Mangukiya
@meetmangukiya
May 05 2017 19:09
old
I broke 2 tests
John Vandenberg
@jayvdb
May 05 2017 19:14
easy to fix, or not?
ill check in 15 mins ;-)
meetmangukiya @meetmangukiya is still checking what went wrong
Meet Mangukiya
@meetmangukiya
May 05 2017 19:19
IIRC there was some setting that was not being passed...
not related
I see what is causing this
Meet Mangukiya
@meetmangukiya
May 05 2017 19:24

in this PR I seperate bunches of imports...

import x
import y

import z
import e

here, x and y are passed to the isort differently than z and e.

I'm not sure what to do
nah, that shouldn't matter
default is False, so it is like before only in that case..
meetmangukiya @meetmangukiya goes back debugging again, will be back soon
Meet Mangukiya
@meetmangukiya
May 05 2017 19:41
gotcha
I mean the deletion is
addition is related change
everything's working now
anyways you may go to sleep @jayvdb merge tomorrow, no hurry ;) Good Night