cobot file issue coala-bears IndentationBear: Remove pragma no cover
It isnt necessary.
c.f. coala/coala-bears#1618
difficulty/newcomer
It isnt necessary.
c.f. coala/coala-bears#1618
difficulty/newcomer
Here you go : coala/coala-bears#1709
cobot file issue coala-bears ClangCountingConditions: Remove two pragma no cover
We want to remove all
Two of them in this file are not necessary.
Only one of them is necessary (c.f. coala/coala-bears#1710).
difficulty/newcomer
We want to remove all
#pragma: no cover c.f. coala/coala-bears#1618Two of them in this file are not necessary.
Only one of them is necessary (c.f. coala/coala-bears#1710).
difficulty/newcomer
Here you go : coala/coala-bears#1711
Hi
hey!
Just wanted to make my first successful pull request
cobot inv ragvri
Welcome @ragvri! :tada:
To get started, please follow our newcomers guide. Most issues will be explained there and in linked pages - it will save you a lot of time, just read it. Really.
Do not take an issue if you don't understand it on your own. Especially if you are new you have to be aware that getting started with an open source community is not trivial: you will have to work hard and most likely become a better coder than you are now just as we all did.
Don't get us wrong: we are very glad to have you with us on this journey into open source! We will also be there for you at all times to help you with actual problems. :)
you should now have an email from GitHub
yes ... thanks for the invite
great. now I have assigned you to coala/coala-bears#1704
Thanks a lot :) I am really excited
ok, promise to not delete your fork again, or close a PR!?!
Yes sure.. I am really very sorry...I didn't know that it was a big deal. Please pardon me
ok.
what OS are you using?
Ubuntu
nice
ok, on your command line, type $
git commit --amend
it should open a text editor, possibly vi
yes?
yes it opened vi
do you know basic vi ?
yes
cool
ok, our commit guideline is at coala.io/commit
your first line should be:
LicenseCheckBearTest: Use with to close file
then a blank line, and then on the last line put
Fixes https://github.com/coala/coala-bears/issues/1704
save and close
done
great, now you need to force that amended commit into your existing PR. $
git push -f
warning: push.default is unset; its implicit value has changed in
Git 2.0 from 'matching' to 'simple'.
Git 2.0 from 'matching' to 'simple'.
no worries
did it stop?
fatal: The current branch rjmessibarca has no upstream branch.
To push the current branch and set the remote as upstream, use
To push the current branch and set the remote as upstream, use
git push --set-upstream origin rjmessibarca
Should I use this command?
ok, let us check your remotes $
git remote -v
origin https://github.com/ragvri/coala-bears.git (fetch)
origin https://github.com/ragvri/coala-bears.git (push)
origin https://github.com/ragvri/coala-bears.git (push)
yup ok.. so then $
git push -f --set-upstream origin rjmessibarca
Done!
now we wait for the build bots to check everything
Ok thanks for your help. You are amazing
https://github.com/coala/coala-bears/pull/1712/commits/281dbf3b8ad365b10b244c16348e3457ffe0e351 Do I need to make changes again according to the message?
while we wait, you should add a remote: $
git remote add upstream https://github.com/coala/coala-bears
then see you have two remotes on $
git remote -v
yes
wait until the build bots are finished, then I'll help you make the changes requested at https://github.com/coala/coala-bears/pull/1712/commits/281dbf3b8ad365b10b244c16348e3457ffe0e351
I am getting
changes requested in the pull request
Ok
doing the first PR slowly will help you see the process
yes..I am pumped up for the future
git push -f --set-upstream origin rjmessibarca Can you please tell me what does this do
According to me, the upstream was added later?
Will it be nice if we have new channel for discussing git problems?
--set-upstream origin specified that for your branch called rjmessibarca, you want the push to always send it to the remote called origin
so now, when you are 'in' branch
rjmessibarca, you can dogit push -f` and it will automatically know where to send it
oh
good to know
the remote called 'upstream' is unrelated. It is where you will fetch new code from, when PRs are merged
My commit is failing for 1 case :( and pending for 2
the CircleCI failure was a strange build problem not caused by you ... I have restarted the build, which should solve the problem.
Why did I need to use
-f in git push?
when you did
git commit --amend, you 'changed history' (in a very small way)
git lets you do that, and doesnt annoy you when you're changing history in your own repository on your computer
but, if you try to push a modified history to a server, the server will complain that you are modifying a public version
so you need to tell your client and the server than you know what you are doing, and you really want to publish a different commit
to do that, you using
--force or -f
So if I understand you correct, the message that I wrote in commit should have created a new commit
To prevent that and applying the changes on the old commit we used
-f
yes, instead of creating many commits, we only want one good commit
which requires amending the existing commit until it is good, and force pushing then to the server
each amended commit will have a different identifier
So for eg, if I have to make any changes to my branch after creating the pull request, I will have to just use
git push -f origin rjmessibarca
Had I not set the
--set upstream origin
git commit --amend; git push -f origin rjmessibarca
How can I view the identifiers you mentioned
the first command creates the new commit; the second publishes it
on coala/coala-bears#1712 , you will see
281dbf3
that is your current commit identifier
got it
git commit --amend just allows us to change the commit message?
$
git show will also show the identifier 281dbf3 (but it will have more digits on your computer)
git commit --amend allows you to change the contents and the commit message
git commit -a --amend is a quick way to include all modifications to files and update the commit message
What if I by chance create a new commit in my forked repo
But the pull request will need only one good commit
what to do then
if you have two commits, you can discard the top one using
git reset HEAD~1
the changes will still be in your local copy
but won't the top one be the good commit?
and then
git commit -a --amend to add those changes into the one good commit
if you have two commits, neither is a good commit
ok got it
any way to force open the
git commit -a --amend in say pycharm?
no idea. ;-)
I use bash + vim
alright thanks a lot sir
I have not been knighted yet :P
do the checks usually take this much time
:stuck_out_tongue:
no, not usually ... I had to ask the Circle CI tests to be run without the cache , because there was a problem in the cache
usually 15 mins. without cache, 40 mins
Last question? Does joining a particular organisation like this one means I shouldn't be contributing to others. If a person is unable to contribute much , is he removed from the organisation?
no, you can be part of many organisations , and contribute as much or little as you want to each
not all projects require joining an organisation. coala has more 'process' than many projects, because we want to give newcomers a path to follow
wow this open source stuff seems to be amazing. I would be able to interact with highly advanced developers which would develop my skills also
I suggest you finish our newcomer process, then go look for other projects to play in
and then hopefully ... you come back to coala ;-)
I would love to stay here
The community seems very nice
ok, checks are all green
hurray
so now you can modify the code as requested
and then
git commit -a --amend (no change to commit message) git push -f
got it
done
looks good
checks are running
should I now look at some low difficulty issues here. What do you recommend
merged
hooray
I recommend coala/coala-bears#1684 as a low issue
to do that, try to upgrade the requirement from 0.5.1 to 1.4 , and fix the test which is broken
ok...If I take up the issue, how much time do I have to fix it?
the python library
safety has changed the constructor for Vulnerability
I think we'd like that fixed by about a month
Can I first have a detailed look at the issue before deciding if I would be able to do it
?
Just one question. If all the issues can be fixed by the advanced developers, do they leave the issues for the newcomers just to help us?
some issues are marked newcomer so that you can get to know the process easily without getting bogged down with the difficulty of the problem itself
I just solved one such issue. Can I take another one?
I recommend moving on to a difficulty/low issue
ok :)
they're a tad more complicated than difficulty/newcomer, but they're still quite easy
@ragvri , yes, we create newcomer issues that are very easy. Which is why newcomers should only do one. So other newcomers have tasks to work on.
Creating newcomer issues is not easy, as we need to check it is an easy fix.
ohk...I didn't quite understand the issue you proposed me to solve. I don't know what to do there and what is the problem
you'll need to spend a bit of time looking at our safety bear. ask questions as you go, to make sure you are on the right path
jayvdb @jayvdb takes a nap
@ragvri , we also have a few repositories on gitlab, and you can do a 'newcomer' issue there also as it is a different workflow
if you want to do a gitlab newcomer, we need to add you to the team over on gitlab and assign it to you
@meetmangukiya replied re import sort
alright, thanks @jayvdb reverting those commits and see the tests..
and rebase ... and i'll merge it to get it off your plate.
:+1:
should i wait up for the push, or go to bed and ... it waits another week ..? ;-)
jayvdb @jayvdb is in a merging mood
uhmm.. building will take 1/2 hour
so depends upon you ;)
im happy to wait if I know it is going to happen
but I dont see the push yet
5-10 minutes..
kk
I'm gonna be sad if the builds fail as you pointed out
oh my!
hmm?
it fails, I am pushing now, but you might as well go to sleep
why does it fail??
yields a result when it shouldn't
in your new tests or the old tests ? ;-)
old
I broke 2 tests
easy to fix, or not?
ill check in 15 mins ;-)
meetmangukiya @meetmangukiya is still checking what went wrong
IIRC there was some setting that was not being passed...
not related
I see what is causing this
in this PR I seperate bunches of imports...
import x
import y
import z
import ehere, x and y are passed to the isort differently than z and e.
I'm not sure what to do
nah, that shouldn't matter
default is False, so it is like before only in that case..
meetmangukiya @meetmangukiya goes back debugging again, will be back soon
gotcha
this is unrelated change https://github.com/coala/coala-bears/pull/1356/files#diff-5e8588b5c404714ed41f87c0ef1a0657L176
I mean the deletion is
addition is related change
everything's working now
anyways you may go to sleep @jayvdb merge tomorrow, no hurry ;) Good Night