These are chat archives for coala/coala-bears

18th
May 2017
Tulio Leao
@tupaschoal
May 18 2017 01:30
When can I expect coala/coala-bears#1735 to be pushed? It was already approved on coala/coala-bears#1622
John Vandenberg
@jayvdb
May 18 2017 02:53
a new pr to cherry pick is silly
Esp. If it isnt merged immediately
@tupaschoal , can you rebase your pr and ping me when it passes, ill merge immediately
John Vandenberg
@jayvdb
May 18 2017 04:03
@Techievena , also , coala/coala-bears#1438 should be rebase-able.
Adhityaa
@adtac
May 18 2017 05:11
we can't really rebase a PR without cherry-picking it
unless it's on coala/
instead of a fork
but yeah, you're right, a PR just to rebase is kinda silly (but it can work that way)
John Vandenberg
@jayvdb
May 18 2017 05:12
the default is to allow 'maintainers' to push to the branch on the fork
the bot just needs to be added to the group
Adhityaa
@adtac
May 18 2017 05:13
it is a maintainer
maintainers can push to fork branches?
John Vandenberg
@jayvdb
May 18 2017 05:13
yes
Adhityaa
@adtac
May 18 2017 05:13
I didn't know that
John Vandenberg
@jayvdb
May 18 2017 05:13
can you stop your bot from spamming coala/coala-bears#1622
Adhityaa
@adtac
May 18 2017 05:13
eeesh sorry
I'm stopping the bot altogether
John Vandenberg
@jayvdb
May 18 2017 05:13

I didn't know that

but I've mentioned this before

Adhityaa
@adtac
May 18 2017 05:14
ok my memory is abysmal
John Vandenberg
@jayvdb
May 18 2017 05:14
specifically, IMO, it should only be a rebase bot until it has mastered that more simple scenario first
Adhityaa
@adtac
May 18 2017 05:15
the bot is now down
I'll add a @cherry-pick-bot rebase that'll simply re base the same branch
in the same PR
John Vandenberg
@jayvdb
May 18 2017 05:16
and also we have much more use for a rebase bot than a cherry-pick bot, and rebasing keeps the PR as a "merged PR" instead of a "closed PR", the latter being colored red and not particularly nice to newcomers who what a proper GitHub purple PR to indicate they've 'done it'
maybe that could be a new username
Adhityaa
@adtac
May 18 2017 05:17
tbh if we have a rebase bot we don't need a cherry-pick-bot at all
and as you say PRs won't be closed on merge
that bot looks just like what we need
John Vandenberg
@jayvdb
May 18 2017 05:19
there are also others
John Vandenberg
@jayvdb
May 18 2017 05:38
cobot file issue coala-bears HTMLLintBear: Disable tabs rule when use_spaces = False
By default HTMLLintBear emits an error if tabs are found.
When use_spaces is disabled, this HTMLLintBear error should be disabled.
c.f. coala/coala-bears#844
difficulty/low
coala-bot
@coala-bot
May 18 2017 05:38
Here you go : coala/coala-bears#1741
John Vandenberg
@jayvdb
May 18 2017 07:24
cobot file issue coala-quickstart DuplicateFileBear is activated for a single file
DuplicateFileBear will be added into a section that has only one matching file causing an error "You included only one file"
difficulty/low importance/high
coala-bot
@coala-bot
May 18 2017 07:25
Here you go : coala/coala-quickstart#91
John Vandenberg
@jayvdb
May 18 2017 14:12
cobot file issue coala-bears SCSSLintBear: docstring param allow_important_rule_in_property is incorrect
It should be allow_important_rule_in_properties to match the arg
difficulty/newcomer
coala-bot
@coala-bot
May 18 2017 14:12
Here you go : coala/coala-bears#1744
John Vandenberg
@jayvdb
May 18 2017 14:15
cobot file issue coala-bears PyCommentedCodeBear: Confusing name
Commented code is good; Commented out code is bad.
Bear name needs to be deprecated.
status/blocked
coala-bot
@coala-bot
May 18 2017 14:15
Here you go : coala/coala-bears#1745
John Vandenberg
@jayvdb
May 18 2017 14:16
cobot file issue coala-bears PyDocStyleBear: Detect docstring params without a matching arg
e.g. coala/coala-bears#1744
difficulty/medium
coala-bot
@coala-bot
May 18 2017 14:16
Here you go : coala/coala-bears#1746
John Vandenberg
@jayvdb
May 18 2017 15:44
jayvdb @jayvdb heads to bed