These are chat archives for coala/coala-bears

26th
May 2017
Avi Aryan
@aviaryan
May 26 2017 02:52
@jayvdb coala/coala-bears#1727 ready
^^ @userzimmermann
John Vandenberg
@jayvdb
May 26 2017 03:35
@aviaryan , I think you want something like CAN_FIX = {'Formatting', 'Complexity'} cc: @userzimmermann , @adhikasp , @Techievena
Avi Aryan
@aviaryan
May 26 2017 03:37
The simplify command does only very minor improvements in the code.. So should be add Complexity for that ?
John Vandenberg
@jayvdb
May 26 2017 03:39
ya, im not sure that is the best aspect to use
@meetmangukiya, can you refresh your relnotes patch and merge it pls
Avi Aryan
@aviaryan
May 26 2017 03:41
'code complexity' when googled returns 'Cyclomatic complexity' which is not something which gofmt cares about.
John Vandenberg
@jayvdb
May 26 2017 03:41
@aviaryan , there is also aspect Code Simplification used by CSecurityBear, and a few other bears, so ... ya ... that is better
Avi Aryan
@aviaryan
May 26 2017 03:42
I'll prefer that over Complexity. Yes !!
John Vandenberg
@jayvdb
May 26 2017 03:44
@yash-nisar , this looks like a bug which will affect our bear : hhatto/autopep8#315
John Vandenberg
@jayvdb
May 26 2017 03:52
@aviaryan , thx. will be merged this time ;-) now you might like to go to https://github.com/coala/meta/wiki and get ready to modify the 'Go' rows to mention that Code Simplification is now possible
@aviaryan , argh, you forgot to rebase ;-)
Avi Aryan
@aviaryan
May 26 2017 03:59
@jayvdb I had rebased yesterday before the last 2 commits were added. Let me just do it again.
John Vandenberg
@jayvdb
May 26 2017 04:02
If you like adding fixing support, you may want to tackle coala/coala-bears#1771 next ;-)
and we need to find a tool which can fix Java too
Avi Aryan
@aviaryan
May 26 2017 04:04
There is an issue with IndentationBear where it fails to ignore comments from its checkup. Do you know more about that?
John Vandenberg
@jayvdb
May 26 2017 04:04
the 'ignore comments' part depends on the language. coala doesnt have comment detection for all languages yet
so, which language did you experience this in ?
Avi Aryan
@aviaryan
May 26 2017 04:05
I tried it in C and comments were being wrongly detected.
Do you mean there is a param to avoid that?
John Vandenberg
@jayvdb
May 26 2017 04:06
you might need to add language = C to your .coafile for that section
if you had that, then you've (probably) found a bug and we need to investigate it
Avi Aryan
@aviaryan
May 26 2017 04:07
No I didn't had that. 😅
coala-bot
@coala-bot
May 26 2017 04:19
coala is always written with a lower case c. :anguished:
Avi Aryan
@aviaryan
May 26 2017 04:20
/* My Code
 * more comment
 */

/* Coala suggests
* more comment
*/
coala-bot
@coala-bot
May 26 2017 04:20
coala is always written with a lower case c. :frowning:
Avi Aryan
@aviaryan
May 26 2017 04:22
😅. I am not sure if this is relevant but for IndentationBear (use_spaces=False) it suggests to remove single space indentation for comments which I think is a very popular style IMO.
John Vandenberg
@jayvdb
May 26 2017 04:22
ahh, a formatting problem. Yes, raise a bug ;-) @damngamerz who is doing a comments related project
John Vandenberg
@jayvdb
May 26 2017 04:31
and merged
Avi Aryan
@aviaryan
May 26 2017 04:34
@jayvdb I'll open an issue for that. Btw, how do I contribute to the wiki ? Something like this
John Vandenberg
@jayvdb
May 26 2017 04:35
@aviaryan , you should be able to edit the wiki on github web interface
Avi Aryan
@aviaryan
May 26 2017 04:37
@jayvdb No, I can't.
John Vandenberg
@jayvdb
May 26 2017 04:39
fixed
Avi Aryan
@aviaryan
May 26 2017 04:40
:+1: works
@jayvdb Wiki updated
John Vandenberg
@jayvdb
May 26 2017 04:45
:+1: Go is also on https://github.com/coala/meta/wiki/Travis-CI-Languages , but that page is mostly not filled in yet
Avi Aryan
@aviaryan
May 26 2017 04:52
@jayvdb Saw that. Would have loved to help but now I have got to do my day job now. Cheers.
John Vandenberg
@jayvdb
May 26 2017 04:54
no problems, and thanks
Avi Aryan
@aviaryan
May 26 2017 04:54
btw, issue opened coala/coala-bears#1772
:smile:
Meet Mangukiya
@meetmangukiya
May 26 2017 05:47
@jayvdb done :+1:
John Vandenberg
@jayvdb
May 26 2017 07:05
I'd be very grateful for reviews of coala/coala-bears#1769
should just be moving code into different files.
nothing 'changes'.
Meet Mangukiya
@meetmangukiya
May 26 2017 07:06
we don't use linelimit in shell scripts?
John Vandenberg
@jayvdb
May 26 2017 07:07
do you mean LineLengthBear or ShellCheckBear , or something else ?
Meet Mangukiya
@meetmangukiya
May 26 2017 07:07
linelength
+# Tailor (Swift) commands lol
I seen once, looks fine, but am not good with sh scripts so can't ack
Naman Maheshwari
@naman1901
May 26 2017 09:24
was hacking on the HappinessLintBear, got an error saying happiness isn't installed. Did npm install happiness, but that doesnt help. Any ideas?
I'm currently working on Windows 10, will shift to Ubuntu soon enough.
John Vandenberg
@jayvdb
May 26 2017 09:24
you need to find where it installed happiness. and add it to your PATH
probably node_modules/.bin
John Vandenberg
@jayvdb
May 26 2017 09:31
@damngamerz , I dont see an issue on either commit
Naman Maheshwari
@naman1901
May 26 2017 09:31
As it turns out, it wasn't installed in the global directory because I forgot the -g flag
John Vandenberg
@jayvdb
May 26 2017 09:32
@damngamerz , I thought I answered the question your raised at https://github.com/coala/coala-bears/pull/1506#issuecomment-294283873 , but now I cant find my answer :/
Saurav Singh
@damngamerz
May 26 2017 09:33
@jayvdb https://github.com/coala/coala-bears/pull/1506#issuecomment-303641889 this is exactly what you want I guess.... Im getting a test failure just need to fix that and its good to go.
Naman Maheshwari
@naman1901
May 26 2017 09:34
cobot assign coala/coala-bears#1754
coala-bot
@coala-bot
May 26 2017 09:34
:tada: You have been assigned to coala/coala-bears#1754
John Vandenberg
@jayvdb
May 26 2017 10:00
@damngamerz yea, it does look good. will review when you get the build working. also rebase.
Saurav Singh
@damngamerz
May 26 2017 10:39
^It's ready coala/coala-bears#1506
builds green :tada:
John Vandenberg
@jayvdb
May 26 2017 10:51
get in line whipper snapper :P
merging mine first
ill review yours in about an hour
doing a bit of house renovation atm
hell this was painful
we need a bear to for autowrapping -phew-
Naman Maheshwari
@naman1901
May 26 2017 11:08
been trying to run HappinessLintBearTest. Any idea why it fails even in the version I pulled from git, without making any changes
I had it passing from one directory in windows
fails from another directory and in Ubuntu
I made copies in different directories

E AssertionError: 0 == 0 : The local bear 'HappinessLintBear' yields no result although it should. E Running bear HappinessLintBear... E Running 'happiness /tmp/tmpeh4ox853'

Excerpt from the logs

John Vandenberg
@jayvdb
May 26 2017 11:44
@meetmangukiya @Mixih what happens if there is no issue - do your relnotes scripts skip it ? coala/coala-bears#1506
Meet Mangukiya
@meetmangukiya
May 26 2017 11:45
we don't have any relnote generating scripts yet
John Vandenberg
@jayvdb
May 26 2017 11:45
not generating, but analysis
Meet Mangukiya
@meetmangukiya
May 26 2017 11:46
I didn't use any scripts for analyzing either, just the raw git log
maybe mixih uses some
Meet Mangukiya
@meetmangukiya
May 26 2017 11:52
@Mixih do you use any scripts to analyze the logs while writing rel notes? \
John Vandenberg
@jayvdb
May 26 2017 13:07
Anyone wanting to play with Travis and OSX : coala/coala-bears#1327
mixih
@Mixih
May 26 2017 13:10
well I had a simple parse by regex thingy
John Vandenberg
@jayvdb
May 26 2017 13:14
@Mixih , did it look at issue urls ?
mixih
@Mixih
May 26 2017 13:15
no
the more sophisticated one I'm working on would have the option
Yash Nisar
@yash-nisar
May 26 2017 14:16
@jayvdb I'm busy with the gsoc work ATM, will look into it when I get some time :wink:
John Vandenberg
@jayvdb
May 26 2017 14:17
well it would mean that a bear setting doesnt work, which is what your gsoc community bonding time should be finding
@Josiah-DuBose , @Techievena , now is a good time to rebase.
Saurav Singh
@damngamerz
May 26 2017 16:40
@jayvdb For coala/coala-bears#1506 Do i only have to add CAN_FIX to DocStyleBear ? or anything else also needs to be?
John Vandenberg
@jayvdb
May 26 2017 16:50
:P
Saurav Singh
@damngamerz
May 26 2017 16:55
damn you :P
John Vandenberg
@jayvdb
May 26 2017 16:55
ask and ye shall receive
damngamerz @damngamerz goes back to work on a new patch
Saurav Singh
@damngamerz
May 26 2017 16:55
w8 there's one more which is ready
coala/coala#4275
John Vandenberg
@jayvdb
May 26 2017 16:58
thx
Saurav Singh
@damngamerz
May 26 2017 21:02
@jayvdb coala/coala-bears#1506
Hope this is final cycle :see_no_evil:
John Vandenberg
@jayvdb
May 26 2017 23:42
Checks failed.
Im on mobile only today. Try to get one of your mentors to do a review. Ill be able to look carefully in 12 hrs.