These are chat archives for coala/coala-bears

8th
Jun 2017
John Vandenberg
@jayvdb
Jun 08 2017 09:41
@damngamerz , do you have another pr for me to review?
Saurav Singh
@damngamerz
Jun 08 2017 09:41
yup
coala/coala#4281
coala/coala-bears#1506
jayvdb @jayvdb crosses fingers hoping @yash-nisar can fix the docker himself.. :)
John Vandenberg
@jayvdb
Jun 08 2017 09:43
We should probably have docker repo intergration in here
Yash Nisar
@yash-nisar
Jun 08 2017 09:43
Trying my best @jayvdb :wink: , may take some time since I'm new to docker
John Vandenberg
@jayvdb
Jun 08 2017 10:06
@userzimmermann , can you please review https://gitlab.com/coala/package_manager/merge_requests/91 ; we need it for coala/coala-bears#1669 , which is needed for coala/coala-bears#1000 , which is sorely needed by (Windows) users who do not want to have to install libxml2 headers and all sorts of other python package dependencies when they dont use those bears
John Vandenberg
@jayvdb
Jun 08 2017 10:16
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:19
@Makman2 I started to play with @linter to get also class members into autodoc-generated docs... but not with much success so far...
@jayvdb I will review asap
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:45
@jayvdb @yash-nisar Solved the docs issue on CircleCI! :tada:
Yash Nisar
@yash-nisar
Jun 08 2017 10:45
Woah :tada:
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:45
was really just the outdated python 3.5.1
switched circle ubuntu version from 12 to 14
for coala-bears
and switched to python 3.6.1
now everything works :)
Yash Nisar
@yash-nisar
Jun 08 2017 10:46
That was a difficult catch
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:46
OH YEAH :smile:
will cleanup the PR now a bit and then please ack and merge ;)
Yash Nisar
@yash-nisar
Jun 08 2017 10:48
Sure :smile:
John Vandenberg
@jayvdb
Jun 08 2017 10:54
Err ... Circle Ubuntu 14 is very slow
do not ack and merge!
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:54
but the only chance!
and for my PR it was not slower than before
John Vandenberg
@jayvdb
Jun 08 2017 10:55
we need to make that decision carefully .. maybe just removing Circle CI might be better
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:55
with ubuntu 12 we are always stuck with python 3.5.1
John Vandenberg
@jayvdb
Jun 08 2017 10:55
@userzimmermann , your build was cached
@userzimmermann , you can switch to other versions of Python ! :/
pyenv to the rescue
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:56
but not > 3.5.1
py > 3.5.1 is just not there
in their ubuntu 12 image
that's the problem
John Vandenberg
@jayvdb
Jun 08 2017 10:56
pyenv has the latest.
who cares. Circle is just a VM
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:57
then tell me how to get a higher py version installed :)
John Vandenberg
@jayvdb
Jun 08 2017 10:57
anyway .. I'll look into it now
Stefan Zimmermann
@userzimmermann
Jun 08 2017 10:57
in their ubuntu 12
coala/coala-bears#1819
I only have to put the circle stuff into a separate commit
@jayvdb ^
not that you complain about that ;)
Yash Nisar
@yash-nisar
Jun 08 2017 11:40
Need help with https://travis-ci.org/yash-nisar/docker-coala-base/builds/240711080#L2027 @jayvdb , pasted the wrong link first !
John Vandenberg
@jayvdb
Jun 08 2017 11:50
@damngamerz , did you add tests for tabs in coala/coala-bears#1506 ?
Yash Nisar
@yash-nisar
Jun 08 2017 11:52
@jayvdb tried removing node_modules and doing before the npm install but didn't work
Saurav Singh
@damngamerz
Jun 08 2017 11:53
Yup let me add a comment in next update patch
Yash Nisar
@yash-nisar
Jun 08 2017 11:53
Also, we don't have node-fetch-npm doesn't exist in our package.json so some other issue
of the coala-bears dir
Yash Nisar
@yash-nisar
Jun 08 2017 12:02
Any suggestions @jayvdb ??
John Vandenberg
@jayvdb
Jun 08 2017 12:07
Will look in 10 mins
Yash Nisar
@yash-nisar
Jun 08 2017 12:08
nodejs/node#9355 may help
John Vandenberg
@jayvdb
Jun 08 2017 12:20
interesting - our last green docker build doesnt mention node-fetch-npm
@yash-nisar , can you try a verbose npm, or print out the debug log
Yash Nisar
@yash-nisar
Jun 08 2017 12:32
may be a dependency for other npm packages
John Vandenberg
@jayvdb
Jun 08 2017 12:32
@userzimmermann two comments on coala/coala-bears#1819
Yash Nisar
@yash-nisar
Jun 08 2017 12:32
trying out verbose npm
John Vandenberg
@jayvdb
Jun 08 2017 12:53
@yash-nisar two questions on coala/coala-bears#1569
John Vandenberg
@jayvdb
Jun 08 2017 13:02
@yash-nisar , the NPM problems have nothing to do with the Zypper problems - please create a separate problem for NPM
Yash Nisar
@yash-nisar
Jun 08 2017 13:02
okay :+1:
Any hints to proceed with this NPM problem ?
John Vandenberg
@jayvdb
Jun 08 2017 13:03
ill look when there is an separate issue I can comment on
Yash Nisar
@yash-nisar
Jun 08 2017 13:05
Here -> coala/docker-coala-base#182
Yash Nisar
@yash-nisar
Jun 08 2017 13:17
@jayvdb ^^
Stefan Zimmermann
@userzimmermann
Jun 08 2017 13:41
@jayvdb @yash-nisar YEEHA ;P coala/coala-bears#1819 works by just switching to Python 3.4.3 for building docs in Circle :) ACK ACK MERGE MERGE please
John Vandenberg
@jayvdb
Jun 08 2017 13:43
it is still marked as a WIP
John Vandenberg
@jayvdb
Jun 08 2017 14:03
@damngamerz , another patch for DocumentationStyleBear coming soon?
Mischa Krüger
@Makman2
Jun 08 2017 14:13
@userzimmermann though what do you want to document there specifically? :O
Stefan Zimmermann
@userzimmermann
Jun 08 2017 14:37
@jayvdb @yash-nisar YEEHA... again :smile: Now coala/coala-bears#1819 should be really really fine... Please! ;P
@Makman2 Where? ;)
Mischa Krüger
@Makman2
Jun 08 2017 14:38

@userzimmermann

@Makman2 I started to play with @linter to get also class members into autodoc-generated docs... but not with much success so far...

Saurav Singh
@damngamerz
Jun 08 2017 14:46
Yup i will do it late night... Not at home right now
John Vandenberg
@jayvdb
Jun 08 2017 14:53
ok
Stefan Zimmermann
@userzimmermann
Jun 08 2017 17:15
@Makman2 Aaah :) Let's take sphinx autodoc of PEP8Bear:
class bears.python.PEP8Bear.PEP8Bear(section: coalib.settings.Section.Section, message_queue, timeout=0)
Bases: coalib.bears.LocalBear.LocalBear

AUTHORS = {‘The coala developers’}
AUTHORS_EMAILS = {‘coala-devel@googlegroups.com’}
CAN_FIX = {‘Formatting’}
LANGUAGES = {‘Python 2’, ‘Python 3’, ‘Python’}
LICENSE = ‘AGPL-3.0’
REQUIREMENTS = {<PipRequirement object(package=’autopep8’, repo=’‘, REQUIREMENTS={<ExecutableRequirement object(executable=’c:\users\zimmermann\miniconda3\envs\coala\python.exe’, package=’c:\users\zimmermann\miniconda3\envs\coala\python.exe’, repo=’‘, REQUIREMENTS={}, type=’exec’, version=’‘)>}, type=’pip’, version=‘1.2’)>}
run(filename, file, max_line_length: int = 79, indent_size: int = 4, pep_ignore: typed_list(str) = (), pep_select: typed_list(str) = (), local_pep8_config: bool = False)
Detects and fixes PEP8 incompliant code. This bear will not change functionality of the code in any way.

Parameters:    
max_line_length – Maximum number of characters for a line.
indent_size – Number of spaces per indentation level.
pep_ignore – A list of errors/warnings to ignore.
pep_select – A list of errors/warnings to exclusively apply.
local_pep8_config – Set to true if autopep8 should use a config file as if run normally from this directory.
everything there
Now... hmm... CPPCheckBear:
autodoc:
class bears.c_languages.CPPCheckBear.CPPCheckBear(section: coalib.settings.Section.Section, message_queue, timeout=0)
Bases: bears.c_languages.CPPCheckBear.CPPCheckBear, coalib.bearlib.abstractions.Linter.LocalLinterBase

Report possible security weaknesses for C/C++. For more information, consult <https://github.com/danmar/cppcheck>.
that's it :/
because @linter creates a new subclass
and autodoc only automatically lists the class' own members
that's the problem
@Makman2 ^
Mischa Krüger
@Makman2
Jun 08 2017 18:09
ah that's what you mean
@userzimmermann
yeah cool try to fix that :D
Saurav Singh
@damngamerz
Jun 08 2017 18:44
@jayvdb updated both DocStyleBear and :raises PR
Stefan Zimmermann
@userzimmermann
Jun 08 2017 18:56
@Makman2 Should be your job ;P But it somehow challenges me... :smile:
I will try a bit more...