These are chat archives for coala/coala-bears

24th
Jun 2017
John Vandenberg
@jayvdb
Jun 24 2017 11:20
note we still have some timeout problems whilst installing language-check : coala/coala-bears#1865 ; they should be fewer than before
John Vandenberg
@jayvdb
Jun 24 2017 11:31
@mridubhatnagar , could you rebase coala/coala-bears#1844 please
@danlls @horczech @DNSGeek you have a patch that is approved. Could you please rebase your patch, and then when it passes CI ping me or another maintainer here in gitter to merge it immediately
John Vandenberg
@jayvdb
Jun 24 2017 13:31
@/all, I need a patch to merge, to check rultor is working ok. Please sync any good patches
Stefan Zimmermann
@userzimmermann
Jun 24 2017 15:13
And travis is suddenly running complete tests in unsupported python 2.7 and 3.3 jobs
Causing the whole builds to fail
@jayvdb ^
Hmm... explicitly restarted 2.7 job in https://travis-ci.org/coala/coala-bears/builds/246557795 and now that passes again
did the same for 3.3 now. let's see...
John Vandenberg
@jayvdb
Jun 24 2017 15:23
coala/coala-bears#1844 is not rebased, so it is not suitable.
oh, it is.
Mridu Bhatnagar
@mridubhatnagar
Jun 24 2017 15:24
I rebased it
John Vandenberg
@jayvdb
Jun 24 2017 15:24
ugh, but that docstring is not very good
double negative
The reads like 'False is useless as it does not do anything'
Mridu Bhatnagar
@mridubhatnagar
Jun 24 2017 15:29
shall I change it?
everything has passed. I will do the changes before it merges
Mridu Bhatnagar
@mridubhatnagar
Jun 24 2017 16:02
@jayvdb I made the changes you suggested. If those are alright it can be merged.
John Vandenberg
@jayvdb
Jun 24 2017 16:24
Thx @mridubhatnagar , nicely fixed
Mridu Bhatnagar
@mridubhatnagar
Jun 24 2017 16:49
@jayvdb Thank you. :smile:
Ridhwanul Haque
@rhemon
Jun 24 2017 22:59
@jayvdb anything on #1312
John Vandenberg
@jayvdb
Jun 24 2017 23:22
I havent looked yet. @yukiisbored and @bekicot havent given any suggestions?
John Vandenberg
@jayvdb
Jun 24 2017 23:37
corobo file issue coala-bears bear proposal https://github.com/FriendsOfPHP/PHP-CS-Fixer