These are chat archives for coala/coala-bears

4th
Jul 2017
Rafid Aslam
@refeed
Jul 04 2017 02:43
this is bit mysterious, only KeywordBearTest.py:20 fails, which is using LocalBearTestHelper.verify_local_bear. But another bears that using that method don't fail
Rafid Aslam
@refeed
Jul 04 2017 03:08
hm, the problem is in Bear.py:279, still investigating why AnnotationBear can't call create_params_from_section
John Vandenberg
@jayvdb
Jul 04 2017 03:11
KeywordBear.run args are different to other bears?
Rafid Aslam
@refeed
Jul 04 2017 03:17
yeah, definitely
wait, KeywordBear is a dependent bear which depends on AnnotationBear, but why KeywordBearTest.py:20 which is using LocalBearTestHelper.verify_local_bear work before coala/coala@633f6e5 is merged to coala
Rafid Aslam
@refeed
Jul 04 2017 03:26
it shouldn't work before coala/coala@633f6e5 since there's no codepath which fill the dependency_results kwarg in KeywordBear
Rafid Aslam
@refeed
Jul 04 2017 03:36
that means AnnotationBearin KeywordBearTest.py:20 is never called before coala/coala@633f6e5 :/
John Vandenberg
@jayvdb
Jul 04 2017 03:39
Tests were badly written?
Rafid Aslam
@refeed
Jul 04 2017 03:42
hmm, yes. All KeywordBear tests' dep_results were mocked
John Vandenberg
@jayvdb
Jul 04 2017 03:44
Ok, can you create a bug describing the problem. Someone else can fix it unless you already have the answer
Sounds like the fix might need back porting
Rafid Aslam
@refeed
Jul 04 2017 03:49

Ok, can you create a bug describing the problem. Someone else can fix it unless you already have the answer

Ok

Rafid Aslam
@refeed
Jul 04 2017 04:06
alright found the fix, it just missing non-optional setting for AnnotationBear language
John Vandenberg
@jayvdb
Jul 04 2017 04:07
Ugh. Ok. This was a 0.8-0.9 problem which wasnt solved
Looks like a 'fix' created a new bug
Rafid Aslam
@refeed
Jul 04 2017 04:21
right
cobot assign coala/coala-bears#1885
coala-bot
@coala-bot
Jul 04 2017 04:23
:tada: You have been assigned to coala/coala-bears#1885
Danish Prakash
@prakashdanish
Jul 04 2017 07:53
I'm working on coala/coala-bears#1661 i'm not sure if the package name argument should be 'julia' or not https://github.com/prakashdanish/coala-bears/blob/d314c5924fcb8f8d4eabdb361ba013db7e54678a/bears/julia/JuliaLintBear.py#L28 could someone help me out here?
Danish Prakash
@prakashdanish
Jul 04 2017 08:38
John Vandenberg
@jayvdb
Jul 04 2017 08:59
@prakashdanish , you have four commits on https://github.com/coala/coala-bears/pull/1661/commits
You need to squash those commits into one commit, and that one commit needs to follow our git commit guideline http://coala.io/commit
Danish Prakash
@prakashdanish
Jul 04 2017 09:01
okay, will do that but could you take a look at the circleci test results, there seems to be an error unrelated to this issue(afait)
John Vandenberg
@jayvdb
Jul 04 2017 09:02
yea, there is an unrelated error that @refeed is working on (see above)
Mridu Bhatnagar
@mridubhatnagar
Jul 04 2017 09:43
can someone please help me with coala/coala-bears#1757. Unable to get beyond 75% code coverage. And unsure if changes seem to be right or not
Danish Prakash
@prakashdanish
Jul 04 2017 10:05
@jayvdb done, i think i'd have to wait until @refeed is done with his issue to pass all tests?
Monal Shadi
@Monal5031
Jul 04 2017 13:53
When we run coala locally, it prompts us to make changes if some issue occurs. If we make that change but accidentally create issue on same line or on next line, coala doesn't raise issue over that. Isn't this a bug?
Maybe it thinks we made the changes correctly, but i think it should check it again if changes are made correct
John Vandenberg
@jayvdb
Jul 04 2017 13:55
Ya, it is a bug. A hard one.
The only easy approach is to re-run coala at end
Monal Shadi
@Monal5031
Jul 04 2017 13:57
yeah I figured that, but thought to share the bug :sweat_smile:
John Vandenberg
@jayvdb
Jul 04 2017 13:59
it is a good one. Please search for it, or create it if u cant find it.
Monal Shadi
@Monal5031
Jul 04 2017 14:03
okay :)