These are chat archives for coala/coala-bears

16th
Jul 2017
Muhammad Kaisar Arkhan
@yukiisbored
Jul 16 2017 02:31

cobot file issue coala-bears Bear Proposal: ShebangBear
Create a bear that enforces the usage of /usr/bin/env instead of directly calling it like /usr/bin/python3. The reason why /usr/bin/env is important because it'll find the correct path for the binary we wanna use. Not every distribution follows Linux's FHS (ex. macOS, GNU Guix, Nix OS, etc).

Note: Yes, it is called Shebang. https://en.wikipedia.org/wiki/Shebang_(Unix)

coala-bot
@coala-bot
Jul 16 2017 02:31
Here you go : coala/coala-bears#1932
Danish Prakash
@prakashdanish
Jul 16 2017 06:54
cobot assign coala/coala-bears#1917
Yash Nisar
@yash-nisar
Jul 16 2017 09:40

do you have a test stderr output patch ?

@jayvdb with reference to the ArtisticStyleBear ?

John Vandenberg
@jayvdb
Jul 16 2017 09:43
No. A coala patch that catches and prints bear stderr
Yash Nisar
@yash-nisar
Jul 16 2017 09:50
Ah, got it. I can get one from any of the bears.
Here is the commit : yash-nisar/coala@e76f248
I'm thinking on how we can deliberately raise an exception for the tests.
The tests are not correct. Please ignore those. (they aren't ready yet)
John Vandenberg
@jayvdb
Jul 16 2017 09:53
@yash-nisar , imo any lint of unrecognised stderr from a linter is an error
Yash Nisar
@yash-nisar
Jul 16 2017 09:53
John Vandenberg
@jayvdb
Jul 16 2017 09:55
We may need to improve bear regexes to capture and discard some silly stderr lines, then we have a tight rule that anything not known is considered an error
jayvdb @jayvdb goes back to sleep
Lasse Schuirmann
@sils
Jul 16 2017 09:58
sleep well!
Lasse Schuirmann
@sils
Jul 16 2017 10:07
cobot mark wip coala/coala-bears#1830
coala-bot
@coala-bot
Jul 16 2017 10:07
The pull request coala/coala-bears#1830 is marked work in progress. Use cobot mark pending or push to your branch if feedback from the community is needed again.
Danish Prakash
@prakashdanish
Jul 16 2017 11:54
why is cobot assign not working?
Lasse Schuirmann
@sils
Jul 16 2017 11:54
it should, be sure to use the full URL
Danish Prakash
@prakashdanish
Jul 16 2017 11:55
cobot assign coala/coala-bears#1917
coala-bot
@coala-bot
Jul 16 2017 11:55
:tada: You have been assigned to coala/coala-bears#1917
Danish Prakash
@prakashdanish
Jul 16 2017 11:55
@sils thanks, not sure why it didn't work earlier.
Lasse Schuirmann
@sils
Jul 16 2017 13:02
@Makman2 around?
coala/coala#4471 I need a coala-bears build to test that PR on all platforms, how do you do those normally?
John Vandenberg
@jayvdb
Jul 16 2017 13:06
@sils that problem is already fixed in package-manager, just needs to be released
i cant say the patch is wrong tho. Need to wake up first and look at it
John Vandenberg
@jayvdb
Jul 16 2017 13:15
Ah, my intended path for all this was per your comment somewhere, that 'REQUIREMENTS' should be self contained. So we built ExecutableRequirement, which can be a fallback in REQUIREMENTS.
that all works, already, but we havent added ExecutableRequirement to the bears yet
Anyway, your current path doesnt prevent the path I was working towards, so no problems.
Lasse Schuirmann
@sils
Jul 16 2017 13:17
@jayvdb to completely remove the check_prerequisites? Sounds a good next step
should I make a release for package_manager?
John Vandenberg
@jayvdb
Jul 16 2017 13:18
That is my next step
i wanted the MIT thing fixed before doing another release
one person to go, last time i looked
Lasse Schuirmann
@sils
Jul 16 2017 13:19
marian-ald
John Vandenberg
@jayvdb
Jul 16 2017 13:20
yup. CabalRequirement
Lasse Schuirmann
@sils
Jul 16 2017 13:20
not on gitter anymore. Was it a creative contribution?
John Vandenberg
@jayvdb
Jul 16 2017 13:20
We can remove CabalRequirement
There are other package managers for haskell, already have issues about them
Yes, very creative
John Vandenberg
@jayvdb
Jul 16 2017 13:22
We also need a better release system for the package
Lasse Schuirmann
@sils
Jul 16 2017 13:23
we can have a release branch, whenever we merge there it goes to pypi?
John Vandenberg
@jayvdb
Jul 16 2017 13:23
have a MR , But that can be pushed to next release
Yup. Intending to build that after my MR approach is accepted or rejected
Lasse Schuirmann
@sils
Jul 16 2017 13:26
what's the reason for us having to wait for MIT for the release FWIW?
John Vandenberg
@jayvdb
Jul 16 2017 13:31
Well, for just a bugfix release, no reason to wait I guess
Lasse Schuirmann
@sils
Jul 16 2017 13:32
ok there's another bug on master that affects this
so take the GemRequirement
it has an ExecutableRequirement('gem')
which is never checked if I do GemRequirement(...).is_installed()
John Vandenberg
@jayvdb
Jul 16 2017 13:33
But i dont want to invest a lot more of time building something i can not use
We have a issue about making the REQUIREMENTS checking recursive
Lasse Schuirmann
@sils
Jul 16 2017 13:34
ok but that's not implemented yet I presume
John Vandenberg
@jayvdb
Jul 16 2017 13:34
Which can also be used for BEAR_DEPS
yup. Not built yet
Lasse Schuirmann
@sils
Jul 16 2017 13:34
ok action plan, you need MIT IIUC, I don't see marian-ald approving that MR soon, I presume you probably already tried pinging him
John Vandenberg
@jayvdb
Jul 16 2017 13:35
It is scheduled for the next minor release
I've even emailed him
Lasse Schuirmann
@sils
Jul 16 2017 13:35

But i dont want to invest a lot more of time building something i can not use

that was wrt the MIT right?

so let's just remove CabalRequirement with the relicense commit and get that done, in coala-bears we can switch CabelRequirement with an ExecutableRequirement for now
John Vandenberg
@jayvdb
Jul 16 2017 13:39
yup
Lasse Schuirmann
@sils
Jul 16 2017 13:40
I suggest making a new MR so the acks are still documented
and only requiring one ack
John Vandenberg
@jayvdb
Jul 16 2017 13:40
ya, was going to do that.
and also take a screenshot
Lasse Schuirmann
@sils
Jul 16 2017 13:42
:+1: I'll work on the recursive requirement checking with stefan right now
we'll make a Dependant base class for requirements and also for the Bear class
Lasse Schuirmann
@sils
Jul 16 2017 13:47
the Dependant will check for the requirements andthat'll introduce the recursivity along the way and remove the whole checking complexity from the bear
John Vandenberg
@jayvdb
Jul 16 2017 13:48
Nod.
Im not reliable tonight. Have toothache. waiting for dentist tmr. No promises until i have better drugs or the dentists fixes it.
Lasse Schuirmann
@sils
Jul 16 2017 13:51
cool, we'll prep everything and merge during the week
Mischa Krüger
@Makman2
Jul 16 2017 17:40
@sils this is how I include recent coala builds into coala-bears builds: https://github.com/coala/coala-bears/commits/Makman2/crosstest
however I don't have a branch doing that vice versa (grabbing coala-bears into a coala build), but porting code should mostly work I believe :+1:
John Vandenberg
@jayvdb
Jul 16 2017 17:57
I have a cross test in coala PR : coala/coala#4424
Mischa Krüger
@Makman2
Jul 16 2017 17:59
ah that's cool. Maybe you want to branch it off forever so we can reuse it when needed ;)
John Vandenberg
@jayvdb
Jul 16 2017 17:59
meh, I want to merge it.
and that is also why I want to docs out of coala repo, as this would make the coala repo builds slightly longer
and it is silly testing coala in the docker when someone only changed a .rst file
especially when they do many pushes to a PR for that one word .rst change
Mischa Krüger
@Makman2
Jul 16 2017 18:15
oh than even better :3
John Vandenberg
@jayvdb
Jul 16 2017 18:44
coala/docker-coala-base#206 is ready