These are chat archives for coala/coala-bears

28th
Oct 2017
Danish Prakash
@prakashdanish
Oct 28 2017 01:22
corobo assign coala/coala-bears#2083
corobo
@co-robo
Oct 28 2017 01:22
You are not eligible to be assigned to this issue.
  • You must be a member of coala org to be assigned an issue If you are not a member yet, just type Hello World and corobo will invite you.
  • A newcomer cannot be assigned to an issue with a difficulty level higher than newcomer or low difficulty.
  • A newcomer cannot be assigned to unlabelled issues.- initiatives/gci labelled issue assignments are blocked.
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 08:59

Need Help I made changes in Bear file and I run test of that Bear by running their test but, suppose i made changes on PySafetyBear and i run its test and its runs fine

(coala-venv) vaibhav@vaibhav-HP-Notebook:~/mycoala/coala-bears/tests/python/requirements$ python3 PySafetyBearTest.py 
(coala-venv) vaibhav@vaibhav-HP-Notebook:~/mycoala/coala-bears/tests/python/requirements$

but What if I have to run it locally for.ex on my requriement.txt file

How do I test my changes on my local file??
John Vandenberg
@jayvdb
Oct 28 2017 09:03
running coala locally is covered by the user guide.
adding test cases for bears is covered (but not in a lot of detail) in the developer docs
if you want to add more tests, you need to add them to PySafetyBearTest.py
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 09:43

@jayvdb correct me if I am wrong I cloned repo , made changes , run its test by using PySafetyBearTest.py
For locally testing I have done here

(coala-venv) vaibhav@vaibhav-HP-Notebook:~/mycoala$ ls -a
.  ..  coala  coala-bears  coala-venv  requirement.txt  requirement.txt.orig
(coala-venv) vaibhav@vaibhav-HP-Notebook:~/mycoala$ 

(coala-venv) vaibhav@vaibhav-HP-Notebook:~/mycoala$ coala -f requirement.txt -d mycoala/coala-bears/bears/python/requirements/ -b PySafetyBear -V

Am i going in correct direction??

John Vandenberg
@jayvdb
Oct 28 2017 12:21
did it work?
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 12:49
No
Mischa Krüger
@Makman2
Oct 28 2017 14:26
you can run our tests with py.test, if you want to test something specific, you can e.g. do py.test -k PySafetyBearTest
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 14:28
:+1:
Rohit Upadhyay
@urohit011
Oct 28 2017 14:30
corobo assign coala/coala-bears#2078
corobo
@co-robo
Oct 28 2017 14:30
Command "assign" / "assign coala/coala-bears#2078" not found.
Rohit Upadhyay
@urohit011
Oct 28 2017 14:31
corobo assign coala/coala-bears#2078
corobo
@co-robo
Oct 28 2017 14:31
Congratulations! You've been assigned to the issue. :tada:
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 16:03
Circle CI failing bash.ci/deps.opam.sh
https://circleci.com/gh/RaiVaibhav/coala-bears/4
last time also same problem occurs with me when I runned Circle CI without any changes
@Makman2 need your help in getting the travis log in coala/coala-bears#2087 as my changes runs fine on my local machine
John Vandenberg
@jayvdb
Oct 28 2017 16:09
@RaiVaibhav , restart the build a few times ... once it is done, opam will be cached and it wont fail again
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 16:11
:+1: i will do it but i will first try to get why the coverage of PySafetyBear is 96%
and why bash .ci/tests.sh exit with 1
John Vandenberg
@jayvdb
Oct 28 2017 16:13
likely those are the same problem
and you need to add a test for your new lines of code
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 16:16
IMO I think the PySafetyBearTest.py is all fine, my PR was there to solve a bug
John Vandenberg
@jayvdb
Oct 28 2017 16:16
if you added new lines, you need to add tests
that is the general rule
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 16:16
ok,I just used try and except
:+1:
Pranav Dixit
@prnvdixit
Oct 28 2017 16:30

So, add a test which let the except part of code to run (i.e. for which the original code would have given exception) - The only reason why this except code wasn't already there is due to the absence of relevant test only :stuck_out_tongue:

ok,I just used try and except

Vaibhav Rai
@RaiVaibhav
Oct 28 2017 18:21
So, add a test which let the except part of code to run (i.e. for which the original code would have given exception) - The only reason why this except code wasn't already there is due to the absence of relevant test only :stuck_out_tongue:
ok,I just used try and except
:+1:
But I am focus to pass the CI build first :
:smile:
Shreyans
@shreyans800755
Oct 28 2017 19:11
@RaiVaibhav Your CI build is failing because you have not added tests. See the coverage part of travis CI
Coverage must always be 100%
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 20:02
:+1:
stellargo
@stellargo
Oct 28 2017 20:31
corobo assign coala/coala#1101
corobo
@co-robo
Oct 28 2017 20:31
Congratulations! You've been assigned to the issue. :tada:
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 20:57
I don't Understand why Circle CI is not building please help coala/coala-bears#2087
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 21:33
Please check the issue with Circle CI and guide me
corobo assign something
corobo
@co-robo
Oct 28 2017 21:34
Command "assign" / "assign something" not found.
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 21:35
corobo explain review
corobo
@co-robo
Oct 28 2017 21:35
Command "review" not found.
Vaibhav Rai
@RaiVaibhav
Oct 28 2017 21:35
corobo explain review
corobo
@co-robo
Oct 28 2017 21:35

After creating your Pull Request, it is under the review process. This can be deduced from the process/pending review label. Now you have to wait for the reviewers to review your PR. You should not ask for reviews on our Gitter channel - we review those PRs continuously.

We're usually swamped with reviews, while you are waiting please review other people's PRs at coala.io/review: that helps you and will make your review happen faster as well. As a rule of thumb, for every review you receive, give at least one review to someone else!

For a good review, look at every commit on its own and place ack <sha>(commit is ready) or unack <sha>(commit needs work) needs work comments on the pull request, be sure to remove other spacing like tabs. If you're done with a pull request, you can use corobo mark wip <pull URL> to mark it work in progress finally.